ajantha-bhat commented on code in PR #12226:
URL: https://github.com/apache/iceberg/pull/12226#discussion_r2002428277
##########
data/src/test/java/org/apache/iceberg/data/TestPartitionStatsHandler.java:
##########
@@ -591,7 +591,7 @@ private static boolean isEqual(
&& stats1.positionDeleteFileCount() == stats2.positionDeleteFileCount()
&& stats1.equalityDeleteRecordCount() ==
stats2.equalityDeleteRecordCount()
&& stats1.equalityDeleteFileCount() == stats2.equalityDeleteFileCount()
- && stats1.totalRecordCount() == stats2.totalRecordCount()
+ && Objects.equals(stats1.totalRecords(), stats2.totalRecords())
Review Comment:
`PartitionStats` has `StructLike` member for `partition`, it needs a
comparator for equals(). But storing comparator for each `PartitionStats` is
not efficient. Plus we also want to keep the members of this class same as
partition stats spec.
It was discussed in one of the old PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
