sungwy commented on code in PR #1632: URL: https://github.com/apache/iceberg-python/pull/1632#discussion_r2002311502
########## pyiceberg/types.py: ########## Review Comment: Thanks for chiming in @smaheshwar-pltr . Appreciate the review. I just read the spec again, and it the spec seems to suggest the following: - date to timestamp and timestamp_ns is supported - date to timestamptz and timestamptz_ns is "not" supported Referring to the Java code, I see that there is no valid promotion specified for Date type. Would it make sense to introduce support for nanoseconds type first, and then work on introducing the reference implementation in Java first for this type promotion before implementing in PyIceberg? @Fokko @kevinjqliu ########## pyiceberg/types.py: ########## Review Comment: Thanks for chiming in @smaheshwar-pltr . Appreciate the review. I read the last column that mentioned that promotion to timestamp and timestamp_ns. is "not" allowed, but looking at the column for v3 spec, it seems to suggest otherwise. Hence I think this is worth clarifying with the community. Referring to the Java code, I see that there is no valid promotion specified for `Date` type. Let me raise question in the dev list and clarify this -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
