Kontinuation commented on code in PR #12346: URL: https://github.com/apache/iceberg/pull/12346#discussion_r2002260593
########## core/src/main/java/org/apache/iceberg/util/GeometryUtil.java: ########## @@ -0,0 +1,77 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.iceberg.util; + +import org.locationtech.jts.geom.Coordinate; +import org.locationtech.jts.geom.Geometry; +import org.locationtech.jts.io.WKBReader; +import org.locationtech.jts.io.WKBWriter; +import org.locationtech.jts.io.WKTReader; +import org.locationtech.jts.io.WKTWriter; + +public class GeometryUtil { + + private GeometryUtil() {} + + private static final int DEFAULT_DIMENSION = 2; + + public static byte[] toWKB(Geometry geom) { + WKBWriter wkbWriter = new WKBWriter(getOutputDimension(geom), false); + return wkbWriter.write(geom); + } + + public static String toWKT(Geometry geom) { + WKTWriter wktWriter = new WKTWriter(getOutputDimension(geom)); + return wktWriter.write(geom); + } + + public static Geometry fromWKB(byte[] wkb) { + WKBReader reader = new WKBReader(); + try { + return reader.read(wkb); + } catch (Exception e) { + throw new IllegalArgumentException("Failed to parse WKB", e); + } + } + + public static Geometry fromWKT(String wkt) { + WKTReader reader = new WKTReader(); + try { + return reader.read(wkt); + } catch (Exception e) { + throw new IllegalArgumentException("Failed to parse WKT", e); + } + } + + private static int getOutputDimension(Geometry geom) { + int dimension = DEFAULT_DIMENSION; + Coordinate coordinate = geom.getCoordinate(); + + // We need to set outputDimension = 4 for XYM geometries to make JTS WKTWriter or WKBWriter work + // correctly. + // The WKB/WKT writers will ignore Z ordinate for XYM geometries. + if (!Double.isNaN(coordinate.getZ())) { + dimension = 3; + } + if (!Double.isNaN(coordinate.getM())) { Review Comment: We removed this file, as we removed JTS and single value serialization support for geospatial types. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
