Kontinuation commented on code in PR #12346:
URL: https://github.com/apache/iceberg/pull/12346#discussion_r2002253930
##########
api/src/main/java/org/apache/iceberg/types/Types.java:
##########
@@ -543,6 +563,122 @@ public int hashCode() {
}
}
+ public static class GeometryType extends PrimitiveType {
+
+ private final String crs;
+
+ private GeometryType(String crs) {
+ Preconditions.checkNotNull(crs, "CRS cannot be null");
+ this.crs = crs;
+ }
+
+ public static GeometryType get() {
+ return new GeometryType("");
Review Comment:
We are using `null` for now. Now I believe that using `OGC:CRS84` could be a
better choice. See the comments for `GeographyType.toString` below.
##########
api/src/main/java/org/apache/iceberg/types/Types.java:
##########
@@ -543,6 +563,122 @@ public int hashCode() {
}
}
+ public static class GeometryType extends PrimitiveType {
+
+ private final String crs;
+
+ private GeometryType(String crs) {
+ Preconditions.checkNotNull(crs, "CRS cannot be null");
+ this.crs = crs;
+ }
+
+ public static GeometryType get() {
+ return new GeometryType("");
Review Comment:
We are using `null` for now. Now I believe that using `"OGC:CRS84"` could be
a better choice. See the comments for `GeographyType.toString` below.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
