Kontinuation commented on code in PR #12346:
URL: https://github.com/apache/iceberg/pull/12346#discussion_r2002256813
##########
api/src/main/java/org/apache/iceberg/types/Types.java:
##########
@@ -58,9 +58,15 @@ private Types() {}
.put(BinaryType.get().toString(), BinaryType.get())
.put(UnknownType.get().toString(), UnknownType.get())
.put(VariantType.get().toString(), VariantType.get())
+ .put(GeometryType.get().toString(), GeometryType.get())
+ .put(GeographyType.get().toString(), GeographyType.get())
.buildOrThrow();
private static final Pattern FIXED =
Pattern.compile("fixed\\[\\s*(\\d+)\\s*\\]");
+ private static final Pattern GEOMETRY_PARAMETERS =
+ Pattern.compile("(?:\\(\\s*([^, ]+)?\\s*\\))?");
+ private static final Pattern GEOGRAPHY_PARAMETERS =
+ Pattern.compile("(?:\\(\\s*([^, ]+)?\\s*(?:,\\s*(\\w*)\\s*)?\\))?");
Review Comment:
Fixed. Now we allow spaces inside CRS.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
