Re: [PR] [1.7.x] Fix `{LICENSE,NOTICE}` for Flink Runtime [iceberg]

2025-02-20 Thread via GitHub
nastra commented on code in PR #12358: URL: https://github.com/apache/iceberg/pull/12358#discussion_r1965018819 ## flink/v1.20/flink-runtime/LICENSE: ## @@ -1,4 +1,5 @@ + Review Comment: ```suggestion ``` -- This is an automated message from the Apache Git Service.

Re: [I] TestS3FileIO fails locally (on OSX with Docker Desktop) due to missing Content-MD5 header during delete [iceberg]

2025-02-20 Thread via GitHub
nastra commented on issue #12237: URL: https://github.com/apache/iceberg/issues/12237#issuecomment-2673792216 Worth mentioninig that this issue started to happen after we upgraded the AWS SDK to 2.30.0, which added changes to the default integrity protection (see https://github.com/aws/aws-

Re: [I] Support row filter & column masking in REST spec [iceberg]

2025-02-20 Thread via GitHub
rameeshm commented on issue #10909: URL: https://github.com/apache/iceberg/issues/10909#issuecomment-2673689946 I am looking for this enhancement as well. Is it something I can help with, I am more than happy to do so. thanks -- This is an automated message from the Apache Git Service. To

Re: [PR] Build: Bump mkdocs-material from 9.6.4 to 9.6.5 [iceberg-python]

2025-02-20 Thread via GitHub
Fokko merged PR #1696: URL: https://github.com/apache/iceberg-python/pull/1696 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceber

Re: [PR] feat: Add `StrictMetricsEvaluator` [iceberg-rust]

2025-02-20 Thread via GitHub
jonathanc-n commented on PR #963: URL: https://github.com/apache/iceberg-rust/pull/963#issuecomment-2673583467 @liurenjie1024 @Fokko Thank you for the reviews, problems should be resolved. -- This is an automated message from the Apache Git Service. To respond to the message, please log on

Re: [PR] Add Variant custom logical type for Avro [iceberg]

2025-02-20 Thread via GitHub
aihuaxu commented on code in PR #12238: URL: https://github.com/apache/iceberg/pull/12238#discussion_r1964909576 ## core/src/main/java/org/apache/iceberg/avro/VariantLogicalType.java: ## @@ -0,0 +1,47 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or m

Re: [PR] feat: Add existing parquet files [iceberg-rust]

2025-02-20 Thread via GitHub
jonathanc-n commented on code in PR #960: URL: https://github.com/apache/iceberg-rust/pull/960#discussion_r1964898137 ## crates/iceberg/src/transaction.rs: ## @@ -205,6 +252,64 @@ impl<'a> FastAppendAction<'a> { Ok(self) } +/// Adds existing parquet files +

Re: [PR] feat: Add existing parquet files [iceberg-rust]

2025-02-20 Thread via GitHub
jonathanc-n commented on code in PR #960: URL: https://github.com/apache/iceberg-rust/pull/960#discussion_r1964886069 ## crates/iceberg/src/writer/file_writer/parquet_writer.rs: ## @@ -391,6 +404,79 @@ impl ParquetWriter { ); Ok(builder) } + +/// `

Re: [PR] Fix TypeError in create_match_filter for Composite Keys with Single Unique Condition [iceberg-python]

2025-02-20 Thread via GitHub
omkenge commented on PR #1693: URL: https://github.com/apache/iceberg-python/pull/1693#issuecomment-2673517716 **Issue:** When no rows are updated (i.e., none of the source composite keys match the target), the code calls pa.Table.from_arrays([], names=...). This passes 0 arrays for a sc

Re: [PR] Use Snapshot's statistics file in SparkScan [iceberg]

2025-02-20 Thread via GitHub
jeesou commented on code in PR #11040: URL: https://github.com/apache/iceberg/pull/11040#discussion_r1964871553 ## api/src/main/java/org/apache/iceberg/Table.java: ## @@ -373,4 +374,14 @@ default Snapshot snapshot(String name) { return null; } + + /** + * Returns th

Re: [PR] feat: Introduce C FFI for iceberg rust [iceberg-rust]

2025-02-20 Thread via GitHub
lidavidm commented on PR #966: URL: https://github.com/apache/iceberg-rust/pull/966#issuecomment-2673451050 Good to know, thanks! I have run into `cxx` in an internal project and IMO even with that it takes some manual wrapping to generate "nice" APIs. As far as I am concerne

Re: [PR] feat: Introduce C FFI for iceberg rust [iceberg-rust]

2025-02-20 Thread via GitHub
Xuanwo commented on PR #966: URL: https://github.com/apache/iceberg-rust/pull/966#issuecomment-2673388726 For @wgtmac > * Is it a battery-included solution or is flexible enough to let downstreams plugin their own implementations of I/O (cloud object store, hdfs, async I/O, etc.), f

Re: [PR] add dataframes to data files [iceberg-python]

2025-02-20 Thread via GitHub
jimmyxie-figma commented on PR #1677: URL: https://github.com/apache/iceberg-python/pull/1677#issuecomment-2673218581 > @jimmyxie-figma Thanks for raising this PR > > Did you consider just concat'ing the tables: > > ```python > table = pa.concat_tables(tables, promote_options

Re: [PR] Add Variant custom logical type for Avro [iceberg]

2025-02-20 Thread via GitHub
XBaith commented on code in PR #12238: URL: https://github.com/apache/iceberg/pull/12238#discussion_r1964705927 ## core/src/main/java/org/apache/iceberg/avro/VariantLogicalType.java: ## @@ -0,0 +1,47 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or mo

Re: [I] [feature] Table Scan should take into account the table's sort order [iceberg-python]

2025-02-20 Thread via GitHub
gabeiglio commented on issue #1637: URL: https://github.com/apache/iceberg-python/issues/1637#issuecomment-2673196297 > pruning manifests. use the table's sort order to efficiently skip manifest's based on its min/max values (i think this should be part of _InclusiveMetricsEvaluator above)

Re: [PR] Spec: add variant type [iceberg]

2025-02-20 Thread via GitHub
ronkorving commented on code in PR #10831: URL: https://github.com/apache/iceberg/pull/10831#discussion_r1964622918 ## format/spec.md: ## @@ -182,6 +182,20 @@ A **`list`** is a collection of values with some element type. The element field A **`map`** is a collection of key-

Re: [PR] API: Move variant to API and add extract expression [iceberg]

2025-02-20 Thread via GitHub
rdblue merged PR #12304: URL: https://github.com/apache/iceberg/pull/12304 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.ap

Re: [PR] API: Move variant to API and add extract expression [iceberg]

2025-02-20 Thread via GitHub
rdblue commented on PR #12304: URL: https://github.com/apache/iceberg/pull/12304#issuecomment-2673141341 Thanks for the reviews, @danielcweeks and @aihuaxu! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

Re: [PR] Core,Api: Add overwrite option when register external table to catalog [iceberg]

2025-02-20 Thread via GitHub
dramaticlly commented on code in PR #12228: URL: https://github.com/apache/iceberg/pull/12228#discussion_r1964589167 ## core/src/main/java/org/apache/iceberg/BaseMetastoreCatalog.java: ## @@ -71,23 +71,23 @@ public Table loadTable(TableIdentifier identifier) { } @Overrid

Re: [PR] Core,Api: Add overwrite option when register external table to catalog [iceberg]

2025-02-20 Thread via GitHub
dramaticlly commented on code in PR #12228: URL: https://github.com/apache/iceberg/pull/12228#discussion_r1964589167 ## core/src/main/java/org/apache/iceberg/BaseMetastoreCatalog.java: ## @@ -71,23 +71,23 @@ public Table loadTable(TableIdentifier identifier) { } @Overrid

Re: [PR] Parquet: Implement Variant writers [iceberg]

2025-02-20 Thread via GitHub
rdblue commented on code in PR #12323: URL: https://github.com/apache/iceberg/pull/12323#discussion_r1964585019 ## core/src/main/java/org/apache/iceberg/variants/VariantData.java: ## @@ -0,0 +1,43 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more

Re: [PR] API: Move variant to API and add extract expression [iceberg]

2025-02-20 Thread via GitHub
rdblue commented on code in PR #12304: URL: https://github.com/apache/iceberg/pull/12304#discussion_r1964535688 ## api/src/main/java/org/apache/iceberg/variants/VariantData.java: ## @@ -0,0 +1,67 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more c

Re: [I] Extends Iceberg table stats API to allow publish data and stats atomically [iceberg]

2025-02-20 Thread via GitHub
github-actions[bot] commented on issue #6442: URL: https://github.com/apache/iceberg/issues/6442#issuecomment-2673005054 This issue has been automatically marked as stale because it has been open for 180 days with no activity. It will be closed in next 14 days if no further activity occurs.

Re: [PR] API: Move variant to API and add extract expression [iceberg]

2025-02-20 Thread via GitHub
rdblue commented on code in PR #12304: URL: https://github.com/apache/iceberg/pull/12304#discussion_r1964535327 ## api/src/main/java/org/apache/iceberg/variants/Variant.java: ## @@ -25,4 +25,24 @@ public interface Variant { /** Returns the variant value. */ VariantValue

Re: [I] Add benchmark to the CI [iceberg-python]

2025-02-20 Thread via GitHub
github-actions[bot] commented on issue #27: URL: https://github.com/apache/iceberg-python/issues/27#issuecomment-2673010834 This issue has been automatically marked as stale because it has been open for 180 days with no activity. It will be closed in next 14 days if no further activity occu

Re: [PR] Avro: Add variant type support [iceberg]

2025-02-20 Thread via GitHub
github-actions[bot] closed pull request #11934: Avro: Add variant type support URL: https://github.com/apache/iceberg/pull/11934 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] support uri not end with character '/' in rest catalog [iceberg]

2025-02-20 Thread via GitHub
github-actions[bot] closed pull request #11392: support uri not end with character '/' in rest catalog URL: https://github.com/apache/iceberg/pull/11392 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

Re: [PR] Core, Spark: Minimize executor memory pressure in broadcast of data to delete files [iceberg]

2025-02-20 Thread via GitHub
github-actions[bot] commented on PR #11957: URL: https://github.com/apache/iceberg/pull/11957#issuecomment-2673005863 This pull request has been closed due to lack of activity. This is not a judgement on the merit of the PR in any way. It is just a way of keeping the PR queue manageable. If

Re: [PR] Avro: Add variant type support [iceberg]

2025-02-20 Thread via GitHub
github-actions[bot] commented on PR #11934: URL: https://github.com/apache/iceberg/pull/11934#issuecomment-2673005796 This pull request has been closed due to lack of activity. This is not a judgement on the merit of the PR in any way. It is just a way of keeping the PR queue manageable. If

Re: [PR] Remove unneeded metadata read during update event generation [iceberg]

2025-02-20 Thread via GitHub
github-actions[bot] closed pull request #11829: Remove unneeded metadata read during update event generation URL: https://github.com/apache/iceberg/pull/11829 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

Re: [PR] Core, Spark: Minimize executor memory pressure in broadcast of data to delete files [iceberg]

2025-02-20 Thread via GitHub
github-actions[bot] closed pull request #11957: Core, Spark: Minimize executor memory pressure in broadcast of data to delete files URL: https://github.com/apache/iceberg/pull/11957 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

Re: [PR] Core: Refactor Table Metadata Tests [iceberg]

2025-02-20 Thread via GitHub
github-actions[bot] commented on PR #11947: URL: https://github.com/apache/iceberg/pull/11947#issuecomment-2673005822 This pull request has been marked as stale due to 30 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pul

Re: [PR] Spark: add property to disable client-side purging in spark [iceberg]

2025-02-20 Thread via GitHub
github-actions[bot] commented on PR #11317: URL: https://github.com/apache/iceberg/pull/11317#issuecomment-2673005308 This pull request has been marked as stale due to 30 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pul

Re: [PR] Remove unneeded metadata read during update event generation [iceberg]

2025-02-20 Thread via GitHub
github-actions[bot] commented on PR #11829: URL: https://github.com/apache/iceberg/pull/11829#issuecomment-2673005709 This pull request has been closed due to lack of activity. This is not a judgement on the merit of the PR in any way. It is just a way of keeping the PR queue manageable. If

Re: [PR] support uri not end with character '/' in rest catalog [iceberg]

2025-02-20 Thread via GitHub
github-actions[bot] commented on PR #11392: URL: https://github.com/apache/iceberg/pull/11392#issuecomment-2673005358 This pull request has been closed due to lack of activity. This is not a judgement on the merit of the PR in any way. It is just a way of keeping the PR queue manageable. If

Re: [PR] API: Move variant to API and add extract expression [iceberg]

2025-02-20 Thread via GitHub
rdblue commented on code in PR #12304: URL: https://github.com/apache/iceberg/pull/12304#discussion_r1964535894 ## api/src/main/java/org/apache/iceberg/variants/VariantDataUtil.java: ## @@ -0,0 +1,64 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or mo

Re: [PR] API: Move variant to API and add extract expression [iceberg]

2025-02-20 Thread via GitHub
rdblue commented on code in PR #12304: URL: https://github.com/apache/iceberg/pull/12304#discussion_r1964535327 ## api/src/main/java/org/apache/iceberg/variants/Variant.java: ## @@ -25,4 +25,24 @@ public interface Variant { /** Returns the variant value. */ VariantValue

Re: [PR] feat: Introduce C FFI for iceberg rust [iceberg-rust]

2025-02-20 Thread via GitHub
lidavidm commented on PR #966: URL: https://github.com/apache/iceberg-rust/pull/966#issuecomment-2672986293 I'm also curious if there's any potential for linking issues if say, we use this (with OpenDAL enabled) and also OpenDAL's C++ bindings separately. (For another project, we have recei

Re: [PR] Parquet: Implement Variant writers [iceberg]

2025-02-20 Thread via GitHub
rdblue commented on code in PR #12323: URL: https://github.com/apache/iceberg/pull/12323#discussion_r1964509422 ## parquet/src/main/java/org/apache/iceberg/parquet/ParquetValueWriters.java: ## @@ -71,6 +71,10 @@ public static UnboxedWriter shorts(ColumnDescriptor desc) { r

Re: [PR] Parquet: Implement Variant writers [iceberg]

2025-02-20 Thread via GitHub
rdblue commented on code in PR #12323: URL: https://github.com/apache/iceberg/pull/12323#discussion_r1964508977 ## parquet/src/main/java/org/apache/iceberg/parquet/Parquet.java: ## @@ -160,9 +161,10 @@ public static class WriteBuilder implements InternalData.WriteBuilder {

Re: [PR] Parquet: Implement Variant writers [iceberg]

2025-02-20 Thread via GitHub
rdblue commented on code in PR #12323: URL: https://github.com/apache/iceberg/pull/12323#discussion_r1964508538 ## parquet/src/main/java/org/apache/iceberg/parquet/Parquet.java: ## @@ -192,6 +194,11 @@ public WriteBuilder schema(Schema newSchema) { return this; } +

Re: [PR] Parquet: Implement Variant writers [iceberg]

2025-02-20 Thread via GitHub
rdblue commented on code in PR #12323: URL: https://github.com/apache/iceberg/pull/12323#discussion_r1964506375 ## core/src/main/java/org/apache/iceberg/variants/Variants.java: ## @@ -85,6 +85,16 @@ public static ShreddedObject object(VariantMetadata metadata) { return new

Re: [PR] Parquet: Implement Variant writers [iceberg]

2025-02-20 Thread via GitHub
rdblue commented on code in PR #12323: URL: https://github.com/apache/iceberg/pull/12323#discussion_r1964507242 ## parquet/src/main/java/org/apache/iceberg/data/parquet/BaseParquetWriter.java: ## @@ -62,7 +71,7 @@ protected ParquetValueWriter timestampWriter(ColumnDescriptor de

Re: [PR] Materialized View Spec [iceberg]

2025-02-20 Thread via GitHub
stevenzwu commented on code in PR #11041: URL: https://github.com/apache/iceberg/pull/11041#discussion_r1964502576 ## format/view-spec.md: ## @@ -160,6 +179,57 @@ Each entry in `version-log` is a struct with the following fields: | _required_ | `timestamp-ms` | Timestamp when

Re: [PR] Core: REST Catalog OAuth2 Support Refresh Token Flow [iceberg]

2025-02-20 Thread via GitHub
nika-qubit commented on code in PR #12362: URL: https://github.com/apache/iceberg/pull/12362#discussion_r1964501692 ## core/src/test/java/org/apache/iceberg/rest/TestRESTCatalog.java: ## @@ -1390,6 +1391,108 @@ public void testCatalogTokenRefresh(String oauth2ServerUri) {

Re: [PR] Core: REST Catalog [iceberg]

2025-02-20 Thread via GitHub
nika-qubit commented on PR #12362: URL: https://github.com/apache/iceberg/pull/12362#issuecomment-2672939035 Rebased to the latest main HEAD at this moment. Added test is `./gradlew :iceberg-core:test --tests org.apache.iceberg.rest.TestRESTCatalog.testCatalogTokenRefreshByRefreshToke

Re: [I] [REST Catalog] OAuth 2 grant type "refresh_token" not implemented [iceberg]

2025-02-20 Thread via GitHub
nika-qubit commented on issue #12196: URL: https://github.com/apache/iceberg/issues/12196#issuecomment-2672938099 Could someone please review it? Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [I] [REST Catalog] OAuth 2 grant type "refresh_token" not implemented [iceberg]

2025-02-20 Thread via GitHub
nika-qubit commented on issue #12196: URL: https://github.com/apache/iceberg/issues/12196#issuecomment-2672937721 PR opened: https://github.com/apache/iceberg/pull/12362 Rebased to the latest main HEAD at this moment. Added test is `./gradlew :iceberg-core:test --tests org.apac

[PR] Core: REST Catalog [iceberg]

2025-02-20 Thread via GitHub
nika-qubit opened a new pull request, #12362: URL: https://github.com/apache/iceberg/pull/12362 Supported refreshing token using the refresh token flow in addition to token exchange flow for OAuth2. Closes #12196 -- This is an automated message from the Apache Git Service. To respo

Re: [PR] API: Move variant to API and add extract expression [iceberg]

2025-02-20 Thread via GitHub
rdblue commented on code in PR #12304: URL: https://github.com/apache/iceberg/pull/12304#discussion_r1964492886 ## api/src/main/java/org/apache/iceberg/variants/Variant.java: ## @@ -25,4 +25,24 @@ public interface Variant { /** Returns the variant value. */ VariantValue

Re: [PR] API: Move variant to API and add extract expression [iceberg]

2025-02-20 Thread via GitHub
rdblue commented on code in PR #12304: URL: https://github.com/apache/iceberg/pull/12304#discussion_r1964492397 ## api/src/main/java/org/apache/iceberg/variants/VariantDataUtil.java: ## @@ -0,0 +1,64 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or mo

Re: [PR] Add Variant custom logical type for Avro [iceberg]

2025-02-20 Thread via GitHub
aihuaxu commented on code in PR #12238: URL: https://github.com/apache/iceberg/pull/12238#discussion_r1964486203 ## core/src/main/java/org/apache/iceberg/avro/TypeToSchema.java: ## @@ -187,6 +187,21 @@ public Schema map(Types.MapType map, Schema keySchema, Schema valueSchema) {

Re: [PR] Deprecate for 0.9.0 release [iceberg-python]

2025-02-20 Thread via GitHub
kevinjqliu commented on code in PR #1689: URL: https://github.com/apache/iceberg-python/pull/1689#discussion_r1964424951 ## pyiceberg/expressions/parser.py: ## @@ -90,13 +89,7 @@ @column.set_parse_action def _(result: ParseResults) -> Reference: if len(result.column) > 1:

[PR] Build: Bump boto3 from 1.36.3 to 1.36.23 [iceberg-python]

2025-02-20 Thread via GitHub
dependabot[bot] opened a new pull request, #1694: URL: https://github.com/apache/iceberg-python/pull/1694 Bumps [boto3](https://github.com/boto/boto3) from 1.36.3 to 1.36.23. Commits https://github.com/boto/boto3/commit/2872f3e31394379f8f8cecb06e9af38997d1b7a9";>2872f3e Merge b

[PR] Build: Bump mkdocs-material from 9.6.4 to 9.6.5 [iceberg-python]

2025-02-20 Thread via GitHub
dependabot[bot] opened a new pull request, #1696: URL: https://github.com/apache/iceberg-python/pull/1696 Bumps [mkdocs-material](https://github.com/squidfunk/mkdocs-material) from 9.6.4 to 9.6.5. Release notes Sourced from https://github.com/squidfunk/mkdocs-material/releases";>mk

[PR] Build: Bump cachetools from 5.5.1 to 5.5.2 [iceberg-python]

2025-02-20 Thread via GitHub
dependabot[bot] opened a new pull request, #1695: URL: https://github.com/apache/iceberg-python/pull/1695 Bumps [cachetools](https://github.com/tkem/cachetools) from 5.5.1 to 5.5.2. Changelog Sourced from https://github.com/tkem/cachetools/blob/master/CHANGELOG.rst";>cachetools's c

[PR] feat(catalog/glue): add checkNamespaceExist [iceberg-go]

2025-02-20 Thread via GitHub
dttung2905 opened a new pull request, #312: URL: https://github.com/apache/iceberg-go/pull/312 Hi team, Its a smaller PR this time round. I did a check in the https://pkg.go.dev/github.com/aws/aws-sdk-go-v2/service/glue but couldnt find any method to directly check namespace's existance.

Re: [PR] Deprecate for 0.9.0 release [iceberg-python]

2025-02-20 Thread via GitHub
geruh commented on code in PR #1689: URL: https://github.com/apache/iceberg-python/pull/1689#discussion_r1964388377 ## pyiceberg/expressions/parser.py: ## @@ -90,13 +89,7 @@ @column.set_parse_action def _(result: ParseResults) -> Reference: if len(result.column) > 1: -

Re: [PR] API: Move variant to API and add extract expression [iceberg]

2025-02-20 Thread via GitHub
danielcweeks commented on code in PR #12304: URL: https://github.com/apache/iceberg/pull/12304#discussion_r1964386149 ## api/src/main/java/org/apache/iceberg/variants/VariantDataUtil.java: ## @@ -0,0 +1,46 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + *

Re: [PR] API: Move variant to API and add extract expression [iceberg]

2025-02-20 Thread via GitHub
danielcweeks commented on code in PR #12304: URL: https://github.com/apache/iceberg/pull/12304#discussion_r1964390948 ## api/src/main/java/org/apache/iceberg/variants/VariantData.java: ## @@ -0,0 +1,67 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or

Re: [PR] API: Move variant to API and add extract expression [iceberg]

2025-02-20 Thread via GitHub
danielcweeks commented on code in PR #12304: URL: https://github.com/apache/iceberg/pull/12304#discussion_r1964388546 ## api/src/main/java/org/apache/iceberg/variants/VariantDataUtil.java: ## @@ -0,0 +1,64 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + *

Re: [PR] Deprecate for 0.9.0 release [iceberg-python]

2025-02-20 Thread via GitHub
geruh commented on code in PR #1689: URL: https://github.com/apache/iceberg-python/pull/1689#discussion_r1964388377 ## pyiceberg/expressions/parser.py: ## @@ -90,13 +89,7 @@ @column.set_parse_action def _(result: ParseResults) -> Reference: if len(result.column) > 1: -

Re: [PR] API: Move variant to API and add extract expression [iceberg]

2025-02-20 Thread via GitHub
danielcweeks commented on code in PR #12304: URL: https://github.com/apache/iceberg/pull/12304#discussion_r1964387424 ## api/src/main/java/org/apache/iceberg/variants/VariantDataUtil.java: ## @@ -0,0 +1,64 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + *

Re: [PR] API: Move variant to API and add extract expression [iceberg]

2025-02-20 Thread via GitHub
danielcweeks commented on code in PR #12304: URL: https://github.com/apache/iceberg/pull/12304#discussion_r1964386149 ## api/src/main/java/org/apache/iceberg/variants/VariantDataUtil.java: ## @@ -0,0 +1,46 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + *

Re: [PR] API: Move variant to API and add extract expression [iceberg]

2025-02-20 Thread via GitHub
danielcweeks commented on code in PR #12304: URL: https://github.com/apache/iceberg/pull/12304#discussion_r1964369050 ## api/src/main/java/org/apache/iceberg/variants/Variant.java: ## @@ -25,4 +25,24 @@ public interface Variant { /** Returns the variant value. */ Variant

Re: [PR] Add Variant custom logical type for Avro [iceberg]

2025-02-20 Thread via GitHub
aihuaxu commented on code in PR #12238: URL: https://github.com/apache/iceberg/pull/12238#discussion_r1964351443 ## core/src/main/java/org/apache/iceberg/avro/BaseWriteBuilder.java: ## @@ -64,6 +64,11 @@ public ValueWriter map(Schema map, ValueWriter valueWriter) { return

Re: [PR] API: Move variant to API and add extract expression [iceberg]

2025-02-20 Thread via GitHub
danielcweeks commented on code in PR #12304: URL: https://github.com/apache/iceberg/pull/12304#discussion_r1964346663 ## api/src/main/java/org/apache/iceberg/variants/Variant.java: ## @@ -25,4 +25,24 @@ public interface Variant { /** Returns the variant value. */ Variant

Re: [PR] S3: Disable strong integrity checksums [iceberg]

2025-02-20 Thread via GitHub
RussellSpitzer commented on PR #12264: URL: https://github.com/apache/iceberg/pull/12264#issuecomment-2672695747 @ebyhr How hard would it be for us to get some integration tests with one of these systems into the Iceberg project? Seems like we should have some coverage for these other S3-Co

Re: [PR] Fix TypeError in create_match_filter for Composite Keys with Single Unique Condition [iceberg-python]

2025-02-20 Thread via GitHub
omkenge commented on PR #1693: URL: https://github.com/apache/iceberg-python/pull/1693#issuecomment-2672649006 @corleyma @kevinjqliu I tried , but i am now confused !!! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and u

[PR] [1.7.x] Fix `{LICENSE,NOTICE}` for Azure Bundle [iceberg]

2025-02-20 Thread via GitHub
Fokko opened a new pull request, #12361: URL: https://github.com/apache/iceberg/pull/12361 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-ma

Re: [I] Issue trying to hit Nessie Catalog [iceberg-python]

2025-02-20 Thread via GitHub
adamcodes716 commented on issue #1680: URL: https://github.com/apache/iceberg-python/issues/1680#issuecomment-2672606005 > Pyiceberg's rest client supports any conforming Iceberg REST servers. Using `load_catalog` with Nessie's Iceberg REST endpoint should just work. `load_catalog` can tak

[PR] [1.7.x] Fix `{LICENSE,NOTICE}` for AWS Bundle [iceberg]

2025-02-20 Thread via GitHub
Fokko opened a new pull request, #12360: URL: https://github.com/apache/iceberg/pull/12360 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-ma

Re: [PR] Fix TypeError in create_match_filter for Composite Keys with Single Unique Condition [iceberg-python]

2025-02-20 Thread via GitHub
corleyma commented on PR #1693: URL: https://github.com/apache/iceberg-python/pull/1693#issuecomment-2672582906 @omkenge I think the ask is to add a test covering the case where there is a single condition. This test would have failed prior to your change, and should pass with your change.

[PR] [1.7.x] Fix `{LICENSE,NOTICE}` for GCP Bundle [iceberg]

2025-02-20 Thread via GitHub
Fokko opened a new pull request, #12359: URL: https://github.com/apache/iceberg/pull/12359 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-ma

Re: [PR] Fix #305: ManifestEntry partition field schema should be dynamically … [iceberg-go]

2025-02-20 Thread via GitHub
zeroshade commented on PR #307: URL: https://github.com/apache/iceberg-go/pull/307#issuecomment-2672549458 @arnaudbriche i'll take a look and see if I can condense and simplify this a bit for you, probably quicker than going back and forth like this -- This is an automated message from th

Re: [PR] fix(catalog/rest): Nessie CreateTable [iceberg-go]

2025-02-20 Thread via GitHub
zeroshade commented on PR #308: URL: https://github.com/apache/iceberg-go/pull/308#issuecomment-2672530845 @shubham-tomar you forgot to update the unit tests with the changed field names for RenameTable :smile: -- This is an automated message from the Apache Git Service. To respond to the

Re: [PR] AWS: Undeprecate `botocore_session` [iceberg-python]

2025-02-20 Thread via GitHub
Fokko merged PR #1692: URL: https://github.com/apache/iceberg-python/pull/1692 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceber

Re: [PR] API: Move variant to API and add extract expression [iceberg]

2025-02-20 Thread via GitHub
rdblue commented on code in PR #12304: URL: https://github.com/apache/iceberg/pull/12304#discussion_r1963985031 ## api/src/main/java/org/apache/iceberg/expressions/BoundExtract.java: ## @@ -0,0 +1,80 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or mo

Re: [PR] Deprecate for 0.9.0 release [iceberg-python]

2025-02-20 Thread via GitHub
sungwy commented on code in PR #1689: URL: https://github.com/apache/iceberg-python/pull/1689#discussion_r1963684910 ## pyiceberg/expressions/parser.py: ## @@ -90,13 +89,7 @@ @column.set_parse_action def _(result: ParseResults) -> Reference: if len(result.column) > 1: -

Re: [PR] AWS: Undeprecate `botocore_session` [iceberg-python]

2025-02-20 Thread via GitHub
Fokko commented on PR #1692: URL: https://github.com/apache/iceberg-python/pull/1692#issuecomment-2672487080 Thanks @kevinjqliu and @geruh for the quick review 🚀 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] Deprecate for 0.9.0 release [iceberg-python]

2025-02-20 Thread via GitHub
geruh commented on code in PR #1689: URL: https://github.com/apache/iceberg-python/pull/1689#discussion_r1964225296 ## pyiceberg/expressions/parser.py: ## @@ -90,13 +89,7 @@ @column.set_parse_action def _(result: ParseResults) -> Reference: if len(result.column) > 1: -

Re: [PR] API: Move variant to API and add extract expression [iceberg]

2025-02-20 Thread via GitHub
rdblue commented on code in PR #12304: URL: https://github.com/apache/iceberg/pull/12304#discussion_r1964228087 ## api/src/main/java/org/apache/iceberg/variants/Variant.java: ## @@ -25,4 +25,24 @@ public interface Variant { /** Returns the variant value. */ VariantValue

Re: [PR] API: Move variant to API and add extract expression [iceberg]

2025-02-20 Thread via GitHub
rdblue commented on code in PR #12304: URL: https://github.com/apache/iceberg/pull/12304#discussion_r1964226588 ## api/src/main/java/org/apache/iceberg/variants/VariantDataUtil.java: ## @@ -0,0 +1,46 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or mo

Re: [PR] Deprecate for 0.9.0 release [iceberg-python]

2025-02-20 Thread via GitHub
geruh commented on code in PR #1689: URL: https://github.com/apache/iceberg-python/pull/1689#discussion_r1964225296 ## pyiceberg/expressions/parser.py: ## @@ -90,13 +89,7 @@ @column.set_parse_action def _(result: ParseResults) -> Reference: if len(result.column) > 1: -

Re: [PR] REST: Remove deprecated `AUTH_URL` [iceberg-python]

2025-02-20 Thread via GitHub
Fokko commented on PR #1691: URL: https://github.com/apache/iceberg-python/pull/1691#issuecomment-2672487846 Thanks @kevinjqliu and @geruh for the quick review 🚀 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] REST: Remove deprecated `AUTH_URL` [iceberg-python]

2025-02-20 Thread via GitHub
Fokko merged PR #1691: URL: https://github.com/apache/iceberg-python/pull/1691 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceber

[PR] fix(table/scanner): Fix nested field scan [iceberg-go]

2025-02-20 Thread via GitHub
zeroshade opened a new pull request, #311: URL: https://github.com/apache/iceberg-go/pull/311 Fixes #309 Requires https://github.com/apache/arrow-go/pull/293 to get merged first There was a combination of factors that caused the initial problem: 1. The arrow-go/v18/parqu

Re: [PR] AWS: Integrate S3 analytics accelerator library [iceberg]

2025-02-20 Thread via GitHub
SanjayMarreddi commented on code in PR #12299: URL: https://github.com/apache/iceberg/pull/12299#discussion_r1964165208 ## aws/src/main/java/org/apache/iceberg/aws/s3/S3InputFile.java: ## @@ -82,6 +97,27 @@ public long getLength() { @Override public SeekableInputStream n

Re: [PR] Fix TypeError in create_match_filter for Composite Keys with Single Unique Condition [iceberg-python]

2025-02-20 Thread via GitHub
omkenge commented on PR #1693: URL: https://github.com/apache/iceberg-python/pull/1693#issuecomment-2672086663 Old Senario Problem: The Or() function expects two or more conditions (one on the left, one on the right). But here it is given only one condition. Result: This produces a Typ

Re: [PR] [1.7.x] Kafka: Pin Kafka-Connect version to fix integration tests [iceberg]

2025-02-20 Thread via GitHub
nastra merged PR #12354: URL: https://github.com/apache/iceberg/pull/12354 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.ap

Re: [I] Validation Error in ConfigResponse Model When connecting Nessie with PyIceberg using RestCatalog [iceberg-python]

2025-02-20 Thread via GitHub
adamcodes716 commented on issue #1524: URL: https://github.com/apache/iceberg-python/issues/1524#issuecomment-2672103100 > > > You can safely use your current Nessie applications, those that use type=nessie when using Iceberg, concurrently with applications using Nessie via Iceberg REST (t

Re: [PR] API: Move variant to API and add extract expression [iceberg]

2025-02-20 Thread via GitHub
rdblue commented on code in PR #12304: URL: https://github.com/apache/iceberg/pull/12304#discussion_r1963985031 ## api/src/main/java/org/apache/iceberg/expressions/BoundExtract.java: ## @@ -0,0 +1,80 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or mo

Re: [PR] API: Move variant to API and add extract expression [iceberg]

2025-02-20 Thread via GitHub
rdblue commented on code in PR #12304: URL: https://github.com/apache/iceberg/pull/12304#discussion_r1963978534 ## api/src/main/java/org/apache/iceberg/variants/Variant.java: ## @@ -25,4 +25,24 @@ public interface Variant { /** Returns the variant value. */ VariantValue

Re: [PR] feat(catalog): Add pagination for list table operation across different catalog types [iceberg-go]

2025-02-20 Thread via GitHub
zeroshade merged PR #306: URL: https://github.com/apache/iceberg-go/pull/306 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.

Re: [PR] API: Move variant to API and add extract expression [iceberg]

2025-02-20 Thread via GitHub
rdblue commented on code in PR #12304: URL: https://github.com/apache/iceberg/pull/12304#discussion_r1963955290 ## api/src/main/java/org/apache/iceberg/variants/VariantDataUtil.java: ## @@ -0,0 +1,46 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or mo

Re: [PR] API: Move variant to API and add extract expression [iceberg]

2025-02-20 Thread via GitHub
rdblue commented on code in PR #12304: URL: https://github.com/apache/iceberg/pull/12304#discussion_r1963955290 ## api/src/main/java/org/apache/iceberg/variants/VariantDataUtil.java: ## @@ -0,0 +1,46 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or mo

Re: [PR] API: Move variant to API and add extract expression [iceberg]

2025-02-20 Thread via GitHub
rdblue commented on code in PR #12304: URL: https://github.com/apache/iceberg/pull/12304#discussion_r1963953648 ## api/src/main/java/org/apache/iceberg/expressions/UnboundPredicate.java: ## @@ -124,13 +125,17 @@ public Expression bind(StructType struct, boolean caseSensitive) {

Re: [PR] [infra] nightly pypi build for `pyiceberg_core` [iceberg-rust]

2025-02-20 Thread via GitHub
kevinjqliu commented on PR #948: URL: https://github.com/apache/iceberg-rust/pull/948#issuecomment-2672033363 Added trusted published to testpypi's `pyiceberg-core` (Thanks sung) ![Screenshot 2025-02-20 at 8 33 11  AM](https://github.com/user-attachments/assets/ebfbb09e-2e86-47a9-9dc3-

Re: [PR] Core: Interface changes for separating rewrite planner and runner [iceberg]

2025-02-20 Thread via GitHub
RussellSpitzer commented on code in PR #12306: URL: https://github.com/apache/iceberg/pull/12306#discussion_r1963939995 ## core/src/main/java/org/apache/iceberg/actions/RewriteGroupBase.java: ## @@ -0,0 +1,104 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

Re: [PR] Core: Interface changes for separating rewrite planner and runner [iceberg]

2025-02-20 Thread via GitHub
RussellSpitzer commented on code in PR #12306: URL: https://github.com/apache/iceberg/pull/12306#discussion_r1963950250 ## core/src/main/java/org/apache/iceberg/actions/RewriteGroupBase.java: ## @@ -0,0 +1,104 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

  1   2   >