nika-qubit commented on code in PR #12362:
URL: https://github.com/apache/iceberg/pull/12362#discussion_r1964501692


##########
core/src/test/java/org/apache/iceberg/rest/TestRESTCatalog.java:
##########
@@ -1390,6 +1391,108 @@ public void testCatalogTokenRefresh(String 
oauth2ServerUri) {
             });
   }
 
+  @ParameterizedTest
+  @ValueSource(strings = {"v1/oauth/tokens", "https://auth-server.com/token"})
+  public void testCatalogTokenRefreshByRefreshTokenFlow(String 
oauth2ServerUri) {
+    Map<String, String> emptyHeaders = ImmutableMap.of();
+    // Catalog headers are used to send requests to the Catalog REST endpoint.
+    Map<String, String> catalogHeaders =
+        ImmutableMap.of("Authorization", "Bearer 
client-credentials-token:sub=catalog");
+    // Basic headers are used to send requests to the oauth2 server enepoint.

Review Comment:
   Had a typo here, will fix it with other changes based on comments.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org

Reply via email to