geruh commented on code in PR #1689:
URL: https://github.com/apache/iceberg-python/pull/1689#discussion_r1964388377
##########
pyiceberg/expressions/parser.py:
##########
@@ -90,13 +89,7 @@
@column.set_parse_action
def _(result: ParseResults) -> Reference:
if len(result.column) > 1:
- deprecation_message(
- deprecated_in="0.8.0",
- removed_in="0.9.0",
- help_message="Parsing expressions with table name is deprecated.
Only provide field names in the row_filter.",
- )
- # TODO: Once this is removed, we will no longer take just the last index
of parsed column result
- # And introduce support for parsing filter expressions with nested fields.
+ raise ValueError(f"Cannot parse expressions with table names or nested
fields, got: {".".join(result.column)}")
return Reference(result.column[-1])
Review Comment:
Alright, I made the changes to include the joining logic for the column
references. As long as there's parity between a bound schema and the
expression, I don’t see any issues.
One thing I noticed is that if we have a nested field with a dot, like
`foo.bar,` and a field nested inside it as `baz`, it's treated as
`foo.bar.baz`, and the expression respects that.
Additionally, it's worth noting that the parser currently doesn’t allow a
quoted identifier to represent a single field containing a dot, such as
`"foo.bar".baz`. Due to the expectations set here:
https://github.com/apache/iceberg-python/blob/main/pyiceberg/expressions/parser.py#L82
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
