rdblue commented on code in PR #12323:
URL: https://github.com/apache/iceberg/pull/12323#discussion_r1964506375


##########
core/src/main/java/org/apache/iceberg/variants/Variants.java:
##########
@@ -85,6 +85,16 @@ public static ShreddedObject object(VariantMetadata 
metadata) {
     return new ShreddedObject(metadata);
   }
 
+  public static ShreddedObject object(VariantObject object) {

Review Comment:
   Used to create a shredded object from an existing object when writing. It 
uses the object's metadata.
   
   This avoids exposing `VariantObject.metadata` because metadata is carried by 
`Variant` instead of values.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org

Reply via email to