rdblue commented on code in PR #12323:
URL: https://github.com/apache/iceberg/pull/12323#discussion_r1964509422
##########
parquet/src/main/java/org/apache/iceberg/parquet/ParquetValueWriters.java:
##########
@@ -71,6 +71,10 @@ public static UnboxedWriter<Short> shorts(ColumnDescriptor
desc) {
return new ShortWriter(desc);
}
+ public static <T> ParquetValueWriter<T> unboxed(ColumnDescriptor desc) {
Review Comment:
Needed to expose this to get `float` and `double` working. Those writers
currently require a metrics builder that expects a non-null field ID.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
