rdblue commented on code in PR #12323:
URL: https://github.com/apache/iceberg/pull/12323#discussion_r1964507242
##########
parquet/src/main/java/org/apache/iceberg/data/parquet/BaseParquetWriter.java:
##########
@@ -62,7 +71,7 @@ protected ParquetValueWriter<?>
timestampWriter(ColumnDescriptor desc, boolean i
}
}
- private class WriteBuilder extends ParquetTypeVisitor<ParquetValueWriter<?>>
{
+ private class WriteBuilder extends
TypeWithSchemaVisitor<ParquetValueWriter<?>> {
Review Comment:
In order to detect a variant type, this needs to use the original Iceberg
schema. When Parquet exposes the `VARIANT` logical type annotation, we can
update this to no longer require the schema.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
