rdblue commented on code in PR #12323:
URL: https://github.com/apache/iceberg/pull/12323#discussion_r1964508977
##########
parquet/src/main/java/org/apache/iceberg/parquet/Parquet.java:
##########
@@ -160,9 +161,10 @@ public static class WriteBuilder implements
InternalData.WriteBuilder {
private final Map<String, String> metadata = Maps.newLinkedHashMap();
private final Map<String, String> config = Maps.newLinkedHashMap();
private Schema schema = null;
+ private BiFunction<Integer, String, Type> variantShreddingFunc = null;
private String name = "table";
private WriteSupport<?> writeSupport = null;
- private Function<MessageType, ParquetValueWriter<?>> createWriterFunc =
null;
+ private BiFunction<Schema, MessageType, ParquetValueWriter<?>>
createWriterFunc = null;
Review Comment:
This change is supports passing the schema to the write builder function.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
