[Engine-patches] Change in ovirt-engine[master]: packaging: log rotate

2013-06-18 Thread bazulay
Barak Azulay has posted comments on this change. Change subject: packaging: log rotate .. Patch Set 5: Verified; Looks good to me, approved Verified by: Alon Reviewed by: Allon, Sandro, Yedidyah -- To view, visit http://gerri

[Engine-patches] Change in ovirt-engine[master]: packaging: log rotate

2013-06-18 Thread bazulay
Barak Azulay has submitted this change and it was merged. Change subject: packaging: log rotate .. packaging: log rotate use standard logrotate instead of own implementation, disable jboss rotation in favor of logrotate. Bug-U

[Engine-patches] Change in ovirt-engine[master]: packaging: log rotate

2013-06-18 Thread bazulay
Barak Azulay has posted comments on this change. Change subject: packaging: log rotate .. Patch Set 4: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14961 To unsubscribe, visit http://gerrit.ovirt.org/se

[Engine-patches] Change in ovirt-engine[master]: packaging: log rotate

2013-06-17 Thread amureini
Allon Mureinik has posted comments on this change. Change subject: packaging: log rotate .. Patch Set 4: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/14961 To unsubscribe, visit htt

[Engine-patches] Change in ovirt-engine[master]: packaging: log rotate

2013-06-17 Thread sbonazzo
Sandro Bonazzola has posted comments on this change. Change subject: packaging: log rotate .. Patch Set 4: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/14961 To unsubscribe, visit h

[Engine-patches] Change in ovirt-engine[master]: packaging: log rotate

2013-06-16 Thread didi
Yedidyah Bar David has posted comments on this change. Change subject: packaging: log rotate .. Patch Set 4: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/14961 To unsubscribe, visit

[Engine-patches] Change in ovirt-engine[master]: packaging: log rotate

2013-06-16 Thread Alon Bar-Lev
Alon Bar-Lev has posted comments on this change. Change subject: packaging: log rotate .. Patch Set 4: Verified the only comment I got was to leave lograte interval configuration as-is, I agree to this and no objection, so we

[Engine-patches] Change in ovirt-engine[master]: packaging: log rotate

2013-06-13 Thread Alon Bar-Lev
Alon Bar-Lev has posted comments on this change. Change subject: packaging: log rotate .. Patch Set 3: > any new insights? See bug... I am waiting a bit more if someone has different view. -- To view, visit http://gerrit.ovi

[Engine-patches] Change in ovirt-engine[master]: packaging: log rotate

2013-06-13 Thread amureini
Allon Mureinik has posted comments on this change. Change subject: packaging: log rotate .. Patch Set 3: any new insights? -- To view, visit http://gerrit.ovirt.org/14961 To unsubscribe, visit http://gerrit.ovirt.org/settings

[Engine-patches] Change in ovirt-engine[master]: packaging: log rotate

2013-05-30 Thread Alon Bar-Lev
Alon Bar-Lev has posted comments on this change. Change subject: packaging: log rotate .. Patch Set 3: > This patch collected four +1 reviews... Can one of the packaging maintainers > take a look and ack it if it's indeed OK.

[Engine-patches] Change in ovirt-engine[master]: packaging: log rotate

2013-05-30 Thread amureini
Allon Mureinik has posted comments on this change. Change subject: packaging: log rotate .. Patch Set 3: This patch collected four +1 reviews... Can one of the packaging maintainers take a look and ack it if it's indeed OK. --

[Engine-patches] Change in ovirt-engine[master]: packaging: log rotate

2013-05-29 Thread yzaslavs
Yair Zaslavsky has posted comments on this change. Change subject: packaging: log rotate .. Patch Set 3: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/14961 To unsubscribe, visit http

[Engine-patches] Change in ovirt-engine[master]: packaging: log rotate

2013-05-22 Thread amureini
Allon Mureinik has posted comments on this change. Change subject: packaging: log rotate .. Patch Set 3: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/14961 To unsubscribe, visit http

[Engine-patches] Change in ovirt-engine[master]: packaging: log rotate

2013-05-22 Thread didi
Yedidyah Bar David has posted comments on this change. Change subject: packaging: log rotate .. Patch Set 3: logrotate does not support an hourly run. If an admin wants to, they can configure it to run in cron.hourly with mins

[Engine-patches] Change in ovirt-engine[master]: packaging: log rotate

2013-05-22 Thread oschreib
Ofer Schreiber has posted comments on this change. Change subject: packaging: log rotate .. Patch Set 3: Hourly, I ment. -- To view, visit http://gerrit.ovirt.org/14961 To unsubscribe, visit http://gerrit.ovirt.org/settings G

[Engine-patches] Change in ovirt-engine[master]: packaging: log rotate

2013-05-22 Thread oschreib
Ofer Schreiber has posted comments on this change. Change subject: packaging: log rotate .. Patch Set 3: Few notes: 1. I'm a big fan of using logrotate.d instead of the current implementation (log4j). 2. IMO (and that's why I'

[Engine-patches] Change in ovirt-engine[master]: packaging: log rotate

2013-05-22 Thread sbonazzo
Sandro Bonazzola has posted comments on this change. Change subject: packaging: log rotate .. Patch Set 3: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/14961 To unsubscribe, visit ht

[Engine-patches] Change in ovirt-engine[master]: packaging: log rotate

2013-05-22 Thread didi
Yedidyah Bar David has posted comments on this change. Change subject: packaging: log rotate .. Patch Set 3: Verified; Looks good to me, but someone else must approve (1 inline comment)

[Engine-patches] Change in ovirt-engine[master]: packaging: log rotate

2013-05-22 Thread Alon Bar-Lev
Alon Bar-Lev has posted comments on this change. Change subject: packaging: log rotate .. Patch Set 3: Verified (1 inline comment) File packaging/etc/logrotate.d/ovirt-engin

[Engine-patches] Change in ovirt-engine[master]: packaging: log rotate

2013-05-22 Thread didi
Yedidyah Bar David has posted comments on this change. Change subject: packaging: log rotate .. Patch Set 3: (1 inline comment) File packaging/etc/logrotate.d/ovirt-engine.in

[Engine-patches] Change in ovirt-engine[master]: packaging: log rotate

2013-05-22 Thread Alon Bar-Lev
Alon Bar-Lev has posted comments on this change. Change subject: packaging: log rotate .. Patch Set 3: (1 inline comment) File packaging/etc/logrotate.d/ovirt-engine.in Line

[Engine-patches] Change in ovirt-engine[master]: packaging: log rotate

2013-05-22 Thread Alon Bar-Lev
Alon Bar-Lev has posted comments on this change. Change subject: packaging: log rotate .. Patch Set 2: (1 inline comment) File packaging/etc/logrotate.d/ovirt-engine.in Line

[Engine-patches] Change in ovirt-engine[master]: packaging: log rotate

2013-05-22 Thread didi
Yedidyah Bar David has posted comments on this change. Change subject: packaging: log rotate .. Patch Set 2: (2 inline comments) File packaging/etc/logrotate.d/ovirt-engine.i

[Engine-patches] Change in ovirt-engine[master]: packaging: log rotate

2013-05-22 Thread Alon Bar-Lev
Alon Bar-Lev has posted comments on this change. Change subject: packaging: log rotate .. Patch Set 2: (1 inline comment) File packaging/etc/logrotate.d/ovirt-engine.in Line

[Engine-patches] Change in ovirt-engine[master]: packaging: log rotate

2013-05-22 Thread didi
Yedidyah Bar David has posted comments on this change. Change subject: packaging: log rotate .. Patch Set 2: (1 inline comment) File packaging/etc/logrotate.d/ovirt-engine.in

[Engine-patches] Change in ovirt-engine[master]: packaging: log rotate

2013-05-22 Thread Alon Bar-Lev
Alon Bar-Lev has posted comments on this change. Change subject: packaging: log rotate .. Patch Set 2: (2 inline comments) File packaging/etc/logrotate.d/ovirt-engine.in Line

[Engine-patches] Change in ovirt-engine[master]: packaging: log rotate

2013-05-22 Thread didi
Yedidyah Bar David has posted comments on this change. Change subject: packaging: log rotate .. Patch Set 2: (2 inline comments) File packaging/etc/logrotate.d/ovirt-engine.i

[Engine-patches] Change in ovirt-engine[master]: packaging: log rotate

2013-05-22 Thread Alon Bar-Lev
Alon Bar-Lev has posted comments on this change. Change subject: packaging: log rotate .. Patch Set 2: Change to daily per didi suggestion. -- To view, visit http://gerrit.ovirt.org/14961 To unsubscribe, visit http://gerrit.ov

[Engine-patches] Change in ovirt-engine[master]: packaging: log rotate

2013-05-22 Thread Alon Bar-Lev
Alon Bar-Lev has posted comments on this change. Change subject: packaging: log rotate .. Patch Set 1: Any other suggestion about maximum size of our logs? -- To view, visit http://gerrit.ovirt.org/14961 To unsubscribe, visit

[Engine-patches] Change in ovirt-engine[master]: packaging: log rotate

2013-05-22 Thread Alon Bar-Lev
Alon Bar-Lev has posted comments on this change. Change subject: packaging: log rotate .. Patch Set 1: (2 inline comments) File packaging/etc/logrotate.d/ovirt-engine.in Line

[Engine-patches] Change in ovirt-engine[master]: packaging: log rotate

2013-05-21 Thread didi
Yedidyah Bar David has posted comments on this change. Change subject: packaging: log rotate .. Patch Set 1: (2 inline comments) File packaging/etc/logrotate.d/ovirt-engine.i

[Engine-patches] Change in ovirt-engine[master]: packaging: log rotate

2013-05-21 Thread Alon Bar-Lev
Alon Bar-Lev has posted comments on this change. Change subject: packaging: log rotate .. Patch Set 1: (4 inline comments) > I recommend to change it from daily to something more frequent for cases of > heavy activity. log4j c

[Engine-patches] Change in ovirt-engine[master]: packaging: log rotate

2013-05-21 Thread rgolan
Roy Golan has posted comments on this change. Change subject: packaging: log rotate .. Patch Set 1: I recommend to change it from daily to something more frequent for cases of heavy activity. log4j covers that because its moni

[Engine-patches] Change in ovirt-engine[master]: packaging: log rotate

2013-05-21 Thread didi
Yedidyah Bar David has posted comments on this change. Change subject: packaging: log rotate .. Patch Set 1: (5 inline comments) File packaging/etc/logrotate.d/ovirt-engine.i

[Engine-patches] Change in ovirt-engine[master]: packaging: log rotate

2013-05-21 Thread sbonazzo
Sandro Bonazzola has posted comments on this change. Change subject: packaging: log rotate .. Patch Set 1: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/14961 To unsubscribe, visit ht

[Engine-patches] Change in ovirt-engine[master]: packaging: log rotate

2013-05-21 Thread Alon Bar-Lev
Alon Bar-Lev has posted comments on this change. Change subject: packaging: log rotate .. Patch Set 1: (3 inline comments) File packaging/etc/logrotate.d/ovirt-engine.in Line

[Engine-patches] Change in ovirt-engine[master]: packaging: log rotate

2013-05-21 Thread didi
Yedidyah Bar David has posted comments on this change. Change subject: packaging: log rotate .. Patch Set 1: (3 inline comments) File packaging/etc/logrotate.d/ovirt-engine.i

[Engine-patches] Change in ovirt-engine[master]: packaging: log rotate

2013-05-21 Thread Alon Bar-Lev
Alon Bar-Lev has posted comments on this change. Change subject: packaging: log rotate .. Patch Set 1: Verified -- To view, visit http://gerrit.ovirt.org/14961 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-Mess

[Engine-patches] Change in ovirt-engine[master]: packaging: log rotate

2013-05-21 Thread Alon Bar-Lev
Alon Bar-Lev has uploaded a new change for review. Change subject: packaging: log rotate .. packaging: log rotate use standard logrotate instead of own implementation, disable jboss rotation in favor of logrotate. Bug-Url: http