Alon Bar-Lev has posted comments on this change.
Change subject: packaging: log rotate
......................................................................
Patch Set 1: (3 inline comments)
....................................................
File packaging/etc/logrotate.d/ovirt-engine.in
Line 1: "@ENGINE_LOG@/engine.log" "@ENGINE_LOG@/server.log" {
In principal I agree.
We had this discussion before, there is a tension between the ability to trust
admin's/system defaults and the need to support the product.
If there is an issue in product, we need valid logs, and much of them in our
case.
Leaving the amount to system defaults can result in not having the information
when required. In practice, most of the admins that are installing this product
are not experienced one. So we set the default of what we can support.
Line 2: minsize 10M
Line 3: size 100M
Line 4: missingok
Line 5: copytruncate
Line 1: "@ENGINE_LOG@/engine.log" "@ENGINE_LOG@/server.log" {
Line 2: minsize 10M
Line 3: size 100M
Line 4: missingok
Line 5: copytruncate
it is java...
Line 6: rotate 5
Line 7: compress
Line 8: }
Line 9:
Line 12: missingok
Line 13: rotate 2
Line 14: compress
Line 15: postrotate
Line 16: rm -f "$1"
because these logs or onetime logs of deployment... I want to keep the for a
duration then delete. I found no better way to do that.... opened to ideas.
Line 17: endscript
--
To view, visit http://gerrit.ovirt.org/14961
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I3570ae0e07a6884dcfc47bc49795f2ad17ab6c43
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <alo...@redhat.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com>
Gerrit-Reviewer: Barak Azulay <bazu...@redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com>
Gerrit-Reviewer: Roy Golan <rgo...@redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <d...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
