Yedidyah Bar David has posted comments on this change.
Change subject: packaging: log rotate
......................................................................
Patch Set 1: (5 inline comments)
....................................................
File packaging/etc/logrotate.d/ovirt-engine.in
Line 1: "@ENGINE_LOG@/engine.log" "@ENGINE_LOG@/server.log" {
OK. Details below.
Just mentioning the obvious: The default is to keep 4 weeks of logs.
Line 2: minsize 10M
Line 3: size 100M
Line 4: missingok
Line 5: copytruncate
Line 1: "@ENGINE_LOG@/engine.log" "@ENGINE_LOG@/server.log" {
Line 2: minsize 10M
Line 3: size 100M
Why?
I almost never found the size/minsize options useful.
On a very busy server this might (?) make you keep less, perhaps much less than
4 weeks. logrotate runs daily, so you might keep only 5 days, 100MB each.
Line 4: missingok
Line 5: copytruncate
Line 6: rotate 5
Line 7: compress
Line 1: "@ENGINE_LOG@/engine.log" "@ENGINE_LOG@/server.log" {
Line 2: minsize 10M
Line 3: size 100M
Line 4: missingok
Is that actually reasonable that it will not exist? If not, you might remove
'missingok' and so make the cron alert, for free.
Line 5: copytruncate
Line 6: rotate 5
Line 7: compress
Line 8: }
Line 1: "@ENGINE_LOG@/engine.log" "@ENGINE_LOG@/server.log" {
Line 2: minsize 10M
Line 3: size 100M
Line 4: missingok
Line 5: copytruncate
Isn't it possible/reasonable to restart it, or somehow tell it to close and
open the log?
Line 6: rotate 5
Line 7: compress
Line 8: }
Line 9:
Line 12: missingok
Line 13: rotate 2
Line 14: compress
Line 15: postrotate
Line 16: rm -f "$1"
IIRC the default will keep it for 4 weeks. Isn't that enough?
Also, I do not see any specific reason to delete it, if for some reason it's
not deleted. It will waste a small storage space and will have the potential to
ease debugging issues also in later times.
Line 17: endscript
--
To view, visit http://gerrit.ovirt.org/14961
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I3570ae0e07a6884dcfc47bc49795f2ad17ab6c43
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <alo...@redhat.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com>
Gerrit-Reviewer: Barak Azulay <bazu...@redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com>
Gerrit-Reviewer: Roy Golan <rgo...@redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <d...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
