Ofer Schreiber has posted comments on this change. Change subject: packaging: log rotate ......................................................................
Patch Set 3: Few notes: 1. I'm a big fan of using logrotate.d instead of the current implementation (log4j). 2. IMO (and that's why I'm not giving +2 in this case), daily log rotate is not enough. our system logs so much data, that I'm afraid from the case we will blow customers disk. Do we have any good reason for NOT doing it daily? -- To view, visit http://gerrit.ovirt.org/14961 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3570ae0e07a6884dcfc47bc49795f2ad17ab6c43 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Barak Azulay <bazu...@redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschr...@redhat.com> Gerrit-Reviewer: Roy Golan <rgo...@redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: Yedidyah Bar David <d...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
