Yedidyah Bar David has posted comments on this change. Change subject: packaging: log rotate ......................................................................
Patch Set 2: (1 inline comment) .................................................... File packaging/etc/logrotate.d/ovirt-engine.in Line 6: rotate 480 Line 7: compress Line 8: } Line 9: Line 10: "@ENGINE_LOG@/host-deploy"/*.log { Why not simply compress in the end of the deployment? I understand there is one such file exactly per deployment, no? Better to also add its name to the file name, if possible. A few hundred files, compressed to 20KiB or so each (now checked), is a few MB. Line 11: monthly Line 12: missingok Line 13: rotate 2 Line 14: compress -- To view, visit http://gerrit.ovirt.org/14961 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3570ae0e07a6884dcfc47bc49795f2ad17ab6c43 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Barak Azulay <bazu...@redhat.com> Gerrit-Reviewer: Roy Golan <rgo...@redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: Yedidyah Bar David <d...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches