Alon Bar-Lev has posted comments on this change.
Change subject: packaging: log rotate
......................................................................
Patch Set 1: (4 inline comments)
> I recommend to change it from daily to something more frequent for cases of
> heavy activity. log4j covers that because its monitoring the log size while
> logrotate have to run manually to discover it.
I think daily is enough for 90% of the cases. In these which is not, the admin
can run logrotate via cron in any frequency he likes... I don't think that
doing that in default installation is good.
....................................................
File packaging/etc/logrotate.d/ovirt-engine.in
Line 1: "@ENGINE_LOG@/engine.log" "@ENGINE_LOG@/server.log" {
Line 2: minsize 10M
Line 3: size 100M
right. we produce too much logs, I do not want to be time constrained but size.
Line 4: missingok
Line 5: copytruncate
Line 6: rotate 5
Line 7: compress
Line 1: "@ENGINE_LOG@/engine.log" "@ENGINE_LOG@/server.log" {
Line 2: minsize 10M
Line 3: size 100M
Line 4: missingok
we install software but not start/setup daemon - no logs.
admin stop daemon, remove logs...
the alert should be on daemon up/down not the existence of logs... unless logs
are vital, such as audit...
Line 5: copytruncate
Line 6: rotate 5
Line 7: compress
Line 8: }
Line 1: "@ENGINE_LOG@/engine.log" "@ENGINE_LOG@/server.log" {
Line 2: minsize 10M
Line 3: size 100M
Line 4: missingok
Line 5: copytruncate
nope. well, not that I know.
Line 6: rotate 5
Line 7: compress
Line 8: }
Line 9:
Line 12: missingok
Line 13: rotate 2
Line 14: compress
Line 15: postrotate
Line 16: rm -f "$1"
it always remains a log with size 0 at original file name... this is what I am
removing.
Line 17: endscript
--
To view, visit http://gerrit.ovirt.org/14961
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I3570ae0e07a6884dcfc47bc49795f2ad17ab6c43
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <alo...@redhat.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com>
Gerrit-Reviewer: Barak Azulay <bazu...@redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com>
Gerrit-Reviewer: Roy Golan <rgo...@redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <d...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
