Alon Bar-Lev has posted comments on this change.

Change subject: packaging: log rotate
......................................................................


Patch Set 1: (2 inline comments)

....................................................
File packaging/etc/logrotate.d/ovirt-engine.in
Line 1: "@ENGINE_LOG@/engine.log" "@ENGINE_LOG@/server.log" {
Line 2:         minsize 10M
Line 3:         size 100M
it is not 5 days... it is 5*100M = 0.5G which I think is more than enough for 
logs. Every number I put here is a balance between having logs and not cause 
filesystem to be full... if you think 0.5G is too low, I can increase it...
Line 4:         missingok
Line 5:         copytruncate
Line 6:         rotate 5
Line 7:         compress


Line 12:        missingok
Line 13:        rotate 2
Line 14:        compress
Line 15:        postrotate
Line 16:                rm -f "$1"
/root/install.log - is it our log?

The problem in these logs are that every host that is installed/reinstalled 
opens a new logs... I fear that at some point there will be too many of these...
Line 17:        endscript


--
To view, visit http://gerrit.ovirt.org/14961
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3570ae0e07a6884dcfc47bc49795f2ad17ab6c43
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <alo...@redhat.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com>
Gerrit-Reviewer: Barak Azulay <bazu...@redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com>
Gerrit-Reviewer: Roy Golan <rgo...@redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <d...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to