Yedidyah Bar David has posted comments on this change.
Change subject: packaging: log rotate
......................................................................
Patch Set 1: (3 inline comments)
....................................................
File packaging/etc/logrotate.d/ovirt-engine.in
Line 1: "@ENGINE_LOG@/engine.log" "@ENGINE_LOG@/server.log" {
I personally think that /etc/logrotate.d/* files should be as minimal as
possible, to allow the admin easy control from /etc/logrotate.conf without
going over all those in logrotate.d. In these specific files, I think I'd
remove everything but the names, leaving the {} empty.
Line 2: minsize 10M
Line 3: size 100M
Line 4: missingok
Line 5: copytruncate
Line 1: "@ENGINE_LOG@/engine.log" "@ENGINE_LOG@/server.log" {
Line 2: minsize 10M
Line 3: size 100M
Line 4: missingok
Line 5: copytruncate
Why copytruncate?
Line 6: rotate 5
Line 7: compress
Line 8: }
Line 9:
Line 12: missingok
Line 13: rotate 2
Line 14: compress
Line 15: postrotate
Line 16: rm -f "$1"
Why rm?
Line 17: endscript
--
To view, visit http://gerrit.ovirt.org/14961
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I3570ae0e07a6884dcfc47bc49795f2ad17ab6c43
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <alo...@redhat.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com>
Gerrit-Reviewer: Barak Azulay <bazu...@redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com>
Gerrit-Reviewer: Roy Golan <rgo...@redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <d...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
