[Engine-patches] Change in ovirt-engine[master]: core: fix findbugs

2015-06-11 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: core: fix findbugs .. Patch Set 1: * Update tracker::IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url found. -- To view, visit https://gerrit

[Engine-patches] Change in ovirt-engine[master]: core: fix findbugs

2015-06-11 Thread tjelinek
Tomas Jelinek has submitted this change and it was merged. Change subject: core: fix findbugs .. core: fix findbugs Fix RCN_REDUNDANT_NULLCHECK_WOULD_HAVE_BEEN_A_NPE Change-Id: Ie614377ee4715cc4cd9a5bd6ec7eba4a20aa8a0e Signed-

[Engine-patches] Change in ovirt-engine[master]: core: fix findbugs

2015-06-11 Thread tjelinek
Tomas Jelinek has posted comments on this change. Change subject: core: fix findbugs .. Patch Set 1: Verified+1 Code-Review+2 I think the patch is trivial enough and breaks the build, merging -- To view, visit https://gerrit.

[Engine-patches] Change in ovirt-engine[master]: core: fix findbugs

2015-06-11 Thread tjelinek
Tomas Jelinek has posted comments on this change. Change subject: core: fix findbugs .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/42257 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerri

[Engine-patches] Change in ovirt-engine[master]: core: fix findbugs

2015-06-11 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: core: fix findbugs .. Patch Set 1: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url:

[Engine-patches] Change in ovirt-engine[master]: core: fix findbugs

2015-06-11 Thread ahadas
Arik Hadas has posted comments on this change. Change subject: core: fix findbugs .. Patch Set 1: Verified+1 -- To view, visit https://gerrit.ovirt.org/42257 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-Mess

[Engine-patches] Change in ovirt-engine[master]: core: fix findbugs

2015-06-11 Thread ahadas
Arik Hadas has uploaded a new change for review. Change subject: core: fix findbugs .. core: fix findbugs Fix RCN_REDUNDANT_NULLCHECK_WOULD_HAVE_BEEN_A_NPE Change-Id: Ie614377ee4715cc4cd9a5bd6ec7eba4a20aa8a0e Signed-off-by: Ari

[Engine-patches] Change in ovirt-engine[master]: core: fix findbugs warning

2014-03-08 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: core: fix findbugs warning .. Patch Set 4: Build Failed http://jenkins.ovirt.org/job/ovirt_engine_master_compile_checkstyle_gerrit/19674/ : SUCCESS

[Engine-patches] Change in ovirt-engine[master]: core: fix findbugs warning

2014-03-08 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: core: fix findbugs warning .. Patch Set 4: * Update tracker: IGNORE, no Bug-Url found * Set MODIFIED: IGNORE, no Bug-Url found. -- To view, visit http:/

[Engine-patches] Change in ovirt-engine[master]: core: fix findbugs warning

2014-03-08 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: core: fix findbugs warning .. Patch Set 4: * Update tracker: IGNORE, no Bug-Url found * Bug-Url: IGNORE, not in a monitored branch (ovirt-engine-3.4 * Che

[Engine-patches] Change in ovirt-engine[master]: core: fix findbugs warning

2014-03-08 Thread mlipchuk
Maor Lipchuk has submitted this change and it was merged. Change subject: core: fix findbugs warning .. core: fix findbugs warning Remove unused snapshot parameter and method Change-Id: Ic67cf42c652972a34580d613bbf0da5ed204c7f

[Engine-patches] Change in ovirt-engine[master]: core: fix findbugs warnning

2014-03-08 Thread derez
Daniel Erez has posted comments on this change. Change subject: core: fix findbugs warnning .. Patch Set 3: Code-Review+2 (1 comment) http://gerrit.ovirt.org/#/c/25525/3//COMMIT_MSG Commit Message: Line 3: AuthorDate: 2014-03

[Engine-patches] Change in ovirt-engine[master]: core: fix findbugs warnning

2014-03-08 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: core: fix findbugs warnning .. Patch Set 3: Build Failed http://jenkins.ovirt.org/job/ovirt_engine_master_compile_checkstyle_gerrit/19673/ : SUCCESS

[Engine-patches] Change in ovirt-engine[master]: core: fix findbugs warnning

2014-03-08 Thread mlipchuk
Maor Lipchuk has posted comments on this change. Change subject: core: fix findbugs warnning .. Patch Set 3: Verified+1 -- To view, visit http://gerrit.ovirt.org/25525 To unsubscribe, visit http://gerrit.ovirt.org/settings Ge

[Engine-patches] Change in ovirt-engine[master]: core: fix findbugs warnning

2014-03-08 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: core: fix findbugs warnning .. Patch Set 3: * Update tracker: IGNORE, no Bug-Url found * Bug-Url: IGNORE, not in a monitored branch (ovirt-engine-3.4 * Ch

[Engine-patches] Change in ovirt-engine[master]: core: fix findbugs warnning

2014-03-08 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: core: fix findbugs warnning .. Patch Set 2: Build Failed http://jenkins.ovirt.org/job/ovirt_engine_master_compile_checkstyle_gerrit/19672/ : SUCCESS

[Engine-patches] Change in ovirt-engine[master]: core: fix findbugs warnning

2014-03-08 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: core: fix findbugs warnning .. Patch Set 2: * Update tracker: IGNORE, no Bug-Url found * Bug-Url: IGNORE, not in a monitored branch (ovirt-engine-3.4 * Ch

[Engine-patches] Change in ovirt-engine[master]: core: fix findbugs warnning

2014-03-08 Thread derez
Daniel Erez has posted comments on this change. Change subject: core: fix findbugs warnning .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/25525 To unsubscribe, visit http://gerrit.ovirt.org/settings

[Engine-patches] Change in ovirt-engine[master]: core: fix findbugs warnning

2014-03-08 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: core: fix findbugs warnning .. Patch Set 1: Build Failed http://jenkins.ovirt.org/job/ovirt_engine_master_compile_checkstyle_gerrit/19671/ : SUCCESS

[Engine-patches] Change in ovirt-engine[master]: core: fix findbugs warnning

2014-03-08 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: core: fix findbugs warnning .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Bug-Url: IGNORE, not in a monitored branch (ovirt-engine-3.4 * Ch

[Engine-patches] Change in ovirt-engine[master]: core: fix findbugs warnning

2014-03-08 Thread mlipchuk
Maor Lipchuk has uploaded a new change for review. Change subject: core: fix findbugs warnning .. core: fix findbugs warnning Remove unused snapshot parameter Change-Id: Ic67cf42c652972a34580d613bbf0da5ed204c7f3 Signed-off-by:

[Engine-patches] Change in ovirt-engine[master]: core: Fix FindBugs issue in EventNotificationMethod

2014-03-05 Thread yzaslavs
Yair Zaslavsky has submitted this change and it was merged. Change subject: core: Fix FindBugs issue in EventNotificationMethod .. core: Fix FindBugs issue in EventNotificationMethod Fixes FindBugs issue in EventNotificationMet

[Engine-patches] Change in ovirt-engine[master]: core: Fix FindBugs issue in EventNotificationMethod

2014-03-05 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: core: Fix FindBugs issue in EventNotificationMethod .. Patch Set 3: * Update tracker: IGNORE, no Bug-Url found * Set MODIFIED: IGNORE, no Bug-Url found.

[Engine-patches] Change in ovirt-engine[master]: core: Fix FindBugs issue in EventNotificationMethod

2014-03-05 Thread yzaslavs
Yair Zaslavsky has posted comments on this change. Change subject: core: Fix FindBugs issue in EventNotificationMethod .. Patch Set 2: Verified+1 Code-Review+2 -- To view, visit http://gerrit.ovirt.org/25309 To unsubscribe, vi

[Engine-patches] Change in ovirt-engine[master]: core: Fix FindBugs issue in EventNotificationMethod

2014-03-05 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: core: Fix FindBugs issue in EventNotificationMethod .. Patch Set 2: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_master_compile_checkst

[Engine-patches] Change in ovirt-engine[master]: core: Fix FindBugs issue in EventNotificationMethod

2014-03-05 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: core: Fix FindBugs issue in EventNotificationMethod .. Patch Set 2: Build Failed http://jenkins.ovirt.org/job/ovirt_engine_master_compile_checkstyle_

[Engine-patches] Change in ovirt-engine[master]: core: Fix FindBugs issue in EventNotificationMethod

2014-03-05 Thread mperina
Martin Peřina has posted comments on this change. Change subject: core: Fix FindBugs issue in EventNotificationMethod .. Patch Set 2: Verified+1 -- To view, visit http://gerrit.ovirt.org/25309 To unsubscribe, visit http://gerr

[Engine-patches] Change in ovirt-engine[master]: core: Fix FindBugs issue in EventNotificationMethod

2014-03-05 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: core: Fix FindBugs issue in EventNotificationMethod .. Patch Set 2: * Bug-Url: IGNORE, not in a monitored branch (ovirt-engine-3.4 * Check merged to previ

[Engine-patches] Change in ovirt-engine[master]: core: Fix FindBugs issue in EventNotificationMethod

2014-03-05 Thread mperina
Martin Peřina has posted comments on this change. Change subject: core: Fix FindBugs issue in EventNotificationMethod .. Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/25309/1/backend/manager/modules/common/src/main/java

[Engine-patches] Change in ovirt-engine[master]: core: Fix FindBugs issue in EventNotificationMethod

2014-03-05 Thread mperina
Martin Peřina has posted comments on this change. Change subject: core: Fix FindBugs issue in EventNotificationMethod .. Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/25309/1/backend/manager/modules/common/src/main/java

[Engine-patches] Change in ovirt-engine[master]: core: Fix FindBugs issue in EventNotificationMethod

2014-03-05 Thread amureini
Allon Mureinik has posted comments on this change. Change subject: core: Fix FindBugs issue in EventNotificationMethod .. Patch Set 1: Code-Review-1 (1 comment) http://gerrit.ovirt.org/#/c/25309/1/backend/manager/modules/commo

[Engine-patches] Change in ovirt-engine[master]: core: Fix FindBugs issue in EventNotificationMethod

2014-03-04 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: core: Fix FindBugs issue in EventNotificationMethod .. Patch Set 1: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_master_unit_tests_gerr

[Engine-patches] Change in ovirt-engine[master]: core: Fix FindBugs issue in EventNotificationMethod

2014-03-04 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: core: Fix FindBugs issue in EventNotificationMethod .. Patch Set 1: * Bug-Url: IGNORE, not in a monitored branch (ovirt-engine-3.4 * Check merged to previ

[Engine-patches] Change in ovirt-engine[master]: core: Fix FindBugs issue in EventNotificationMethod

2014-03-04 Thread mperina
Martin Peřina has uploaded a new change for review. Change subject: core: Fix FindBugs issue in EventNotificationMethod .. core: Fix FindBugs issue in EventNotificationMethod Fixes FindBugs issue in EventNotificationMethod intro

[Engine-patches] Change in ovirt-engine[master]: core: Fix FindBugs issue in EventNotificationMethod

2014-03-04 Thread mperina
Martin Peřina has posted comments on this change. Change subject: core: Fix FindBugs issue in EventNotificationMethod .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.ovirt.org/25309 To unsubscribe, visit http://gerr

[Engine-patches] Change in ovirt-engine[master]: core: fix findbugs in AddGroupCommand

2014-02-10 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: core: fix findbugs in AddGroupCommand .. Patch Set 2: Verified-1 Build Failed http://jenkins.ovirt.org/job/ovirt_engine_master_compile_checkstyle_ger

[Engine-patches] Change in ovirt-engine[master]: core: fix findbugs in AddGroupCommand

2014-02-10 Thread yzaslavs
Yair Zaslavsky has posted comments on this change. Change subject: core: fix findbugs in AddGroupCommand .. Patch Set 2: Verified+1 Code-Review+2 -- To view, visit http://gerrit.ovirt.org/24251 To unsubscribe, visit http://ger

[Engine-patches] Change in ovirt-engine[master]: core: fix findbugs in AddGroupCommand

2014-02-10 Thread yzaslavs
Yair Zaslavsky has posted comments on this change. Change subject: core: fix findbugs in AddGroupCommand .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/24251 To unsubscribe, visit http://gerrit.ovirt.o

[Engine-patches] Change in ovirt-engine[master]: core: fix findbugs in AddGroupCommand

2014-02-10 Thread masayag
Moti Asayag has posted comments on this change. Change subject: core: fix findbugs in AddGroupCommand .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/24251 To unsubscribe, visit http://gerrit.ovirt.org/

[Engine-patches] Change in ovirt-engine[master]: core: fix findbugs in AddGroupCommand

2014-02-10 Thread yzaslavs
Yair Zaslavsky has posted comments on this change. Change subject: core: fix findbugs in AddGroupCommand .. Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/24251/1/backend/manager/modules/bll/src/main/java/org/ovirt/engin

[Engine-patches] Change in ovirt-engine[master]: core: fix findbugs in AddGroupCommand

2014-02-10 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: core: fix findbugs in AddGroupCommand .. Patch Set 1: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_master_compile_checkstyle_gerrit/179

[Engine-patches] Change in ovirt-engine[master]: core: fix findbugs in AddGroupCommand

2014-02-10 Thread masayag
Moti Asayag has posted comments on this change. Change subject: core: fix findbugs in AddGroupCommand .. Patch Set 1: (2 comments) http://gerrit.ovirt.org/#/c/24251/1/backend/manager/modules/bll/src/main/java/org/ovirt/engine/

[Engine-patches] Change in ovirt-engine[master]: core: fix findbugs in AddGroupCommand

2014-02-10 Thread yzaslavs
Yair Zaslavsky has posted comments on this change. Change subject: core: fix findbugs in AddGroupCommand .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.ovirt.org/24251 To unsubscribe, visit http://gerrit.ovirt.org/

[Engine-patches] Change in ovirt-engine[master]: core: fix findbugs in AddGroupCommand

2014-02-10 Thread yzaslavs
Yair Zaslavsky has uploaded a new change for review. Change subject: core: fix findbugs in AddGroupCommand .. core: fix findbugs in AddGroupCommand Change-Id: I801596dc43aa6f684246670d1dd40aeb7aafc47f signed-off-by: Yair Zaslavs

[Engine-patches] Change in ovirt-engine[master]: core: fix findbugs issue for PolicyUnit.equals()

2014-01-15 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: core: fix findbugs issue for PolicyUnit.equals() .. Patch Set 4: Build Failed http://jenkins.ovirt.org/job/ovirt_engine_master_compile_checkstyle_ger

[Engine-patches] Change in ovirt-engine[master]: core: fix findbugs issue for PolicyUnit.equals()

2014-01-15 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: core: fix findbugs issue for PolicyUnit.equals() .. Patch Set 5: Build Failed http://jenkins.ovirt.org/job/ovirt_engine_master_compile_checkstyle_ger

[Engine-patches] Change in ovirt-engine[master]: core: fix findbugs issue for PolicyUnit.equals()

2014-01-15 Thread gchaplik
Gilad Chaplik has posted comments on this change. Change subject: core: fix findbugs issue for PolicyUnit.equals() .. Patch Set 5: Verified+1 Code-Review+2 inc Allon's changes. -- To view, visit http://gerrit.ovirt.org/19285

[Engine-patches] Change in ovirt-engine[master]: core: fix findbugs issue for PolicyUnit.equals()

2014-01-15 Thread gchaplik
Gilad Chaplik has submitted this change and it was merged. Change subject: core: fix findbugs issue for PolicyUnit.equals() .. core: fix findbugs issue for PolicyUnit.equals() PolicyUnitImpl is a decorator for PolicyUnit, but d

[Engine-patches] Change in ovirt-engine[master]: core: fix findbugs issue for PolicyUnit.equals()

2014-01-15 Thread gchaplik
Gilad Chaplik has posted comments on this change. Change subject: core: fix findbugs issue for PolicyUnit.equals() .. Patch Set 3: Verified+1 Code-Review+2 -- To view, visit http://gerrit.ovirt.org/19285 To unsubscribe, visit

[Engine-patches] Change in ovirt-engine[master]: core: fix findbugs issue for PolicyUnit.equals()

2014-01-15 Thread amureini
Allon Mureinik has posted comments on this change. Change subject: core: fix findbugs issue for PolicyUnit.equals() .. Patch Set 3: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/19285 To unsubscribe, visit http://ger

[Engine-patches] Change in ovirt-engine[master]: core: fix findbugs issue for PolicyUnit.equals()

2014-01-15 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: core: fix findbugs issue for PolicyUnit.equals() .. Patch Set 3: Verified-1 Build Failed http://jenkins.ovirt.org/job/ovirt_engine_master_unit_tests_

[Engine-patches] Change in ovirt-engine[master]: core: fix findbugs issue for PolicyUnit.equals()

2014-01-15 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: core: fix findbugs issue for PolicyUnit.equals() .. Patch Set 2: Verified-1 Build Failed http://jenkins.ovirt.org/job/ovirt_engine_master_unit_tests_

[Engine-patches] Change in ovirt-engine[master]: core: fix findbugs issue for PolicyUnit.equals()

2014-01-15 Thread gchaplik
Gilad Chaplik has posted comments on this change. Change subject: core: fix findbugs issue for PolicyUnit.equals() .. Patch Set 2: Verified+1 -- To view, visit http://gerrit.ovirt.org/19285 To unsubscribe, visit http://gerrit.

[Engine-patches] Change in ovirt-engine[master]: core: fix findbugs issue for PolicyUnit.equals()

2014-01-12 Thread amureini
Allon Mureinik has posted comments on this change. Change subject: core: fix findbugs issue for PolicyUnit.equals() .. Patch Set 1: Gilad, Since http://gerrit.ovirt.org/#/c/22964/ was already merged, you should also remove th

[Engine-patches] Change in ovirt-engine[master]: core: fix findbugs issue for PolicyUnit.equals()

2014-01-07 Thread Gustavo Frederico Temple Pedrosa
Gustavo Frederico Temple Pedrosa has posted comments on this change. Change subject: core: fix findbugs issue for PolicyUnit.equals() .. Patch Set 1: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/19285 To unsubscribe

[Engine-patches] Change in ovirt-engine[master]: core: fix findbugs issue for PolicyUnit.equals()

2014-01-05 Thread amureini
Allon Mureinik has posted comments on this change. Change subject: core: fix findbugs issue for PolicyUnit.equals() .. Patch Set 1: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/19285 To unsubscribe, visit http://ger

[Engine-patches] Change in ovirt-engine[master]: core: Fix FindBugs filter for XmlNode.innerText

2013-11-25 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: core: Fix FindBugs filter for XmlNode.innerText .. Patch Set 2: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_3.3_update_db_to_master_ge

[Engine-patches] Change in ovirt-engine[master]: core: Fix FindBugs filter for XmlNode.innerText

2013-11-25 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: core: Fix FindBugs filter for XmlNode.innerText .. Patch Set 2: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_3.3_update_db_to_master_ge

[Engine-patches] Change in ovirt-engine[master]: core: Fix FindBugs filter for XmlNode.innerText

2013-11-25 Thread rgolan
Roy Golan has posted comments on this change. Change subject: core: Fix FindBugs filter for XmlNode.innerText .. Patch Set 2: Verified+1 Code-Review+2 -- To view, visit http://gerrit.ovirt.org/21601 To unsubscribe, visit http:

[Engine-patches] Change in ovirt-engine[master]: core: Fix FindBugs filter for XmlNode.innerText

2013-11-25 Thread rgolan
Roy Golan has submitted this change and it was merged. Change subject: core: Fix FindBugs filter for XmlNode.innerText .. core: Fix FindBugs filter for XmlNode.innerText Commit d377d275416edbbd3f4b1d57047ee04840412bba renamed X

[Engine-patches] Change in ovirt-engine[master]: core: Fix FindBugs filter for XmlNode.innerText

2013-11-25 Thread tnisan
Tal Nisan has posted comments on this change. Change subject: core: Fix FindBugs filter for XmlNode.innerText .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/21601 To unsubscribe, visit http://gerrit.ov

[Engine-patches] Change in ovirt-engine[master]: core: Fix FindBugs filter for XmlNode.innerText

2013-11-25 Thread amureini
Allon Mureinik has posted comments on this change. Change subject: core: Fix FindBugs filter for XmlNode.innerText .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.ovirt.org/21601 To unsubscribe, visit http://gerrit.

[Engine-patches] Change in ovirt-engine[master]: core: Fix FindBugs filter for XmlNode.innerText

2013-11-25 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: core: Fix FindBugs filter for XmlNode.innerText .. Patch Set 1: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_3.3_update_db_to_master_ge

[Engine-patches] Change in ovirt-engine[master]: core: Fix FindBugs filter for XmlNode.innerText

2013-11-25 Thread amureini
Allon Mureinik has uploaded a new change for review. Change subject: core: Fix FindBugs filter for XmlNode.innerText .. core: Fix FindBugs filter for XmlNode.innerText Commit d377d275416edbbd3f4b1d57047ee04840412bba renamed XmlN

[Engine-patches] Change in ovirt-engine[master]: core: fix findbugs boolean comprasion warning

2013-10-27 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: core: fix findbugs boolean comprasion warning .. Patch Set 2: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_master_compile_checkstyle_ge

[Engine-patches] Change in ovirt-engine[master]: core: fix findbugs boolean comprasion warning

2013-10-27 Thread amureini
Allon Mureinik has posted comments on this change. Change subject: core: fix findbugs boolean comprasion warning .. Patch Set 2: Verified+1 Code-Review+2 Rebased, no changes. -- To view, visit http://gerrit.ovirt.org/20571 To

[Engine-patches] Change in ovirt-engine[master]: core: fix findbugs boolean comprasion warning

2013-10-27 Thread amureini
Allon Mureinik has submitted this change and it was merged. Change subject: core: fix findbugs boolean comprasion warning .. core: fix findbugs boolean comprasion warning Change-Id: I68e6b0453d8e599e3516de8832096c4b37300fda Sig

[Engine-patches] Change in ovirt-engine[master]: core: fix findbugs boolean comprasion warning

2013-10-27 Thread amureini
Allon Mureinik has posted comments on this change. Change subject: core: fix findbugs boolean comprasion warning .. Patch Set 1: Verified+1 Code-Review+2 -- To view, visit http://gerrit.ovirt.org/20571 To unsubscribe, visit ht

[Engine-patches] Change in ovirt-engine[master]: core: fix findbugs boolean comprasion warning

2013-10-27 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: core: fix findbugs boolean comprasion warning .. Patch Set 1: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_master_compile_checkstyle_ge

[Engine-patches] Change in ovirt-engine[master]: core: fix findbugs boolean comprasion warning

2013-10-27 Thread laravot
Liron Ar has uploaded a new change for review. Change subject: core: fix findbugs boolean comprasion warning .. core: fix findbugs boolean comprasion warning Change-Id: I68e6b0453d8e599e3516de8832096c4b37300fda Signed-off-by: Li

[Engine-patches] Change in ovirt-engine[master]: core: fix findbugs issue for PolicyUnit.equals()

2013-10-20 Thread dfediuck
Doron Fediuck has posted comments on this change. Change subject: core: fix findbugs issue for PolicyUnit.equals() .. Patch Set 1: Code-Review+2 I'm fine with rename later on. -- To view, visit http://gerrit.ovirt.org/19285 T

[Engine-patches] Change in ovirt-engine[master]: core: fix findbugs issue for PolicyUnit.equals()

2013-10-20 Thread gchaplik
Gilad Chaplik has posted comments on this change. Change subject: core: fix findbugs issue for PolicyUnit.equals() .. Patch Set 1: -Verified -- To view, visit http://gerrit.ovirt.org/19285 To unsubscribe, visit http://gerrit.o

[Engine-patches] Change in ovirt-engine[master]: core: fix findbugs issue for PolicyUnit.equals()

2013-10-20 Thread gchaplik
Gilad Chaplik has posted comments on this change. Change subject: core: fix findbugs issue for PolicyUnit.equals() .. Patch Set 1: Can I do it in a separate later patch? there are a lot of references to this class and I want a

[Engine-patches] Change in ovirt-engine[master]: core: fix findbugs issue for PolicyUnit.equals()

2013-10-06 Thread dfediuck
Doron Fediuck has posted comments on this change. Change subject: core: fix findbugs issue for PolicyUnit.equals() .. Patch Set 1: Since the Impl is no longer extending, can you find a better naming convention? -- To view, vi

[Engine-patches] Change in ovirt-engine[master]: core: fix findbugs issue for PolicyUnit.equals()

2013-09-18 Thread abonas
Alissa Bonas has posted comments on this change. Change subject: core: fix findbugs issue for PolicyUnit.equals() .. Patch Set 1: Code-Review+1 after clarifying with Gilad - it indeed looks better now at least design wise (not

[Engine-patches] Change in ovirt-engine[master]: core: fix findbugs issue for PolicyUnit.equals()

2013-09-18 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: core: fix findbugs issue for PolicyUnit.equals() .. Patch Set 1: Code-Review-1 Build Unstable http://jenkins.ovirt.org/job/ovirt_engine_unit_tests_ge

[Engine-patches] Change in ovirt-engine[master]: core: fix findbugs issue for PolicyUnit.equals()

2013-09-17 Thread gchaplik
Gilad Chaplik has posted comments on this change. Change subject: core: fix findbugs issue for PolicyUnit.equals() .. Patch Set 1: cleans, thanks Alissa :) -- To view, visit http://gerrit.ovirt.org/19285 To unsubscribe, visit

[Engine-patches] Change in ovirt-engine[master]: core: fix findbugs issue for PolicyUnit.equals()

2013-09-16 Thread gchaplik
Gilad Chaplik has posted comments on this change. Change subject: core: fix findbugs issue for PolicyUnit.equals() .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.ovirt.org/19285 To unsubscribe, visit http://gerrit.

[Engine-patches] Change in ovirt-engine[master]: core: fix findbugs issue for PolicyUnit.equals()

2013-09-16 Thread gchaplik
Gilad Chaplik has uploaded a new change for review. Change subject: core: fix findbugs issue for PolicyUnit.equals() .. core: fix findbugs issue for PolicyUnit.equals() PolicyUnitImpl is a decorator for PolicyUnit, but doesn't o

[Engine-patches] Change in ovirt-engine[master]: core: fix findbugs errors

2013-09-01 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: core: fix findbugs errors .. Patch Set 2: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_sanity_compile_checkstyle_gerrit/7507/ : SUCCES

[Engine-patches] Change in ovirt-engine[master]: core: fix findbugs errors

2013-09-01 Thread ofrenkel
Omer Frenkel has posted comments on this change. Change subject: core: fix findbugs errors .. Patch Set 2: Verified+1 Code-Review+2 -- To view, visit http://gerrit.ovirt.org/18650 To unsubscribe, visit http://gerrit.ovirt.org/

[Engine-patches] Change in ovirt-engine[master]: core: fix findbugs errors

2013-09-01 Thread ofrenkel
Omer Frenkel has submitted this change and it was merged. Change subject: core: fix findbugs errors .. core: fix findbugs errors There were couple of errors related to the way we compute if post zero is needed when removing mem

[Engine-patches] Change in ovirt-engine[master]: core: fix findbugs errors

2013-08-28 Thread abonas
Alissa Bonas has posted comments on this change. Change subject: core: fix findbugs errors .. Patch Set 1: Code-Review+1 adding Allon, as this is storage related... -- To view, visit http://gerrit.ovirt.org/18650 To unsubscri

[Engine-patches] Change in ovirt-engine[master]: core: fix findbugs errors

2013-08-28 Thread ahadas
Arik Hadas has posted comments on this change. Change subject: core: fix findbugs errors .. Patch Set 1: (1 comment) File backend/manager/modules/bll/src/main/java/org/ovir

[Engine-patches] Change in ovirt-engine[master]: core: fix findbugs errors

2013-08-28 Thread abonas
Alissa Bonas has posted comments on this change. Change subject: core: fix findbugs errors .. Patch Set 1: (1 comment) File backend/manager/modules/bll/src/main/java/org/ov

[Engine-patches] Change in ovirt-engine[master]: core: fix findbugs errors

2013-08-28 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: core: fix findbugs errors .. Patch Set 1: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_sanity_compile_checkstyle_gerrit/7327/ : SUCCES

[Engine-patches] Change in ovirt-engine[master]: core: fix findbugs errors

2013-08-28 Thread ahadas
Arik Hadas has posted comments on this change. Change subject: core: fix findbugs errors .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.ovirt.org/18650 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit

[Engine-patches] Change in ovirt-engine[master]: core: fix findbugs errors

2013-08-28 Thread ahadas
Arik Hadas has uploaded a new change for review. Change subject: core: fix findbugs errors .. core: fix findbugs errors There were couple of errors related to the way we compute if post zero is needed when removing memory image

[Engine-patches] Change in ovirt-engine[master]: core: Fix findbugs to conform to mvn 3.0

2013-06-06 Thread yzaslavs
Yair Zaslavsky has posted comments on this change. Change subject: core: Fix findbugs to conform to mvn 3.0 .. Patch Set 10: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/15077 To unsubscribe, visit http:

[Engine-patches] Change in ovirt-engine[master]: core: Fix findbugs to conform to mvn 3.0

2013-06-06 Thread yzaslavs
Yair Zaslavsky has submitted this change and it was merged. Change subject: core: Fix findbugs to conform to mvn 3.0 .. core: Fix findbugs to conform to mvn 3.0 In order to run mvn findbugs:findbugs, the findbugs pluging config

[Engine-patches] Change in ovirt-engine[master]: core: Fix findbugs to conform to mvn 3.0

2013-06-06 Thread eedri
Eyal Edri has posted comments on this change. Change subject: core: Fix findbugs to conform to mvn 3.0 .. Patch Set 10: Verified; Looks good to me, but someone else must approve verified on upstream jenkins. -- To view, visit

[Engine-patches] Change in ovirt-engine[master]: core: Fix findbugs to conform to mvn 3.0

2013-06-06 Thread amureini
Allon Mureinik has posted comments on this change. Change subject: core: Fix findbugs to conform to mvn 3.0 .. Patch Set 10: Looks good to me, approved (1 inline comment) Fi

[Engine-patches] Change in ovirt-engine[master]: core: Fix findbugs to conform to mvn 3.0

2013-06-06 Thread juan . hernandez
Juan Hernandez has posted comments on this change. Change subject: core: Fix findbugs to conform to mvn 3.0 .. Patch Set 10: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/15077 To uns

[Engine-patches] Change in ovirt-engine[master]: core: Fix findbugs to conform to mvn 3.0

2013-06-05 Thread yzaslavs
Yair Zaslavsky has posted comments on this change. Change subject: core: Fix findbugs to conform to mvn 3.0 .. Patch Set 10: Verified; Looks good to me, but someone else must approve Verified using a jenkins job. -- To view, v

[Engine-patches] Change in ovirt-engine[master]: core: Fix findbugs to conform to mvn 3.0

2013-06-05 Thread yzaslavs
Yair Zaslavsky has posted comments on this change. Change subject: core: Fix findbugs to conform to mvn 3.0 .. Patch Set 9: Correct, looks like i checked only backened. will fix that in next patch. -- To view, visit http://ger

[Engine-patches] Change in ovirt-engine[master]: core: Fix findbugs to conform to mvn 3.0

2013-06-05 Thread juan . hernandez
Juan Hernandez has posted comments on this change. Change subject: core: Fix findbugs to conform to mvn 3.0 .. Patch Set 9: Not sure if it is relevant, but there are several places where we are still referencing the exclude-fi

[Engine-patches] Change in ovirt-engine[master]: core: Fix findbugs to conform to mvn 3.0

2013-06-03 Thread yzaslavs
Yair Zaslavsky has posted comments on this change. Change subject: core: Fix findbugs to conform to mvn 3.0 .. Patch Set 8: Do not submit I should place WIP here, do not review this, this is still not working. -- To view, visi

[Engine-patches] Change in ovirt-engine[master]: core: Fix findbugs to conform to mvn 3.0

2013-06-03 Thread masayag
Moti Asayag has posted comments on this change. Change subject: core: Fix findbugs to conform to mvn 3.0 .. Patch Set 8: Yair, please fix commit message typo as Allon mentioned already (twice) -- To view, visit http://gerrit.o

[Engine-patches] Change in ovirt-engine[master]: core: Fix findbugs to conform to mvn 3.0

2013-06-02 Thread yzaslavs
Yair Zaslavsky has posted comments on this change. Change subject: core: Fix findbugs to conform to mvn 3.0 .. Patch Set 4: I would prefer that you didn't submit this (1 inline comment) Still failing on jenkins. .

[Engine-patches] Change in ovirt-engine[master]: core: Fix findbugs to conform to mvn 3.0

2013-06-02 Thread amureini
Allon Mureinik has posted comments on this change. Change subject: core: Fix findbugs to conform to mvn 3.0 .. Patch Set 4: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/15077 To unsu

  1   2   >