Alissa Bonas has posted comments on this change. Change subject: core: fix findbugs issue for PolicyUnit.equals() ......................................................................
Patch Set 1: Code-Review+1 after clarifying with Gilad - it indeed looks better now at least design wise (not both inheritance and container like it was before this patch). Gilad, please make sure that indeed it cleans the findbugs warnings. thanks -- To view, visit http://gerrit.ovirt.org/19285 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2d31dfb51268929df30bd468b14bfbc3e336c273 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Gilad Chaplik <gchap...@redhat.com> Gerrit-Reviewer: Alissa Bonas <abo...@redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches