Allon Mureinik has posted comments on this change. Change subject: core: Fix FindBugs issue in EventNotificationMethod ......................................................................
Patch Set 1: Code-Review-1 (1 comment) http://gerrit.ovirt.org/#/c/25309/1/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/EventNotificationMethod.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/EventNotificationMethod.java: Line 26: /** Line 27: * Returns enum value based on external string representation Line 28: */ Line 29: public static EventNotificationMethod valueOfString(String value) { Line 30: return valueOf(value != null ? value.toUpperCase() : null); valueOf does not support nulls - this will cause an NPE, just like the code before the patch. I'm guessing you meant to do something like this: return value != null ? valueOf(value.toUpperCase()) : null; Line 31: } -- To view, visit http://gerrit.ovirt.org/25309 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3dafb358db93280d58e40ca1056230ae1dba1767 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Peřina <mper...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Martin Peřina <mper...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
