Yair Zaslavsky has uploaded a new change for review.
Change subject: core: fix findbugs in AddGroupCommand
......................................................................
core: fix findbugs in AddGroupCommand
Change-Id: I801596dc43aa6f684246670d1dd40aeb7aafc47f
signed-off-by: Yair Zaslavsky <yzasl...@redhat.com>
---
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddGroupCommand.java
1 file changed, 5 insertions(+), 0 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/51/24251/1
diff --git
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddGroupCommand.java
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddGroupCommand.java
index df10277..fe80487 100644
---
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddGroupCommand.java
+++
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddGroupCommand.java
@@ -37,6 +37,11 @@
String directoryName = getParameters().getDirectory();
ExternalId id = getParameters().getId();
Directory directory =
DirectoryManager.getInstance().getDirectory(directoryName);
+ if (directory == null) {
+ addCanDoActionMessage(VdcBllMessages.USER_MUST_EXIST_IN_DIRECTORY);
+ return false;
+
+ }
directoryGroup = directory.findGroup(id);
if (directoryGroup == null) {
addCanDoActionMessage(VdcBllMessages.USER_MUST_EXIST_IN_DIRECTORY);
--
To view, visit http://gerrit.ovirt.org/24251
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I801596dc43aa6f684246670d1dd40aeb7aafc47f
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yair Zaslavsky <yzasl...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
