Moti Asayag has posted comments on this change. Change subject: core: fix findbugs in AddGroupCommand ......................................................................
Patch Set 1: (2 comments) http://gerrit.ovirt.org/#/c/24251/1/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddGroupCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddGroupCommand.java: Line 37: String directoryName = getParameters().getDirectory(); Line 38: ExternalId id = getParameters().getId(); Line 39: Directory directory = DirectoryManager.getInstance().getDirectory(directoryName); Line 40: if (directory == null) { Line 41: addCanDoActionMessage(VdcBllMessages.USER_MUST_EXIST_IN_DIRECTORY); shouldn't there be a specific message for 'Directory does not exist' ? Line 42: return false; Line 43: Line 44: } Line 45: directoryGroup = directory.findGroup(id); Line 40: if (directory == null) { Line 41: addCanDoActionMessage(VdcBllMessages.USER_MUST_EXIST_IN_DIRECTORY); Line 42: return false; Line 43: Line 44: } please add a space line. Line 45: directoryGroup = directory.findGroup(id); Line 46: if (directoryGroup == null) { Line 47: addCanDoActionMessage(VdcBllMessages.USER_MUST_EXIST_IN_DIRECTORY); Line 48: return false; -- To view, visit http://gerrit.ovirt.org/24251 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I801596dc43aa6f684246670d1dd40aeb7aafc47f Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
