Juan Hernandez has posted comments on this change.

Change subject: core: Fix findbugs to conform to mvn 3.0
......................................................................


Patch Set 9:

Not sure if it is relevant, but there are several places where we are still 
referencing the exclude-filter.xml without the ${basedir} prefix:

  $ git grep -Fn '>exclude-filters.xml<'
  backend/manager/modules/root/pom.xml:93:           
<excludeFilterFile>exclude-filters.xml</excludeFilterFile>
  backend/manager/tools/pom.xml:90:           
<excludeFilterFile>exclude-filters.xml</excludeFilterFile>
  backend/manager/tools/pom.xml:122:               
<excludeFilterFile>exclude-filters.xml</excludeFilterFile>
  frontend/webadmin/modules/gwt-common/pom.xml:144:           
<excludeFilterFile>exclude-filters.xml</excludeFilterFile>
  frontend/webadmin/modules/userportal-gwtp/pom.xml:206:           
<excludeFilterFile>exclude-  filters.xml</excludeFilterFile>
  frontend/webadmin/modules/userportal-gwtp/pom.xml:240:               
<excludeFilterFile>exclude-filters.xml</excludeFilterFile>
  frontend/webadmin/modules/userportal-gwtp/pom.xml:307:               
<excludeFilterFile>exclude-filters.xml</excludeFilterFile>
  frontend/webadmin/modules/webadmin/pom.xml:206:              
<excludeFilterFile>exclude-filters.xml</excludeFilterFile>
  frontend/webadmin/modules/webadmin/pom.xml:241:              
<excludeFilterFile>exclude-filters.xml</excludeFilterFile>
  frontend/webadmin/modules/webadmin/pom.xml:308:              
<excludeFilterFile>exclude-filters.xml</excludeFilterFile>

--
To view, visit http://gerrit.ovirt.org/15077
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id674955625a14c6e02a579fe2f132f64a8db9cc2
Gerrit-PatchSet: 9
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yair Zaslavsky <yzasl...@redhat.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Eyal Edri <ee...@redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com>
Gerrit-Reviewer: Moti Asayag <masa...@redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to