Arik Hadas has uploaded a new change for review.
Change subject: core: fix findbugs
......................................................................
core: fix findbugs
Fix RCN_REDUNDANT_NULLCHECK_WOULD_HAVE_BEEN_A_NPE
Change-Id: Ie614377ee4715cc4cd9a5bd6ec7eba4a20aa8a0e
Signed-off-by: Arik Hadas <aha...@redhat.com>
---
M
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/IrsProxyData.java
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/57/42257/1
diff --git
a/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/IrsProxyData.java
b/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/IrsProxyData.java
index 5f67d29..d9f02b9 100644
---
a/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/IrsProxyData.java
+++
b/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/IrsProxyData.java
@@ -185,8 +185,8 @@
StoragePool storagePool =
DbFacade.getInstance().getStoragePoolDao()
.get(_storagePoolId);
- boolean poolStatusDeterminedByHostsStatus =
FeatureSupported.dataCenterWithoutSpm(storagePool.getCompatibilityVersion());
if (storagePool != null) {
+ boolean poolStatusDeterminedByHostsStatus =
FeatureSupported.dataCenterWithoutSpm(storagePool.getCompatibilityVersion());
// when there are no hosts in status up, it means that
there shouldn't be domain monitoring
// so all the domains need to move to "unknown" status
as otherwise their status won't change.
if (DbFacade.getInstance()
--
To view, visit https://gerrit.ovirt.org/42257
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie614377ee4715cc4cd9a5bd6ec7eba4a20aa8a0e
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <aha...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
