Allon Mureinik has posted comments on this change.

Change subject: core: fix findbugs issue for PolicyUnit.equals()
......................................................................


Patch Set 1:

Gilad,

Since http://gerrit.ovirt.org/#/c/22964/ was already merged, you should also 
remove the references to PolicyUnitImpl and NetworkPolicyUnit from 
backend/manager/modules/bll/exclude-filters.xml .

Since I introduced those FindBugs exclusions (which will become outdated by 
your patch), if you prefer, I can rebase this patch and remove those references 
for you - just let me know.

-- 
To view, visit http://gerrit.ovirt.org/19285
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2d31dfb51268929df30bd468b14bfbc3e336c273
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Gilad Chaplik <gchap...@redhat.com>
Gerrit-Reviewer: Alissa Bonas <abo...@redhat.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Doron Fediuck <dfedi...@redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com>
Gerrit-Reviewer: Gustavo Frederico Temple Pedrosa 
<gustavo.pedr...@eldorado.org.br>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to