Yedidyah Bar David has posted comments on this change.
Change subject: packaging: engine-backup: Added performance wrappers
..
Patch Set 1:
Note that --fast-backup is currently a copy of --fast-restore, which itself is
a copy
Yedidyah Bar David has posted comments on this change.
Change subject: packaging: setup: Remove log-setup-event
..
Patch Set 1: Verified+1
--
To view, visit https://gerrit.ovirt.org/42401
To unsubscribe, visit https://gerrit.o
Yedidyah Bar David has posted comments on this change.
Change subject: packaging: Add ovirt-engine-reports-tool
..
Patch Set 19:
admin password filtering moved to common
pep8
--
To view, visit https://gerrit.ovirt.org/42032
Yedidyah Bar David has posted comments on this change.
Change subject: packaging: Add ovirt-engine-reports-tool
..
Patch Set 19: Verified+1
--
To view, visit https://gerrit.ovirt.org/42032
To unsubscribe, visit https://gerrit.
Yedidyah Bar David has posted comments on this change.
Change subject: packaging: Add ovirt-engine-reports-tool
..
Patch Set 18:
(2 comments)
https://gerrit.ovirt.org/#/c/42032/18/packaging/setup/plugins/ovirt-engine-reports-t
Yedidyah Bar David has posted comments on this change.
Change subject: packaging: Add ovirt-engine-reports-tool
..
Patch Set 18: Verified-1
Simone's note about admin password is correct
--
To view, visit https://gerrit.ovirt.
Yedidyah Bar David has posted comments on this change.
Change subject: packaging: engine-backup: Added performance wrappers
..
Patch Set 1: Verified+1
--
To view, visit https://gerrit.ovirt.org/42443
To unsubscribe, visit http
Yedidyah Bar David has posted comments on this change.
Change subject: packaging: Add ovirt-engine-reports-tool
..
Patch Set 18: Verified+1
--
To view, visit https://gerrit.ovirt.org/42032
To unsubscribe, visit https://gerrit.
Yedidyah Bar David has posted comments on this change.
Change subject: packaging: setup: Stop services only when needed
..
Patch Set 1: Verified+1
--
To view, visit https://gerrit.ovirt.org/42430
To unsubscribe, visit https://
Yedidyah Bar David has posted comments on this change.
Change subject: packaging: setup: Stop services only when needed
..
Patch Set 2: Verified+1
--
To view, visit https://gerrit.ovirt.org/42411
To unsubscribe, visit https://
Yedidyah Bar David has uploaded a new change for review.
Change subject: packaging: engine-backup: Added performance wrappers
..
packaging: engine-backup: Added performance wrappers
Added --fast-restore, --small-size, --fast-bac
Yedidyah Bar David has posted comments on this change.
Change subject: packaging: setup: adding DOCKERC_NEEDED
..
Patch Set 6: Code-Review+1
You can use Bug-Url from https://gerrit.ovirt.org/42411
--
To view, visit https://ge
Yedidyah Bar David has uploaded a new change for review.
Change subject: packaging: setup: Stop services only when needed
..
packaging: setup: Stop services only when needed
Added env key for stopping dwhd.
Stopping dwhd defaul
Yedidyah Bar David has uploaded a new change for review.
Change subject: packaging: setup: Stop services only when needed
..
packaging: setup: Stop services only when needed
Added env keys for stopping engine, fence-kdump-listen
Yedidyah Bar David has posted comments on this change.
Change subject: packaging: Add ovirt-engine-reports-tool
..
Patch Set 15:
also Yaniv said that we should not stop/start reportsd
--
To view, visit https://gerrit.ovirt.or
Yedidyah Bar David has posted comments on this change.
Change subject: packaging: setup: adding DOCKERC_NEEDED
..
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/42405
To unsubscribe, visit https://gerrit
Yedidyah Bar David has posted comments on this change.
Change subject: packaging: setup: adding DOCKERC_NEEDED
..
Patch Set 1:
(2 comments)
https://gerrit.ovirt.org/#/c/42405/1/packaging/setup/plugins/ovirt-engine-remove/docke
Yedidyah Bar David has uploaded a new change for review.
Change subject: packaging: setup: Remove log-setup-event
..
packaging: setup: Remove log-setup-event
Remove the script ovirt-engine-log-setup-event.sh, which adds info abo
Yedidyah Bar David has posted comments on this change.
Change subject: packaging: Add ovirt-engine-reports-tool
..
Patch Set 15: Verified-1
Marking -1 until we make sure we do not interfere with other stuff.
I did all of my te
Yedidyah Bar David has posted comments on this change.
Change subject: packaging: setup: do not fail cleanup if engine db inaccessible
..
Patch Set 1: Verified+1
--
To view, visit https://gerrit.ovirt.org/41044
To unsubscribe,
Yedidyah Bar David has abandoned this change.
Change subject: packaging: setup: Make pki transactional
..
Abandoned
Will not be used.
Current strategy w.r.t to pki rollback:
It's not transactional
We do all pki immediately,
Yedidyah Bar David has abandoned this change.
Change subject: packaging: setup: Add keepcontenttransaction
..
Abandoned
Will not be used.
Current strategy w.r.t to pki rollback:
It's not transactional
We do all pki immediate
Yedidyah Bar David has uploaded a new change for review.
Change subject: packaging: setup: Add keepcontenttransaction
..
packaging: setup: Add keepcontenttransaction
Similar to filetransaction, but does not write content itself
Yedidyah Bar David has abandoned this change.
Change subject: packaging: setup: Make pki transactional
..
Abandoned
Will not enter 3.5, perhaps not even master currently.
--
To view, visit https://gerrit.ovirt.org/41789
To un
Yedidyah Bar David has posted comments on this change.
Change subject: packaging: spec: Conflict with dwh/reports setup <3.6
..
Patch Set 4: Verified+1
--
To view, visit https://gerrit.ovirt.org/41637
To unsubscribe, visit htt
Yedidyah Bar David has posted comments on this change.
Change subject: services, setup: vmconsole/openssh integration
..
Patch Set 19: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/41329
To unsubscribe, visit https:
Yedidyah Bar David has posted comments on this change.
Change subject: packaging: setup: pki: Do not add empty lines to conf
..
Patch Set 1:
Rerun-Hooks: all
--
To view, visit https://gerrit.ovirt.org/41786
To unsubscribe, vi
Yedidyah Bar David has posted comments on this change.
Change subject: packaging: Add ovirt-engine-reports-tool
..
Patch Set 15: Verified+1
Moved logs to /var/log/ovirt-engine-reports/ovirt-engine-reports-tool
--
To view, vis
Yedidyah Bar David has posted comments on this change.
Change subject: packaging: Add ovirt-engine-reports-tool
..
Patch Set 14: Verified-1
As discussed, will make the tool log to /var/log/ovirt-engine-reports.
--
To view, vi
Yedidyah Bar David has posted comments on this change.
Change subject: services, setup: ovirt-vmconsole integration
..
Patch Set 52: Code-Review+1
Thanks for a great job!
--
To view, visit https://gerrit.ovirt.org/35906
To un
Yedidyah Bar David has posted comments on this change.
Change subject: services, setup: ovirt-vmconsole integration
..
Patch Set 51:
(1 comment)
https://gerrit.ovirt.org/#/c/35906/51/ovirt-engine.spec.in
File ovirt-engine.spec
Yedidyah Bar David has posted comments on this change.
Change subject: services, setup: ovirt-vmconsole integration
..
Patch Set 51:
(2 comments)
https://gerrit.ovirt.org/#/c/35906/51/ovirt-engine.spec.in
File ovirt-engine.spe
Yedidyah Bar David has posted comments on this change.
Change subject: packaging: Add ovirt-engine-reports-tool
..
Patch Set 14: Verified+1
--
To view, visit https://gerrit.ovirt.org/42032
To unsubscribe, visit https://gerrit.
Yedidyah Bar David has posted comments on this change.
Change subject: packaging: Add ovirt-engine-reports-tool
..
Patch Set 14:
some minor fixes discussed during review
--
To view, visit https://gerrit.ovirt.org/42032
To uns
Yedidyah Bar David has posted comments on this change.
Change subject: packaging: license: Corrected the license text
..
Patch Set 2:
Previous change was in https://gerrit.ovirt.org/2890 .
--
To view, visit https://gerrit.ovi
Yedidyah Bar David has posted comments on this change.
Change subject: packaging: license: Corrected the license text
..
Patch Set 1:
Copied the text from the license's "APPENDIX: How to apply the Apache License
to your work".
Yedidyah Bar David has uploaded a new change for review.
Change subject: packaging: license: Corrected the license text
..
packaging: license: Corrected the license text
Corrected the license text in Makefile
Change-Id: Ie24e3e
Yedidyah Bar David has posted comments on this change.
Change subject: services, setup: ovirt-vmconsole integration
..
Patch Set 50:
minor changes
--
To view, visit https://gerrit.ovirt.org/35906
To unsubscribe, visit https:/
Yedidyah Bar David has posted comments on this change.
Change subject: packaging: setup: centralized manualSetupDispatcher code
..
Patch Set 15: Code-Review+1
Minor style changes done. Yaniv - can you please verify again? Thank
Yedidyah Bar David has posted comments on this change.
Change subject: services, setup: vmconsole/openssh integration
..
Patch Set 15:
(4 comments)
https://gerrit.ovirt.org/#/c/41329/15/packaging/setup/plugins/ovirt-engine-set
Yedidyah Bar David has posted comments on this change.
Change subject: services, setup: ovirt-vmconsole integration
..
Patch Set 45:
(17 comments)
https://gerrit.ovirt.org/#/c/35906/45/ovirt-engine.spec.in
File ovirt-engine.sp
Yedidyah Bar David has posted comments on this change.
Change subject: packaging: setup: queryEnvKey: getHostname
..
Patch Set 3: Verified+1
--
To view, visit https://gerrit.ovirt.org/42199
To unsubscribe, visit https://gerrit
Yedidyah Bar David has posted comments on this change.
Change subject: packaging: setup: queryEnvKey: getHostname
..
Patch Set 3:
rebased
--
To view, visit https://gerrit.ovirt.org/42199
To unsubscribe, visit https://gerrit.o
Yedidyah Bar David has posted comments on this change.
Change subject: packaging: setup: queryEnvKey: getHostname
..
Patch Set 2: Verified+1
--
To view, visit https://gerrit.ovirt.org/42199
To unsubscribe, visit https://gerrit
Yedidyah Bar David has posted comments on this change.
Change subject: packaging: Add ovirt-engine-reports-tool
..
Patch Set 12: Verified+1
Verified changing admin password.
Verified export/import but without any actual report
Yedidyah Bar David has abandoned this change.
Change subject: packaging: setup: add temp dir to answer file
..
Abandoned
Not needed.
Normally the default should be ok.
Users that want a different temp dir can manually edit th
Yedidyah Bar David has posted comments on this change.
Change subject: packaging: setup: add temp dir to answer file
..
Patch Set 2:
> Well, maybe on the second host the tempdir specifed on the first
> host won't have enough f
Yedidyah Bar David has posted comments on this change.
Change subject: packaging: setup: add temp dir to answer file
..
Patch Set 2:
> Didi, any reason for not asking review on this?
No reason, just that I didn't ve
Yedidyah Bar David has uploaded a new change for review.
Change subject: packaging: setup: queryEnvKey: getHostname
..
packaging: setup: queryEnvKey: getHostname
Change-Id: I349cba8d4478cbdb008e029ba9fb379e6e0f44f2
Signed-off-by
Yedidyah Bar David has posted comments on this change.
Change subject: packaging: setup: Small fix for queryPassword
..
Patch Set 1: Verified+1
sorry, was too much in a hurry...
Didn't verify that passing tests actually works,
Yedidyah Bar David has uploaded a new change for review.
Change subject: packaging: setup: Small fix for queryPassword
..
packaging: setup: Small fix for queryPassword
Use the tests param.
Also fix doctext of queryEnvKey.
Chan
Yedidyah Bar David has posted comments on this change.
Change subject: packaging: Add queryEnvKey
..
Patch Set 13: Verified+1
Do not swallow exceptions in tests
--
To view, visit https://gerrit.ovirt.org/42017
To unsubscribe,
Yedidyah Bar David has posted comments on this change.
Change subject: packaging: Add queryEnvKey
..
Patch Set 12: Verified+1
Renamed some variables.
Allowed tests to be "interactive only", so skipped if answer set in answer f
Yedidyah Bar David has posted comments on this change.
Change subject: pki: add pki-enroll-openssh-cert functionality
..
Patch Set 10: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/38094
To unsubscribe, visit https:
Yedidyah Bar David has posted comments on this change.
Change subject: pki: add pki-enroll-openssh-cert functionality
..
Patch Set 10:
(1 comment)
https://gerrit.ovirt.org/#/c/38094/10/packaging/bin/pki-enroll-openssh-cert.sh
Yedidyah Bar David has posted comments on this change.
Change subject: pki: cleanup: reset some vars at init
..
Patch Set 9: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/38093
To unsubscribe, visit https://gerrit.o
Yedidyah Bar David has posted comments on this change.
Change subject: packaging: setup: extract ssh public key logic to script
..
Patch Set 9: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/38092
To unsubscribe, vis
Yedidyah Bar David has posted comments on this change.
Change subject: packaging: Add queryEnvKey
..
Patch Set 11:
(2 comments)
https://gerrit.ovirt.org/#/c/42017/11/packaging/setup/ovirt_engine_setup/dialog.py
File packaging/
Yedidyah Bar David has posted comments on this change.
Change subject: packaging: Add queryEnvKey
..
Patch Set 11: Verified+1
Verified various flows with [1] (and [2]).
I think this one is ready. [1] might require some more wo
Yedidyah Bar David has posted comments on this change.
Change subject: packaging: setup: Move java plugin to common/common
..
Patch Set 1: Verified+1
--
To view, visit https://gerrit.ovirt.org/42048
To unsubscribe, visit https
Yedidyah Bar David has posted comments on this change.
Change subject: centralized manualSetupDispatcher code
..
Patch Set 10:
(3 comments)
https://gerrit.ovirt.org/#/c/41399/10/src/ovirt_hosted_engine_setup/check_liveliness.p
Yedidyah Bar David has posted comments on this change.
Change subject: centralized manualSetupDispatcher code
..
Patch Set 10:
(2 comments)
Nice job. Some comments inside. Indentation/style is not always compatible with
exist
Yedidyah Bar David has uploaded a new change for review.
Change subject: packaging: setup: Move java plugin to common/common
..
packaging: setup: Move java plugin to common/common
So that it's available also outside of engine-se
Yedidyah Bar David has uploaded a new change for review.
Change subject: packaging: Add ovirt-engine-reports-tool
..
packaging: Add ovirt-engine-reports-tool
Change-Id: Ida41cf8e0fd04f2bfb0bfd655881625fa5a32cd9
Signed-off-by: Ye
Yedidyah Bar David has posted comments on this change.
Change subject: packaging: setup: pki: Prompt before renewal
..
Patch Set 5: Verified+1
sorted the imports lines
--
To view, visit https://gerrit.ovirt.org/41876
To unsub
Yedidyah Bar David has posted comments on this change.
Change subject: packaging: setup: pki: Prompt before renewal
..
Patch Set 4: Verified+1
Verified on 3.5 (cherry-pick conflicts but simple to fix)
--
To view, visit https:
Yedidyah Bar David has uploaded a new change for review.
Change subject: packaging: setup: pki: Prompt before renewal
..
packaging: setup: pki: Prompt before renewal
Change-Id: Idca01632ac1ea7895bba54d7f3f8bb0d9b2c90d4
Signed-of
Yedidyah Bar David has posted comments on this change.
Change subject: packaging: setup: let the user configure engine VM networking
..
Patch Set 29: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/41357
To unsubscrib
Yedidyah Bar David has posted comments on this change.
Change subject: packaging: setup: let the user configure engine VM networking
..
Patch Set 28: Code-Review+1
(1 comment)
I don't like the hardcoded eth0. If we do not fix
Yedidyah Bar David has posted comments on this change.
Change subject: packaging: setup: let the user configure engine VM networking
..
Patch Set 18:
(1 comment)
https://gerrit.ovirt.org/#/c/41357/18/src/plugins/ovirt-hosted-e
Yedidyah Bar David has posted comments on this change.
Change subject: packaging: setup: let the user configure engine VM networking
..
Patch Set 25:
(3 comments)
https://gerrit.ovirt.org/#/c/41357/25/src/plugins/ovirt-hosted-
Yedidyah Bar David has posted comments on this change.
Change subject: packaging: setup: Disable pki renewal for 3.5
..
Patch Set 3: Verified+1
--
To view, visit https://gerrit.ovirt.org/41882
To unsubscribe, visit https://ger
Yedidyah Bar David has uploaded a new change for review.
Change subject: packaging: setup: Disable pki renewal for 3.5
..
packaging: setup: Disable pki renewal for 3.5
Change-Id: Ib0de9b1f1c3aa3aa1f3d81d47a91d44f458e7192
Signed-
Yedidyah Bar David has posted comments on this change.
Change subject: packaging: setup: pki: Prompt before renewal
..
Patch Set 3: Verified+1
--
To view, visit https://gerrit.ovirt.org/41876
To unsubscribe, visit https://gerr
Yedidyah Bar David has posted comments on this change.
Change subject: packaging: setup: pki: Prompt before renewal
..
Patch Set 3: -Verified
Not finished yet
--
To view, visit https://gerrit.ovirt.org/41876
To unsubscribe, v
Yedidyah Bar David has posted comments on this change.
Change subject: packaging: setup: pki: Prompt before renewal
..
Patch Set 3: Verified+1
Verified upgrade from 3.4
--
To view, visit https://gerrit.ovirt.org/41876
To unsu
Yedidyah Bar David has posted comments on this change.
Change subject: packaging: setup: pki: use local transaction when extracting
PKCS#12
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/41863
To uns
Yedidyah Bar David has posted comments on this change.
Change subject: packaging: setup: pki: use local transaction when extracting
PKCS#12
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/41864
To uns
Yedidyah Bar David has posted comments on this change.
Change subject: packaging: setup: Make pki transactional
..
Patch Set 6:
BTW, if you want to see something even uglier, [1] is what I started doing
before current patch...
Yedidyah Bar David has posted comments on this change.
Change subject: packaging: setup: Make pki transactional
..
Patch Set 6: Verified+1
This one works for me.
I agree with Alon it's ugly. Not sure it's useless.
--
To view
Yedidyah Bar David has posted comments on this change.
Change subject: packaging: setup: pki: use local transaction when extracting
PKCS#12
..
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/41820
To uns
Yedidyah Bar David has posted comments on this change.
Change subject: packaging: setup: pki: use local transaction when extracting
PKCS#12
..
Patch Set 1: Code-Review+1
> I think this will provide a quick remedy for the phone
Yedidyah Bar David has posted comments on this change.
Change subject: packaging: setup: Make pki transactional
..
Patch Set 4:
> the solution should be within the pki scripts not within the setup,
> create yet another workaro
Yedidyah Bar David has posted comments on this change.
Change subject: packaging: spec: Conflict with dwh/reports setup <3.6
..
Patch Set 1:
Rerun-Hooks: all
--
To view, visit https://gerrit.ovirt.org/41637
To unsubscribe, vi
Yedidyah Bar David has uploaded a new change for review.
Change subject: packaging: setup: Make pki transactional
..
packaging: setup: Make pki transactional
Change-Id: I81b25a3febc9fa80ea980b9b284d99a5459217b9
Signed-off-by: Ye
Yedidyah Bar David has posted comments on this change.
Change subject: packaging: setup: Make pki transactional
..
Patch Set 2: Verified+1
--
To view, visit https://gerrit.ovirt.org/41642
To unsubscribe, visit https://gerrit.o
Yedidyah Bar David has posted comments on this change.
Change subject: packaging: setup: pki: Do not add empty lines to conf
..
Patch Set 1: Verified+1
--
To view, visit https://gerrit.ovirt.org/41786
To unsubscribe, visit htt
Yedidyah Bar David has uploaded a new change for review.
Change subject: packaging: setup: pki: Do not add empty lines to conf
..
packaging: setup: pki: Do not add empty lines to conf
Change-Id: Ic864eed1a56320c4ca5498c8caf452a7
Yedidyah Bar David has uploaded a new change for review.
Change subject: packaging: setup: Make pki transactional
..
packaging: setup: Make pki transactional
Change-Id: I81b25a3febc9fa80ea980b9b284d99a5459217b9
Signed-off-by: Ye
Yedidyah Bar David has uploaded a new change for review.
Change subject: packaging: spec: Conflict with dwh/reports setup <3.6
..
packaging: spec: Conflict with dwh/reports setup <3.6
engine's setup plugins require dwh/reports 3
Yedidyah Bar David has posted comments on this change.
Change subject: packaging: setup: let the user configure engine VM networking
..
Patch Set 4:
(4 comments)
https://gerrit.ovirt.org/#/c/41357/4/src/plugins/ovirt-hosted-en
Yedidyah Bar David has posted comments on this change.
Change subject: packaging: setup: let the user configure engine VM networking
..
Patch Set 18:
(6 comments)
still some comments...
https://gerrit.ovirt.org/#/c/41357/18/s
Yedidyah Bar David has posted comments on this change.
Change subject: packaging: setup: let the user configure engine VM networking
..
Patch Set 4:
(15 comments)
Nice work! Some comments inside.
https://gerrit.ovirt.org/#/c/
Yedidyah Bar David has abandoned this change.
Change subject: packaging: setup: always copy vdsm certs if needed
..
Abandoned
Decided to drop the 'virsh' text instead
--
To view, visit https://gerrit.ovirt.org/40613
To unsubs
Yedidyah Bar David has posted comments on this change.
Change subject: packaging: setup: pki: renew about to expire certificates
..
Patch Set 6:
(1 comment)
https://gerrit.ovirt.org/#/c/40330/6/packaging/setup/plugins/ovirt-en
Yedidyah Bar David has posted comments on this change.
Change subject: packaging: setup: pki: Enroll certs on upgrade if not exist
..
Patch Set 1: Verified+1
--
To view, visit https://gerrit.ovirt.org/41375
To unsubscribe, vis
Yedidyah Bar David has uploaded a new change for review.
Change subject: packaging: setup: pki: Enroll certs on upgrade if not exist
..
packaging: setup: pki: Enroll certs on upgrade if not exist
reports key/cert were generated
Yedidyah Bar David has posted comments on this change.
Change subject: packaging: setup: pki: Enroll certs on upgrade if not exist
..
Patch Set 2: Verified+1
--
To view, visit https://gerrit.ovirt.org/41282
To unsubscribe, vis
Yedidyah Bar David has posted comments on this change.
Change subject: packaging: setup: pki: Enroll certs on upgrade if not exist
..
Patch Set 4: Verified+1
Verified on 3.5
--
To view, visit https://gerrit.ovirt.org/41264
To
Yedidyah Bar David has uploaded a new change for review.
Change subject: packaging: setup: pki: Enroll certs on upgrade if not exist
..
packaging: setup: pki: Enroll certs on upgrade if not exist
reports key/cert were generated
1 - 100 of 2201 matches
Mail list logo
