Yedidyah Bar David has uploaded a new change for review.

Change subject: packaging: setup: pki: Enroll certs on upgrade if not exist
......................................................................

packaging: setup: pki: Enroll certs on upgrade if not exist

reports key/cert were generated by 3.5 clean setup, but not by upgrade
(and did not exist in <=3.4). This didn't cause a failure because they
are not used by default. Generate on upgrade.

Bug-Url: https://bugzilla.redhat.com/1224656
Change-Id: I9ed93d47a55f2971337bac277ce69c672901bb07
Signed-off-by: Yedidyah Bar David <d...@redhat.com>
(cherry picked from commit 0e87ed2877f56d12da4dea4387ad67f56bbc45e4)
---
M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/pki/ca.py
1 file changed, 8 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/75/41375/1

diff --git a/packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/pki/ca.py 
b/packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/pki/ca.py
index b0086cd..1a73b60 100644
--- a/packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/pki/ca.py
+++ b/packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/pki/ca.py
@@ -242,7 +242,14 @@
                 '%s.p12' % entry['name'],
             )
 
-            enroll = not renew
+            if not os.path.exists(pkcs12):
+                enroll = True
+                self.logger.debug(
+                    "'%s' does not exist, enrolling",
+                    pkcs12,
+                )
+            else:
+                enroll = not renew
 
             if not enroll:
                 x509 = self._extractPKCS12Certificate(pkcs12)


-- 
To view, visit https://gerrit.ovirt.org/41375
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I9ed93d47a55f2971337bac277ce69c672901bb07
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5.3
Gerrit-Owner: Yedidyah Bar David <d...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to