Yedidyah Bar David has posted comments on this change. Change subject: services, setup: ovirt-vmconsole integration ......................................................................
Patch Set 51: (1 comment) https://gerrit.ovirt.org/#/c/35906/51/ovirt-engine.spec.in File ovirt-engine.spec.in: Line 611: %{ovirt_product_name_short} VMconsole Proxy helper, to integrate Line 612: with ovirt-vmconsole-proxy package Line 613: Line 614: %pre vmconsole-proxy-helper Line 615: %ovirt_create_user_engine > ovirt-vmconsole user/group are owned by ovirt-vmconsole package - I don't w I think you should decide what you want... If the setup plugin will stay here, and you want it to succeed even without the proxy installed, you have to somehow make sure the user exists, because you use it (owner=, group= in filetransaction). Add somewhere a note that while in principle the proxy and the engine can run on different machines, this will currently not work out-of-the-box, and perhaps add (in the source somewhere) a link to a wiki page/section about this (which you can leave empty until you test that it works, even if requiring manual actions). Line 616: Line 617: %package setup-plugin-vmconsole-proxy-helper Line 618: Summary: Setup and upgrade specific plugins for vmconsole-proxy-helper Line 619: Requires: %{name}-setup-plugin-ovirt-engine-common = %{version}-%{release} -- To view, visit https://gerrit.ovirt.org/35906 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I034ef8e6d10da5dc93eda61e0c5c518ca13a5a28 Gerrit-PatchSet: 51 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vitor de Lima <vdel...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik <mpoled...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stira...@redhat.com> Gerrit-Reviewer: Vinzenz Feenstra <vfeen...@redhat.com> Gerrit-Reviewer: Vitor de Lima <vdel...@redhat.com> Gerrit-Reviewer: Yedidyah Bar David <d...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
