Yedidyah Bar David has posted comments on this change. Change subject: packaging: Add ovirt-engine-reports-tool ......................................................................
Patch Set 18: (2 comments) https://gerrit.ovirt.org/#/c/42032/18/packaging/setup/plugins/ovirt-engine-reports-tool/ovirt-engine-reports/jasper/export_saved_reports.py File packaging/setup/plugins/ovirt-engine-reports-tool/ovirt-engine-reports/jasper/export_saved_reports.py: Line 115: def _misc_export(self): Line 116: self._oreportsutil.set_jasper_name() Line 117: f = self.environment[oreportscons.ToolEnv.FILE] Line 118: self.logger.info(_('Exporting saved reports to {f}').format(f=f)) Line 119: self._oreportsutil.execute( > No need to check the exit code or catch an exception and provide a detailed reportsutil.execute filters some errors and raises an exception if any are still left. I think that's enough. Line 120: args=( Line 121: './js-export.sh', Line 122: '--uris', ( Line 123: '/organizations/organization_1/adhoc/aru' https://gerrit.ovirt.org/#/c/42032/18/packaging/setup/plugins/ovirt-engine-reports-tool/ovirt-engine-reports/jasper/import_saved_reports.py File packaging/setup/plugins/ovirt-engine-reports-tool/ovirt-engine-reports/jasper/import_saved_reports.py: Line 111: ) Line 112: def _misc_import(self): Line 113: f = self.environment[oreportscons.ToolEnv.FILE] Line 114: self.logger.info(_('Importing saved reports from {f}').format(f=f)) Line 115: self._oreportsutil.execute( > No need to check the exit code or catch an exception and provide a detailed same Line 116: args=( Line 117: './js-import.sh', Line 118: '--input-zip', f, Line 119: ) -- To view, visit https://gerrit.ovirt.org/42032 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ida41cf8e0fd04f2bfb0bfd655881625fa5a32cd9 Gerrit-PatchSet: 18 Gerrit-Project: ovirt-reports Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <d...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com> Gerrit-Reviewer: Shirly Radco <sra...@redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stira...@redhat.com> Gerrit-Reviewer: Yaniv Dary <yd...@redhat.com> Gerrit-Reviewer: Yedidyah Bar David <d...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
