Yedidyah Bar David has posted comments on this change. Change subject: services, setup: ovirt-vmconsole integration ......................................................................
Patch Set 51: (2 comments) https://gerrit.ovirt.org/#/c/35906/51/ovirt-engine.spec.in File ovirt-engine.spec.in: Line 611: %{ovirt_product_name_short} VMconsole Proxy helper, to integrate Line 612: with ovirt-vmconsole-proxy package Line 613: Line 614: %pre vmconsole-proxy-helper Line 615: %ovirt_create_user_engine shouldn't this be ovirt-vmconsole user/group? Line 616: Line 617: %package setup-plugin-vmconsole-proxy-helper Line 618: Summary: Setup and upgrade specific plugins for vmconsole-proxy-helper Line 619: Requires: %{name}-setup-plugin-ovirt-engine-common = %{version}-%{release} https://gerrit.ovirt.org/#/c/35906/51/packaging/setup/plugins/ovirt-engine-setup/vmconsole_proxy_helper/config.py File packaging/setup/plugins/ovirt-engine-setup/vmconsole_proxy_helper/config.py: Line 109: None Line 110: ) Line 111: self.environment.setdefault( Line 112: ovmpcons.EngineConfigEnv.ENGINE_FQDN, Line 113: 'localhost' Why localhost? If it's not None, getHostname won't ask Line 114: ) Line 115: Line 116: @plugin.event( Line 117: stage=plugin.Stages.STAGE_CUSTOMIZATION, -- To view, visit https://gerrit.ovirt.org/35906 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I034ef8e6d10da5dc93eda61e0c5c518ca13a5a28 Gerrit-PatchSet: 51 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vitor de Lima <vdel...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik <mpoled...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stira...@redhat.com> Gerrit-Reviewer: Vinzenz Feenstra <vfeen...@redhat.com> Gerrit-Reviewer: Vitor de Lima <vdel...@redhat.com> Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com> Gerrit-Reviewer: Yedidyah Bar David <d...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
