Yedidyah Bar David has posted comments on this change. Change subject: packaging: setup: pki: renew about to expire certificates ......................................................................
Patch Set 6: (1 comment) https://gerrit.ovirt.org/#/c/40330/6/packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/pki/ca.py File packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/pki/ca.py: Line 479: ], Line 480: }, Line 481: ) Line 482: Line 483: self._enrollCertificates(True, uninstall_files) Shouldn't this be inside the 'if expired'? You now enroll always. Line 484: Line 485: @plugin.event( Line 486: stage=plugin.Stages.STAGE_MISC, Line 487: name=oenginecons.Stages.CA_AVAILABLE, -- To view, visit https://gerrit.ovirt.org/40330 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6383b29e131d65cece96e298bb2c7fe6ae305afe Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com> Gerrit-Reviewer: Yedidyah Bar David <d...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
