Yedidyah Bar David has posted comments on this change. Change subject: pki: add pki-enroll-openssh-cert functionality ......................................................................
Patch Set 10: (1 comment) https://gerrit.ovirt.org/#/c/38094/10/packaging/bin/pki-enroll-openssh-cert.sh File packaging/bin/pki-enroll-openssh-cert.sh: Line 35: ssh-keygen \ Line 36: -s "${TMPCA}" \ Line 37: -I "${id}" \ Line 38: ${host:+-h} \ Line 39: -V "-1h:+${days}d" \ Did you check how this behaves with hosts and engine in different time zones? Perhaps s/-1h/-1d/ just in case? Line 40: ${principals:+-n "${principals}"} \ Line 41: $(echo -n "${options}" | xargs -ix -d',' echo -O x) \ Line 42: "${sshpub}" \ Line 43: || die "ssh-keygen failed" -- To view, visit https://gerrit.ovirt.org/38094 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ide34d4f0ffadf70e6ce42ae57328e262a832a3e4 Gerrit-PatchSet: 10 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Michal Skrivanek <michal.skriva...@redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com> Gerrit-Reviewer: Yedidyah Bar David <d...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
