[Engine-patches] Change in ovirt-hosted-engine-setup[master]: packaging: setup: more descriptive error message for invalid...

2015-06-10 Thread sbonazzo
Sandro Bonazzola has posted comments on this change. Change subject: packaging: setup: more descriptive error message for invalid storage domain .. Patch Set 2: please verify -- To view, visit https://gerrit.ovirt.org/41475

[Engine-patches] Change in ovirt-hosted-engine-setup[master]: packaging: setup: let the user configure the appliance vCPU ...

2015-06-10 Thread sbonazzo
Sandro Bonazzola has posted comments on this change. Change subject: packaging: setup: let the user configure the appliance vCPU value .. Patch Set 3: (1 comment) https://gerrit.ovirt.org/#/c/42158/3/src/plugins/ovirt-hosted-

[Engine-patches] Change in ovirt-hosted-engine-setup[master]: packaging: setup: more descriptive error message for invalid...

2015-06-10 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: packaging: setup: more descriptive error message for invalid storage domain .. Patch Set 2: * Update tracker::#1225011::OK * Check Bug-Url::OK * Check Pu

[Engine-patches] Change in ovirt-engine[master]: engine, webadmin : geo-rep status detail

2015-06-10 Thread sabose
Sahina Bose has posted comments on this change. Change subject: engine,webadmin : geo-rep status detail .. Patch Set 18: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/32100 To unsubscribe, visit https://gerrit.ovirt

[Engine-patches] Change in ovirt-hosted-engine-setup[master]: packaging: setup: add temp dir to answer file

2015-06-10 Thread sbonazzo
Sandro Bonazzola has posted comments on this change. Change subject: packaging: setup: add temp dir to answer file .. Patch Set 2: -Code-Review Well, maybe on the second host the tempdir specifed on the first host won't have e

[Engine-patches] Change in ovirt-hosted-engine-setup[master]: packaging: setup: add temp dir to answer file

2015-06-10 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: packaging: setup: add temp dir to answer file .. Patch Set 2: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sur

[Engine-patches] Change in ovirt-hosted-engine-setup[master]: packaging: setup: add temp dir to answer file

2015-06-10 Thread sbonazzo
Sandro Bonazzola has posted comments on this change. Change subject: packaging: setup: add temp dir to answer file .. Patch Set 1: Code-Review+1 Didi, any reason for not asking review on this? -- To view, visit https://gerrit

[Engine-patches] Change in ovirt-reports[master]: packaging: Add ovirt-engine-reports-tool

2015-06-10 Thread sbonazzo
Sandro Bonazzola has posted comments on this change. Change subject: packaging: Add ovirt-engine-reports-tool .. Patch Set 9: Code-Review+1 (1 comment) Code looks good to me, one minor inline comment. I don't know enough about

[Engine-patches] Change in ovirt-engine[master]: webadmin: change defaults in create brick popup

2015-06-10 Thread anbabu
anmolbabu has posted comments on this change. Change subject: webadmin: change defaults in create brick popup .. Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/42194 To unsubscribe, visit https://gerrit.

[Engine-patches] Change in ovirt-engine[master]: webadmin: Size info in GB along side % (2)

2015-06-10 Thread vvolansk
Vered Volansky has posted comments on this change. Change subject: webadmin: Size info in GB along side % (2) .. Patch Set 2: Because the information should change in accordance with typing new values in the percentage textbox

[Engine-patches] Change in ovirt-hosted-engine-setup[master]: Add two new recover commands to the hosted-engine tool

2015-06-10 Thread sbonazzo
Sandro Bonazzola has posted comments on this change. Change subject: Add two new recover commands to the hosted-engine tool .. Patch Set 4: Code-Review+1 Please verify -- To view, visit https://gerrit.ovirt.org/42093 To unsub

[Engine-patches] Change in ovirt-engine[master]: userportal, webadmin: removed duplicates

2015-06-10 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: userportal,webadmin: removed duplicates .. Patch Set 6: * Update tracker::#1200952::OK * Set MODIFIED::bug 1200952#1200952IGNORE, not oVirt prod b

[Engine-patches] Change in ovirt-engine[master]: userportal, webadmin: removed duplicates

2015-06-10 Thread tjelinek
Tomas Jelinek has submitted this change and it was merged. Change subject: userportal,webadmin: removed duplicates .. userportal,webadmin: removed duplicates • 2 duplicate anonymous IAsyncConverter class refactored to sole inne

[Engine-patches] Change in ovirt-engine[master]: webadmin: fix findbug

2015-06-10 Thread ahadas
Arik Hadas has abandoned this change. Change subject: webadmin: fix findbug .. Abandoned another fix was merged before -- To view, visit https://gerrit.ovirt.org/42190 To unsubscribe, visit https://gerrit.ovirt.org/settings

[Engine-patches] Change in ovirt-engine[master]: webadmin: fix findbug

2015-06-10 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: webadmin: fix findbug .. Patch Set 3: * Update tracker::IGNORE, no Bug-Url found -- To view, visit https://gerrit.ovirt.org/42190 To unsubscribe, visit

[Engine-patches] Change in ovirt-engine[ovirt-engine-3.5-gluster]: webadmin : Fix SizeUnit refactor build failures

2015-06-10 Thread kmayilsa
Kanagaraj M has submitted this change and it was merged. Change subject: webadmin : Fix SizeUnit refactor build failures .. webadmin : Fix SizeUnit refactor build failures This patch fixes the build failures introduced by the r

[Engine-patches] Change in ovirt-engine[ovirt-engine-3.5-gluster]: webadmin : Fix SizeUnit refactor build failures

2015-06-10 Thread kmayilsa
Kanagaraj M has posted comments on this change. Change subject: webadmin : Fix SizeUnit refactor build failures .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/42166 To unsubscribe, visit https://gerri

[Engine-patches] [oVirt Jenkins] ovirt-engine_master_gwt-admin_merged - Build # 9680 - Fixed!

2015-06-10 Thread jenkins
Project: http://jenkins.ovirt.org/job/ovirt-engine_master_gwt-admin_merged/ Build: http://jenkins.ovirt.org/job/ovirt-engine_master_gwt-admin_merged/9680/ Build Number: 9680 Build Status: Fixed Triggered By: Started by upstream project "ovirt-engine_master_gwt-user_merged" build number 4,811 --

[Engine-patches] Change in ovirt-engine[ovirt-engine-3.5-gluster]: webadmin: add showErrorDialog property to runMultipleAction

2015-06-10 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: webadmin: add showErrorDialog property to runMultipleAction .. Patch Set 1: * Update tracker::IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url

[Engine-patches] Change in ovirt-engine[ovirt-engine-3.5-gluster]: webadmin: add showErrorDialog property to runMultipleAction

2015-06-10 Thread kmayilsa
Kanagaraj M has submitted this change and it was merged. Change subject: webadmin: add showErrorDialog property to runMultipleAction .. webadmin: add showErrorDialog property to runMultipleAction The property will alow to contr

[Engine-patches] Change in ovirt-engine[ovirt-engine-3.5-gluster]: webadmin: add waitForResult property to runMultipleAction

2015-06-10 Thread kmayilsa
Kanagaraj M has submitted this change and it was merged. Change subject: webadmin: add waitForResult property to runMultipleAction .. webadmin: add waitForResult property to runMultipleAction The waitForResult property is a fla

[Engine-patches] Change in ovirt-engine[ovirt-engine-3.5-gluster]: webadmin: add waitForResult property to runMultipleAction

2015-06-10 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: webadmin: add waitForResult property to runMultipleAction .. Patch Set 1: * Update tracker::IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url fo

[Engine-patches] Change in ovirt-engine[ovirt-engine-3.5-gluster]: webadmin Add UI Error handling in rebalance and remove-brick

2015-06-10 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: webadmin Add UI Error handling in rebalance and remove-brick .. Patch Set 1: * Update tracker::#1042808::OK * Set MODIFIED::bug 1042808#1042808IGN

[Engine-patches] Change in ovirt-engine[ovirt-engine-3.5-gluster]: webadmin Add UI Error handling in rebalance and remove-brick

2015-06-10 Thread kmayilsa
Kanagaraj M has submitted this change and it was merged. Change subject: webadmin Add UI Error handling in rebalance and remove-brick .. webadmin Add UI Error handling in rebalance and remove-brick Add UI Error handling in reba

[Engine-patches] Change in ovirt-engine[ovirt-engine-3.5-gluster]: webadmin : Fix SizeUnit refactor build failures

2015-06-10 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: webadmin : Fix SizeUnit refactor build failures .. Patch Set 1: * Update tracker::IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url found. --

[Engine-patches] Change in ovirt-engine[master]: engine: Added new alerts for brick/volume status changes

2015-06-10 Thread kmayilsa
Kanagaraj M has submitted this change and it was merged. Change subject: engine: Added new alerts for brick/volume status changes .. engine: Added new alerts for brick/volume status changes adds new alerts for server/volume rem

[Engine-patches] Change in ovirt-engine[master]: engine: Added new alerts for brick/volume status changes

2015-06-10 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: engine: Added new alerts for brick/volume status changes .. Patch Set 8: * Update tracker::IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url fou

[Engine-patches] Change in ovirt-engine[master]: restapi: Introduction of new TimeZone Complex Type

2015-06-10 Thread vfeenstr
Vinzenz Feenstra has posted comments on this change. Change subject: restapi: Introduction of new TimeZone Complex Type .. Patch Set 1: (5 comments) https://gerrit.ovirt.org/#/c/42150/1/backend/manager/modules/restapi/interfac

[Engine-patches] Change in ovirt-engine[master]: core: Fix cascade delete with Job/Step

2015-06-10 Thread yzaspits
Yevgeny Zaspitsky has posted comments on this change. Change subject: core: Fix cascade delete with Job/Step .. Patch Set 6: (1 comment) https://gerrit.ovirt.org/#/c/41912/6/backend/manager/modules/bll/src/main/java/org/ovirt/

[Engine-patches] Change in ovirt-engine[master]: engine: Added new alerts for brick/volume status changes

2015-06-10 Thread kchidamb
Karnan t c has posted comments on this change. Change subject: engine: Added new alerts for brick/volume status changes .. Patch Set 7: Verified+1 -- To view, visit https://gerrit.ovirt.org/40566 To unsubscribe, visit https://

[Engine-patches] Change in ovirt-engine[master]: frontend: support for noVNC 0.5

2015-06-10 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: frontend: support for noVNC 0.5 .. Patch Set 3: * Update tracker::#1202356::OK * Check Bug-Url::OK * Check Public Bug::#1202356::OK, public bug * Check Pr

[Engine-patches] Change in ovirt-engine[ovirt-engine-3.5-gluster]: webadmin : Fix SizeUnit refactor build failures

2015-06-10 Thread anbabu
anmolbabu has posted comments on this change. Change subject: webadmin : Fix SizeUnit refactor build failures .. Patch Set 1: (1 comment) https://gerrit.ovirt.org/#/c/42166/1/frontend/webadmin/modules/webadmin/src/main/java/or

[Engine-patches] Change in ovirt-engine[master]: restapi: Introduction of new TimeZone Complex Type

2015-06-10 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: restapi: Introduction of new TimeZone Complex Type .. Patch Set 3: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, mak

[Engine-patches] Change in ovirt-engine[master]: restapi: Implementation for GuestOsInfo and Timezone reporting

2015-06-10 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: restapi: Implementation for GuestOsInfo and Timezone reporting .. Patch Set 5: * Update tracker::#869296::OK * Check Bug-Url::OK * Check Public Bug::#8692

[Engine-patches] Change in ovirt-engine[master]: webadmin: change defaults in create brick popup

2015-06-10 Thread rnachimu
Ramesh N has posted comments on this change. Change subject: webadmin: change defaults in create brick popup .. Patch Set 3: Verified+1 -- To view, visit https://gerrit.ovirt.org/42194 To unsubscribe, visit https://gerrit.ovir

[Engine-patches] [oVirt Jenkins] ovirt-engine_master_gwt-admin_merged - Build # 9679 - Failure!

2015-06-10 Thread jenkins
Project: http://jenkins.ovirt.org/job/ovirt-engine_master_gwt-admin_merged/ Build: http://jenkins.ovirt.org/job/ovirt-engine_master_gwt-admin_merged/9679/ Build Number: 9679 Build Status: Failure Triggered By: Started by upstream project "ovirt-engine_master_gwt-user_merged" build number 4,810

[Engine-patches] Change in ovirt-engine[master]: userportal, webadmin: removed duplicates

2015-06-10 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: userportal,webadmin: removed duplicates .. Patch Set 5: * Update tracker::#1200952::OK * Check Bug-Url::OK * Check Public Bug::#1200952::OK, public bug *

[Engine-patches] Change in ovirt-engine[master]: core: Fix cascade delete with Job/Step

2015-06-10 Thread lzelkha
Liran Zelkha has posted comments on this change. Change subject: core: Fix cascade delete with Job/Step .. Patch Set 5: (3 comments) https://gerrit.ovirt.org/#/c/41912/5/backend/manager/modules/bll/src/main/java/org/ovirt/engi

[Engine-patches] Change in ovirt-engine[master]: webadmin: change defaults in create brick popup

2015-06-10 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: webadmin: change defaults in create brick popup .. Patch Set 3: * Update tracker::#1228499::OK * Check Bug-Url::OK * Check Public Bug::#1228499::OK, publi

[Engine-patches] Change in ovirt-engine[master]: core: Fix cascade delete with Job/Step

2015-06-10 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: core: Fix cascade delete with Job/Step .. Patch Set 6: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure heade

[Engine-patches] Change in ovirt-engine[master]: webadmin: change defaults in create brick popup

2015-06-10 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: webadmin: change defaults in create brick popup .. Patch Set 2: * Update tracker::#1228499::OK * Check Bug-Url::OK * Check Public Bug::#1228499::OK, publi

[Engine-patches] Change in ovirt-engine[ovirt-engine-3.5-gluster]: webadmin Add UI Error handling in rebalance and remove-brick

2015-06-10 Thread kmayilsa
Kanagaraj M has posted comments on this change. Change subject: webadmin Add UI Error handling in rebalance and remove-brick .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/42188 To unsubscribe, visit

[Engine-patches] Change in ovirt-engine[ovirt-engine-3.5-gluster]: webadmin: add waitForResult property to runMultipleAction

2015-06-10 Thread kmayilsa
Kanagaraj M has posted comments on this change. Change subject: webadmin: add waitForResult property to runMultipleAction .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/42187 To unsubscribe, visit htt

[Engine-patches] Change in ovirt-engine[ovirt-engine-3.5-gluster]: webadmin: add showErrorDialog property to runMultipleAction

2015-06-10 Thread kmayilsa
Kanagaraj M has posted comments on this change. Change subject: webadmin: add showErrorDialog property to runMultipleAction .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/42186 To unsubscribe, visit h

[Engine-patches] Change in ovirt-engine[master]: engine: Added new alerts for brick/volume status changes

2015-06-10 Thread sabose
Sahina Bose has posted comments on this change. Change subject: engine: Added new alerts for brick/volume status changes .. Patch Set 7: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/40566 To unsubscribe, visit http

[Engine-patches] Change in ovirt-engine[master]: webadmin: fix findbug

2015-06-10 Thread ofrenkel
Omer Frenkel has posted comments on this change. Change subject: webadmin: fix findbug .. Patch Set 3: already fixed by https://gerrit.ovirt.org/#/c/42165 -- To view, visit https://gerrit.ovirt.org/42190 To unsubscribe, visit

[Engine-patches] Change in ovirt-engine[ovirt-engine-3.5-gluster]: webadmin: add showErrorDialog property to runMultipleAction

2015-06-10 Thread anbabu
anmolbabu has posted comments on this change. Change subject: webadmin: add showErrorDialog property to runMultipleAction .. Patch Set 1: Verified+1 -- To view, visit https://gerrit.ovirt.org/42186 To unsubscribe, visit https:

[Engine-patches] Change in ovirt-engine[master]: webadmin: fix findbug

2015-06-10 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: webadmin: fix findbug .. Patch Set 3: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Ur

[Engine-patches] Change in ovirt-engine[ovirt-engine-3.5-gluster]: webadmin: add waitForResult property to runMultipleAction

2015-06-10 Thread anbabu
anmolbabu has posted comments on this change. Change subject: webadmin: add waitForResult property to runMultipleAction .. Patch Set 1: Verified+1 -- To view, visit https://gerrit.ovirt.org/42187 To unsubscribe, visit https://

[Engine-patches] Change in ovirt-engine[ovirt-engine-3.5-gluster]: webadmin Add UI Error handling in rebalance and remove-brick

2015-06-10 Thread anbabu
anmolbabu has posted comments on this change. Change subject: webadmin Add UI Error handling in rebalance and remove-brick .. Patch Set 1: Verified+1 -- To view, visit https://gerrit.ovirt.org/42188 To unsubscribe, visit https

[Engine-patches] Change in ovirt-engine[ovirt-engine-3.5-gluster]: webadmin : Fix SizeUnit refactor build failures

2015-06-10 Thread sabose
Sahina Bose has posted comments on this change. Change subject: webadmin : Fix SizeUnit refactor build failures .. Patch Set 1: Code-Review+1 (1 comment) minor comment https://gerrit.ovirt.org/#/c/42166/1/frontend/webadmin/mo

[Engine-patches] Change in ovirt-engine[master]: engine: Added new alerts for brick/volume status changes

2015-06-10 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: engine: Added new alerts for brick/volume status changes .. Patch Set 7: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url foun

[Engine-patches] Change in ovirt-engine[master]: webadmin: removing redundant check

2015-06-10 Thread alkaplan
Alona Kaplan has posted comments on this change. Change subject: webadmin: removing redundant check .. Patch Set 1: Code-Review+2 Verified+1 -- To view, visit https://gerrit.ovirt.org/42165 To unsubscribe, visit https://gerrit

[Engine-patches] Change in ovirt-engine[master]: webadmin: removing redundant check

2015-06-10 Thread alkaplan
Alona Kaplan has submitted this change and it was merged. Change subject: webadmin: removing redundant check .. webadmin: removing redundant check Findbugs complain about the test, as it will always be true if the object is not

[Engine-patches] Change in ovirt-engine[master]: webadmin: removing redundant check

2015-06-10 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: webadmin: removing redundant check .. Patch Set 2: * Update tracker::IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url found. -- To view, visi

[Engine-patches] Change in ovirt-engine[master]: webadmin: removing redundant check

2015-06-10 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: webadmin: removing redundant check .. Patch Set 2: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header ma

[Engine-patches] Change in ovirt-engine[master]: gluster: Corrected geo-rep case of volume snapshot creation

2015-06-10 Thread shtripat
Shubhendu Tripathi has posted comments on this change. Change subject: gluster: Corrected geo-rep case of volume snapshot creation .. Patch Set 1: (1 comment) https://gerrit.ovirt.org/#/c/41491/1/backend/manager/modules/bll/sr

[Engine-patches] Change in ovirt-engine[master]: core: introduce libvirt_secrets table

2015-06-10 Thread mlipchuk
Maor Lipchuk has posted comments on this change. Change subject: core: introduce libvirt_secrets table .. Patch Set 6: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/41550 To unsubscribe, visit https://gerrit.ovirt.o

[Engine-patches] Change in ovirt-engine[master]: core: introduce LibvirtSecretDao

2015-06-10 Thread mlipchuk
Maor Lipchuk has posted comments on this change. Change subject: core: introduce LibvirtSecretDao .. Patch Set 7: (1 comment) https://gerrit.ovirt.org/#/c/41551/7/backend/manager/modules/dal/src/main/java/org/ovirt/engine/core

[Engine-patches] Change in ovirt-engine[master]: core: added LibvirtSecretDao to DbFacade

2015-06-10 Thread mlipchuk
Maor Lipchuk has posted comments on this change. Change subject: core: added LibvirtSecretDao to DbFacade .. Patch Set 7: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/41552 To unsubscribe, visit https://gerrit.ovir

[Engine-patches] Change in ovirt-engine[master]: core: GetLibvirtSecretByIdQuery

2015-06-10 Thread mlipchuk
Maor Lipchuk has posted comments on this change. Change subject: core: GetLibvirtSecretByIdQuery .. Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/41968 To unsubscribe, visit https://gerrit.ovirt.org/set

[Engine-patches] Change in ovirt-engine[master]: gluster: Corrected event log messages

2015-06-10 Thread rnachimu
Ramesh N has posted comments on this change. Change subject: gluster: Corrected event log messages .. Patch Set 1: Code-Review+1 Verified+1 -- To view, visit https://gerrit.ovirt.org/42192 To unsubscribe, visit https://gerrit.

[Engine-patches] Change in ovirt-engine[master]: webadmin: change defaults in create brick popup

2015-06-10 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: webadmin: change defaults in create brick popup .. Patch Set 1: * Update tracker::#1228499::OK * Check Bug-Url::OK * Check Public Bug::#1228499::OK, publi

[Engine-patches] Change in ovirt-engine[master]: webadmin: change defaults in create brick popup

2015-06-10 Thread rnachimu
Ramesh N has uploaded a new change for review. Change subject: webadmin: change defaults in create brick popup .. webadmin: change defaults in create brick popup Change the default RAID type and stripe size used in Create Brick

[Engine-patches] Change in ovirt-engine[master]: core: added CRUD commands for LibvirtSecrets

2015-06-10 Thread mlipchuk
Maor Lipchuk has posted comments on this change. Change subject: core: added CRUD commands for LibvirtSecrets .. Patch Set 9: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/41555 To unsubscribe, visit https://gerrit.

[Engine-patches] Change in ovirt-engine[master]: core: Make VDS a JPA entity

2015-06-10 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: core: Make VDS a JPA entity .. Patch Set 55: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches

[Engine-patches] Change in ovirt-engine[master]: core: add RegisterLibvritSecretsVdsCommand

2015-06-10 Thread mlipchuk
Maor Lipchuk has posted comments on this change. Change subject: core: add RegisterLibvritSecretsVdsCommand .. Patch Set 9: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/41557 To unsubscribe, visit https://gerrit.ov

[Engine-patches] Change in ovirt-engine[master]: core: register secrets on connect storage domain

2015-06-10 Thread mlipchuk
Maor Lipchuk has posted comments on this change. Change subject: core: register secrets on connect storage domain .. Patch Set 9: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/41558 To unsubscribe, visit https://ger

[Engine-patches] Change in ovirt-engine[master]: core: unregister secrets on deactivate Cinder storage domain

2015-06-10 Thread mlipchuk
Maor Lipchuk has posted comments on this change. Change subject: core: unregister secrets on deactivate Cinder storage domain .. Patch Set 9: (2 comments) https://gerrit.ovirt.org/#/c/41560/9/backend/manager/modules/bll/src/ma

[Engine-patches] Change in ovirt-engine[master]: gluster: Confirmation dialog for removing a volume snapshot ...

2015-06-10 Thread kmayilsa
Kanagaraj M has submitted this change and it was merged. Change subject: gluster: Confirmation dialog for removing a volume snapshot schedule .. gluster: Confirmation dialog for removing a volume snapshot schedule Introduced a

[Engine-patches] Change in ovirt-engine[master]: gluster: Confirmation dialog for removing a volume snapshot ...

2015-06-10 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: gluster: Confirmation dialog for removing a volume snapshot schedule .. Patch Set 3: * Update tracker::#1226129::OK * Set MODIFIED::bug 1226129#12261

[Engine-patches] Change in ovirt-engine[master]: engine, webadmin : geo-rep status detail

2015-06-10 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: engine,webadmin : geo-rep status detail .. Patch Set 18: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure hea

[Engine-patches] Change in ovirt-engine[master]: webadmin: fix findbug

2015-06-10 Thread ahadas
Arik Hadas has posted comments on this change. Change subject: webadmin: fix findbug .. Patch Set 2: Verified+1 -- To view, visit https://gerrit.ovirt.org/42190 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-M

[Engine-patches] Change in ovirt-engine[master]: webadmin: fix findbug

2015-06-10 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: webadmin: fix findbug .. Patch Set 2: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Ur

[Engine-patches] Change in ovirt-engine[master]: core: registerLibvirtSecrets on add and update secret

2015-06-10 Thread mlipchuk
Maor Lipchuk has posted comments on this change. Change subject: core: registerLibvirtSecrets on add and update secret .. Patch Set 9: Code-Review+1 (4 comments) https://gerrit.ovirt.org/#/c/41561/9/backend/manager/modules/bll

[Engine-patches] Change in ovirt-engine[master]: gluster: Confirmation dialog for removing a volume snapshot ...

2015-06-10 Thread kmayilsa
Kanagaraj M has posted comments on this change. Change subject: gluster: Confirmation dialog for removing a volume snapshot schedule .. Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/41851 To unsubscrib

[Engine-patches] Change in ovirt-engine[master]: core: unregisterLibvirtSecrets on remove

2015-06-10 Thread mlipchuk
Maor Lipchuk has posted comments on this change. Change subject: core: unregisterLibvirtSecrets on remove .. Patch Set 9: Code-Review+2 (1 comment) https://gerrit.ovirt.org/#/c/41562/9/backend/manager/modules/bll/src/main/java

[Engine-patches] Change in ovirt-engine[master]: gluster: Confirmation dialog for removing a volume snapshot ...

2015-06-10 Thread shtripat
Shubhendu Tripathi has posted comments on this change. Change subject: gluster: Confirmation dialog for removing a volume snapshot schedule .. Patch Set 3: Verified+1 -- To view, visit https://gerrit.ovirt.org/41851 To unsubs

[Engine-patches] Change in ovirt-engine[master]: gluster: Confirmation dialog for removing a volume snapshot ...

2015-06-10 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: gluster: Confirmation dialog for removing a volume snapshot schedule .. Patch Set 3: * Update tracker::#1226129::OK * Check Bug-Url::OK * Check Public Bu

[Engine-patches] Change in ovirt-engine[master]: core: unregisterLibvirtSecrets on remove

2015-06-10 Thread mlipchuk
Maor Lipchuk has posted comments on this change. Change subject: core: unregisterLibvirtSecrets on remove .. Patch Set 9: -Code-Review (1 comment) https://gerrit.ovirt.org/#/c/41562/9/backend/manager/modules/bll/src/main/java/

[Engine-patches] Change in ovirt-engine[master]: gluster: Corrected event log messages

2015-06-10 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: gluster: Corrected event log messages .. Patch Set 1: * Update tracker::#1228208::OK * Check Bug-Url::OK * Check Public Bug::#1228208::OK, public bug * Ch

[Engine-patches] Change in ovirt-engine[master]: gluster: Corrected event log messages

2015-06-10 Thread shtripat
Shubhendu Tripathi has uploaded a new change for review. Change subject: gluster: Corrected event log messages .. gluster: Corrected event log messages Corrected event log messages while creation of bricks to add host name and c

[Engine-patches] Change in ovirt-engine[master]: core: unregisterLibvirtSecrets on remove

2015-06-10 Thread mlipchuk
Maor Lipchuk has posted comments on this change. Change subject: core: unregisterLibvirtSecrets on remove .. Patch Set 9: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/41562 To unsubscribe, visit https://gerrit.ovir

[Engine-patches] Change in ovirt-engine[master]: restapi: CRUD for OpenStackVolume authentication keys

2015-06-10 Thread mlipchuk
Maor Lipchuk has posted comments on this change. Change subject: restapi: CRUD for OpenStackVolume authentication keys .. Patch Set 4: Code-Review+1 looks good to me, +2 will be given by REST maintainer -- To view, visit http

[Engine-patches] Change in ovirt-engine[master]: core: LibvirtSecretDaoTest

2015-06-10 Thread mlipchuk
Maor Lipchuk has posted comments on this change. Change subject: core: LibvirtSecretDaoTest .. Patch Set 5: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/41640 To unsubscribe, visit https://gerrit.ovirt.org/settings

[Engine-patches] Change in ovirt-engine[master]: core: support cephx authentication on run vm

2015-06-10 Thread mlipchuk
Maor Lipchuk has posted comments on this change. Change subject: core: support cephx authentication on run vm .. Patch Set 9: Code-Review+1 (1 comment) https://gerrit.ovirt.org/#/c/41566/9/backend/manager/modules/vdsbroker/src

[Engine-patches] Change in ovirt-engine[master]: gluster: Confirmation dialog for removing a volume snapshot ...

2015-06-10 Thread shtripat
Shubhendu Tripathi has posted comments on this change. Change subject: gluster: Confirmation dialog for removing a volume snapshot schedule .. Patch Set 2: (4 comments) https://gerrit.ovirt.org/#/c/41851/2/frontend/webadmin/m

[Engine-patches] Change in ovirt-engine[master]: core: unregister secrets on DisconnectHostFromStoragePoolSer...

2015-06-10 Thread mlipchuk
Maor Lipchuk has posted comments on this change. Change subject: core: unregister secrets on DisconnectHostFromStoragePoolServersCommand .. Patch Set 9: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/41565 To unsubs

[Engine-patches] Change in ovirt-engine[master]: core: register secrets on ConnectHostToStoragePoolServersCom...

2015-06-10 Thread mlipchuk
Maor Lipchuk has posted comments on this change. Change subject: core: register secrets on ConnectHostToStoragePoolServersCommand .. Patch Set 9: (2 comments) https://gerrit.ovirt.org/#/c/41564/9/backend/manager/modules/bll/sr

[Engine-patches] Change in ovirt-engine[master]: gluster: Confirmation dialog for removing a volume snapshot ...

2015-06-10 Thread kmayilsa
Kanagaraj M has posted comments on this change. Change subject: gluster: Confirmation dialog for removing a volume snapshot schedule .. Patch Set 2: (4 comments) https://gerrit.ovirt.org/#/c/41851/2/frontend/webadmin/modules/

[Engine-patches] Change in ovirt-engine[master]: webadmin : Show confirmation for geo-rep actions

2015-06-10 Thread kmayilsa
Kanagaraj M has posted comments on this change. Change subject: webadmin : Show confirmation for geo-rep actions .. Patch Set 2: (4 comments) https://gerrit.ovirt.org/#/c/41901/2/frontend/webadmin/modules/uicommonweb/src/main/

[Engine-patches] Change in ovirt-engine[master]: core: getAllByStoragePoolIdFilteredByActiveStorageDomains

2015-06-10 Thread mlipchuk
Maor Lipchuk has posted comments on this change. Change subject: core: getAllByStoragePoolIdFilteredByActiveStorageDomains .. Patch Set 9: (1 comment) looks that the stored procedure in the DAO is different from the Stored Pr

[Engine-patches] Change in ovirt-engine[master]: core: Change method access modifier to public for auditlog.

2015-06-10 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: core: Change method access modifier to public for auditlog. .. Patch Set 3: * Update tracker::#1185826::OK * Set MODIFIED::bug 1185826#1185826IGNO

[Engine-patches] Change in ovirt-engine[master]: core: Change method access modifier to public for auditlog.

2015-06-10 Thread mlipchuk
Maor Lipchuk has submitted this change and it was merged. Change subject: core: Change method access modifier to public for auditlog. .. core: Change method access modifier to public for auditlog. Change the access modifier of

[Engine-patches] Change in ovirt-engine[master]: webadmin: fix findbug

2015-06-10 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: webadmin: fix findbug .. Patch Set 1: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Ur

[Engine-patches] Change in ovirt-engine[master]: webadmin: support import from VMware

2015-06-10 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: webadmin: support import from VMware .. Patch Set 122: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure heade

[Engine-patches] Change in ovirt-engine[master]: webadmin: os selection for import from VMware

2015-06-10 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: webadmin: os selection for import from VMware .. Patch Set 50: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make su

[Engine-patches] Change in ovirt-engine[master]: webadmin: fix findbug

2015-06-10 Thread ahadas
Arik Hadas has uploaded a new change for review. Change subject: webadmin: fix findbug .. webadmin: fix findbug Fix BC_VACUOUS_INSTANCEOF error. Change-Id: I05d675633c1760398e77b8480f00d0a33d2e71d9 Signed-off-by: Arik Hadas --

[Engine-patches] Change in ovirt-engine[master]: core: added support for version check for remote-viewer

2015-06-10 Thread ahadas
Arik Hadas has posted comments on this change. Change subject: core: added support for version check for remote-viewer .. Patch Set 6: (1 comment) https://gerrit.ovirt.org/#/c/41879/6/packaging/dbscripts/upgrade/pre_upgrade/00

[Engine-patches] Change in ovirt-engine[master]: core[DB]: Adding external status to DB

2015-06-10 Thread amureini
Allon Mureinik has posted comments on this change. Change subject: core[DB]: Adding external status to DB .. Patch Set 1: (2 comments) https://gerrit.ovirt.org/#/c/42132/1/packaging/dbscripts/create_views.sql File packaging/db

  1   2   3   4   5   6   7   8   9   10   >