Sandro Bonazzola has posted comments on this change.

Change subject: packaging: setup: let the user configure the appliance vCPU 
value
......................................................................


Patch Set 3:

(1 comment)

https://gerrit.ovirt.org/#/c/42158/3/src/plugins/ovirt-hosted-engine-setup/vm/cpu.py
File src/plugins/ovirt-hosted-engine-setup/vm/cpu.py:

Line 110:                         '[Defaults to {default_msg}: @DEFAULT@]: '
Line 111:                     ),
Line 112:                     prompt=True,
Line 113:                     default=default,
Line 114:                     default_msg=default_msg,
Have you checked if this works?
Line 115:                 )
Line 116:             try:
Line 117:                 valid = True
Line 118:                 if int(


-- 
To view, visit https://gerrit.ovirt.org/42158
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iee514e9066d69852a60e606a93f6a59e23e26c87
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-hosted-engine-setup
Gerrit-Branch: master
Gerrit-Owner: Simone Tiraboschi <stira...@redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Lev Veyde <lve...@redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <d...@redhat.com>
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to