Maor Lipchuk has posted comments on this change. Change subject: core: unregister secrets on deactivate Cinder storage domain ......................................................................
Patch Set 9: (2 comments) https://gerrit.ovirt.org/#/c/41560/9/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/CINDERStorageHelper.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/CINDERStorageHelper.java: Line 109: } catch (RuntimeException e) { Line 110: log.error("Failed to unregister libvirt secret for storage domain {} on vds {}. Error: {}", Line 111: storageDomain.getName(), vds.getName(), e.getMessage()); Line 112: log.debug("Exception", e); Line 113: return false; Why not adding audit log here also Line 114: } Line 115: if (!returnValue.getSucceeded()) { Line 116: addMessageToAuditLog(AuditLogType.FAILED_TO_UNREGISTER_LIBVIRT_SECRET, Line 117: storageDomain.getName(), vds.getName()); https://gerrit.ovirt.org/#/c/41560/9/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/StorageDomainCommandBase.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/StorageDomainCommandBase.java: Line 345: try { Line 346: boolean connectResult = StorageHelperDirector.getInstance().getItem(getStorageDomain().getStorageType()) Line 347: .disconnectStorageFromDomainByVdsId(getStorageDomain(), vds.getId()); Line 348: toReturn.setSecond(connectResult); Line 349: } catch (RuntimeException e) { You already use try/catch at disconnectStorageFromDomainByVdsId, there is not reason to use it also here, you will need to check the connectResult instead. Suggestion: you are already logging this at disconnectStorageFromDomainByVdsId, either is the log only there or leave it here Line 350: log.error("Failed to disconnect host '{}' to storage domain (name '{}', id '{}'): {}", Line 351: vds.getName(), Line 352: getStorageDomain().getName(), Line 353: getStorageDomain().getId(), -- To view, visit https://gerrit.ovirt.org/41560 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5cbe774859e5bc159300b21d0ea91a92ea9ff1cf Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
