Maor Lipchuk has posted comments on this change. Change subject: core: support cephx authentication on run vm ......................................................................
Patch Set 9: Code-Review+1 (1 comment) https://gerrit.ovirt.org/#/c/41566/9/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VmInfoBuilder.java File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VmInfoBuilder.java: Line 443: Line 444: boolean authEnabled = (boolean) cinderDisk.getCinderConnectionInfo().getData().get("auth_enabled"); Line 445: String secretType = (String) cinderDisk.getCinderConnectionInfo().getData().get("secret_type"); Line 446: String authUsername = (String) cinderDisk.getCinderConnectionInfo().getData().get("auth_username"); Line 447: String secretUuid = (String) cinderDisk.getCinderConnectionInfo().getData().get("secret_uuid"); Constants could be nice here Line 448: if (authEnabled) { Line 449: Map<String, Object> authMap = new HashMap<>(); Line 450: authMap.put(VdsProperties.NetworkDiskAuthSecretType, secretType); Line 451: authMap.put(VdsProperties.NetworkDiskAuthUsername, authUsername); -- To view, visit https://gerrit.ovirt.org/41566 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I38ec477991a5b6e1f1ebb444a87f40de445d4ef1 Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
