Yevgeny Zaspitsky has posted comments on this change. Change subject: core: Fix cascade delete with Job/Step ......................................................................
Patch Set 6: (1 comment) https://gerrit.ovirt.org/#/c/41912/6/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/job/JobRepositoryImpl.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/job/JobRepositoryImpl.java: Line 113: return job; Line 114: } Line 115: Line 116: @Override Line 117: public Job getJobWithSteps(final Guid jobId) { Looks like this method is exact copy of getJob one. Please remove it and replace the usages with getJob Line 118: Job job = jobDao.get(jobId); Line 119: if (job != null) { Line 120: Map<Guid, VdcObjectType> jobSubjectEntity = Line 121: jobSubjectEntityDao.getJobSubjectEntityByJobId(jobId); -- To view, visit https://gerrit.ovirt.org/41912 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I53021c91c138059816e58c4f25bb2851f6c29800 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liran Zelkha <lzel...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liran Zelkha <lzel...@redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzasp...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
