Sandro Bonazzola has posted comments on this change. Change subject: packaging: Add ovirt-engine-reports-tool ......................................................................
Patch Set 9: Code-Review+1 (1 comment) Code looks good to me, one minor inline comment. I don't know enough about Jasper to tell if it will work as expected. https://gerrit.ovirt.org/#/c/42032/9/packaging/setup/bin/ovirt-engine-reports-tool.sh File packaging/setup/bin/ovirt-engine-reports-tool.sh: Line 15: # See the License for the specific language governing permissions and Line 16: # limitations under the License. Line 17: # Line 18: Line 19: die() { trailing space Line 20: local m="$1" Line 21: echo "FATAL: ${m}" >&2 Line 22: exit 1 Line 23: } -- To view, visit https://gerrit.ovirt.org/42032 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ida41cf8e0fd04f2bfb0bfd655881625fa5a32cd9 Gerrit-PatchSet: 9 Gerrit-Project: ovirt-reports Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <d...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
