Kanagaraj M has posted comments on this change. Change subject: webadmin : Show confirmation for geo-rep actions ......................................................................
Patch Set 2: (4 comments) https://gerrit.ovirt.org/#/c/41901/2/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/gluster/VolumeGeoRepListModel.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/gluster/VolumeGeoRepListModel.java: Line 533: setMessage setActionConfirmationText/setActionConfirmationMessage https://gerrit.ovirt.org/#/c/41901/2/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/popup/gluster/GlusterVolumeGeoRepActionConfirmPopUpViewPresenterWidget.java File frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/popup/gluster/GlusterVolumeGeoRepActionConfirmPopUpViewPresenterWidget.java: Line 32: messageSet ActionConfirmationText/ActionConfirmationMessage https://gerrit.ovirt.org/#/c/41901/2/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/gluster/GeoRepActionConfirmPopUpView.java File frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/gluster/GeoRepActionConfirmPopUpView.java: Line 143: setMessage setMessage is typically used to set error or info messages. Here it is used to set the actionConfirmation text. I would like to have different function named setActionConfirmationText/setActionConfirmationMessage which does this job. https://gerrit.ovirt.org/#/c/41901/2/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/gluster/GeoRepActionConfirmPopUpView.ui.xml File frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/gluster/GeoRepActionConfirmPopUpView.ui.xml: Line 27: Line 28: <d:SimpleDialogPanel width="480px" height="300px"> Line 29: <d:content> Line 30: <g:FlowPanel> Line 31: <g:Label ui:field="messageLabel" addStyleNames="{style.messageLabel}" /> Rename this to actionConfirmationText/actionConfirmationMessage Line 32: <ge:StringEntityModelLabelEditor ui:field="masterVolumeEditor" /> Line 33: <ge:StringEntityModelLabelEditor ui:field="slaveVolumeEditor" /> Line 34: <ge:StringEntityModelLabelEditor ui:field="slaveHostEditor" /> Line 35: <g:HorizontalPanel> -- To view, visit https://gerrit.ovirt.org/41901 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I319072213021cfd130b4521c0b77e5e4ab9cb1fe Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: anmolbabu <anb...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Kanagaraj M <kmayi...@redhat.com> Gerrit-Reviewer: Ramesh N <rnach...@redhat.com> Gerrit-Reviewer: anmolbabu <anb...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
