[Engine-patches] Change in ovirt-reports[ovirt-engine-reports-3.5]: packaging: spec: add support for EL7 builds

2014-11-06 Thread sbonazzo
Sandro Bonazzola has posted comments on this change. Change subject: packaging: spec: add support for EL7 builds .. Patch Set 1: Verified+1 Verified building -- To view, visit http://gerrit.ovirt.org/34914 To unsubscribe, vis

[Engine-patches] Change in ovirt-reports[ovirt-engine-reports-3.5]: packaging: spec: add support for EL7 builds

2014-11-06 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: packaging: spec: add support for EL7 builds .. Patch Set 1: * Update tracker::#1159293::OK -- To view, visit http://gerrit.ovirt.org/34914 To unsubscrib

[Engine-patches] Change in ovirt-reports[ovirt-engine-reports-3.5]: packaging: spec: add support for EL7 builds

2014-11-06 Thread sbonazzo
Sandro Bonazzola has uploaded a new change for review. Change subject: packaging: spec: add support for EL7 builds .. packaging: spec: add support for EL7 builds - add support for EL7 builds - avoid to require both java and java

[Engine-patches] Change in ovirt-reports[master]: packaging: spec: add support for EL7 builds

2014-11-06 Thread sbonazzo
Sandro Bonazzola has posted comments on this change. Change subject: packaging: spec: add support for EL7 builds .. Patch Set 1: Verified+1 Verified building. -- To view, visit http://gerrit.ovirt.org/34913 To unsubscribe, vi

[Engine-patches] Change in ovirt-reports[master]: packaging: spec: add support for EL7 builds

2014-11-06 Thread sbonazzo
Sandro Bonazzola has uploaded a new change for review. Change subject: packaging: spec: add support for EL7 builds .. packaging: spec: add support for EL7 builds - add support for EL7 builds - avoid to require both java and java

[Engine-patches] Change in ovirt-reports[master]: packaging: spec: add support for EL7 builds

2014-11-06 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: packaging: spec: add support for EL7 builds .. Patch Set 1: * Update tracker::#1159293::OK -- To view, visit http://gerrit.ovirt.org/34913 To unsubscrib

[Engine-patches] Change in ovirt-engine[ovirt-engine-3.5]: packaging: spec: workaround for spice-html5 missin in EL7

2014-11-06 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: packaging: spec: workaround for spice-html5 missin in EL7 .. Patch Set 1: * Update tracker::#1159293::OK -- To view, visit http://gerrit.ovirt.org/34876

[Engine-patches] Change in ovirt-engine[ovirt-engine-3.5]: packaging: spec: workaround for spice-html5 missin in EL7

2014-11-06 Thread sbonazzo
Sandro Bonazzola has abandoned this change. Change subject: packaging: spec: workaround for spice-html5 missin in EL7 .. Abandoned spice-html5 has been built in epel7 koji[1], it shouldn't take too much before it will be avail

[Engine-patches] Change in ovirt-engine[master]: packaging: spec: workaround for spice-html5 missin in EL7

2014-11-06 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: packaging: spec: workaround for spice-html5 missin in EL7 .. Patch Set 1: * Update tracker::#1159293::OK -- To view, visit http://gerrit.ovirt.org/34862

[Engine-patches] Change in ovirt-engine[master]: packaging: spec: workaround for spice-html5 missin in EL7

2014-11-06 Thread sbonazzo
Sandro Bonazzola has abandoned this change. Change subject: packaging: spec: workaround for spice-html5 missin in EL7 .. Abandoned spice-html5 has been built in epel7 koji[1], it shouldn't take too much before it will be avail

[Engine-patches] Change in ovirt-engine[ovirt-engine-3.5]: aaa: provide UI error for builtin krbldap

2014-11-06 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: aaa: provide UI error for builtin krbldap .. Patch Set 2: Build Successful http://jenkins.ovirt.org/job/ovirt-engine_3.5_unit_tests_gerrit/1640/ : SU

[Engine-patches] Change in ovirt-engine[master]: jsonrpc: version bump

2014-11-06 Thread sbonazzo
Sandro Bonazzola has posted comments on this change. Change subject: jsonrpc: version bump .. Patch Set 2: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/34878 To unsubscribe, visit http://gerrit.ovirt.org/settings G

[Engine-patches] Change in ovirt-hosted-engine-setup[master]: packaging: setup: enforcing required networks configuration ...

2014-11-06 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: packaging: setup: enforcing required networks configuration additional hosts .. Patch Set 4: Build Successful http://jenkins.ovirt.org/job/ovirt-hos

[Engine-patches] Change in ovirt-scheduler-proxy[master]: packaging: spec: add support for EL7 builds

2014-11-06 Thread sbonazzo
Sandro Bonazzola has posted comments on this change. Change subject: packaging: spec: add support for EL7 builds .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.ovirt.org/34899 To unsubscribe, visit http://gerrit.ov

[Engine-patches] Change in ovirt-engine[master]: Fix typo for 'timeout'

2014-11-06 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: Fix typo for 'timeout' .. Patch Set 2: * Update tracker::IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url found. -- To view, visit http://ger

[Engine-patches] Change in ovirt-engine[master]: Fix typo for 'timeout'

2014-11-06 Thread sbonazzo
Sandro Bonazzola has submitted this change and it was merged. Change subject: Fix typo for 'timeout' .. Fix typo for 'timeout' Change-Id: I8a8205dcac7453eebb6705e5de3d3862122e8f1e Signed-off-by: Pablo Iranzo Gómez --- M backe

[Engine-patches] Change in ovirt-engine[master]: Fix typo for 'timeout'

2014-11-06 Thread sbonazzo
Sandro Bonazzola has posted comments on this change. Change subject: Fix typo for 'timeout' .. Patch Set 1: Code-Review+2 I hope maintainer won't comply, it's just a text change in a log file. Merging. -- To view, visit http:

[Engine-patches] Change in ovirt-hosted-engine-setup[master]: packaging: setup: enforcing required networks configuration ...

2014-11-06 Thread sbonazzo
Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: setup: enforcing required networks configuration additional hosts .. packaging: setup: enforcing required networks configuration additiona

[Engine-patches] Change in ovirt-hosted-engine-setup[master]: packaging: setup: enforcing required networks configuration ...

2014-11-06 Thread sbonazzo
Sandro Bonazzola has posted comments on this change. Change subject: packaging: setup: enforcing required networks configuration additional hosts .. Patch Set 4: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/34789 T

[Engine-patches] Change in ovirt-hosted-engine-setup[master]: packaging: setup: enforcing required networks configuration ...

2014-11-06 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: packaging: setup: enforcing required networks configuration additional hosts .. Patch Set 4: * Update tracker::#1086032::OK -- To view, visit http://ge

[Engine-patches] Change in ovirt-engine[ovirt-engine-3.5]: aaa: provide UI error for builtin krbldap

2014-11-06 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: aaa: provide UI error for builtin krbldap .. Patch Set 2: * Update tracker::#1106435::OK * Check Bug-Url::OK * Check Public Bug::#1106435::OK, public bug

[Engine-patches] Change in ovirt-engine[master]: core: Allow multiple alerts of the same type for host

2014-11-06 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: core: Allow multiple alerts of the same type for host .. Patch Set 3: Build Failed http://jenkins.ovirt.org/job/ovirt-engine_master_create-rpms-quick

[Engine-patches] Change in ovirt-engine[master]: engine : CommandBase should not set end status for commands ...

2014-11-06 Thread gpadgett
Greg Padgett has posted comments on this change. Change subject: engine : CommandBase should not set end status for commands with callback .. Patch Set 1: Verified+1 Code-Review+1 Thanks Ravi, looks good and helps solve the pr

[Engine-patches] Change in ovirt-engine[ovirt-engine-3.5]: aaa: provide UI error for builtin krbldap

2014-11-06 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: aaa: provide UI error for builtin krbldap .. Patch Set 1: Code-Review-1 Verified-1 Build Failed http://jenkins.ovirt.org/job/ovirt-engine_3.5_unit_te

[Engine-patches] Change in ovirt-engine[ovirt-engine-3.5]: aaa: provide UI error for builtin krbldap

2014-11-06 Thread yzaslavs
Yair Zaslavsky has posted comments on this change. Change subject: aaa: provide UI error for builtin krbldap .. Patch Set 1: Ondra, please verify -- To view, visit http://gerrit.ovirt.org/34908 To unsubscribe, visit http://ge

[Engine-patches] Change in ovirt-engine[ovirt-engine-3.5]: aaa: provide UI error for builtin krbldap

2014-11-06 Thread yzaslavs
Hello Ondřej Macháček, I'd like you to do a code review. Please visit http://gerrit.ovirt.org/34908 to review the following change. Change subject: aaa: provide UI error for builtin krbldap .. aaa: provide UI error for bu

[Engine-patches] Change in ovirt-engine[ovirt-engine-3.5]: aaa: provide UI error for builtin krbldap

2014-11-06 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: aaa: provide UI error for builtin krbldap .. Patch Set 1: * Update tracker::#1106435::OK * Check Bug-Url::OK * Check Public Bug::#1106435::OK, public bug

[Engine-patches] Change in ovirt-engine[master]: aaa: provide UI error for builtin krbldap

2014-11-06 Thread yzaslavs
Yair Zaslavsky has submitted this change and it was merged. Change subject: aaa: provide UI error for builtin krbldap .. aaa: provide UI error for builtin krbldap Bug-Url: https://bugzilla.redhat.com/1106435 Change-Id: Idb1d19d

[Engine-patches] Change in ovirt-engine[master]: aaa: provide UI error for builtin krbldap

2014-11-06 Thread yzaslavs
Yair Zaslavsky has posted comments on this change. Change subject: aaa: provide UI error for builtin krbldap .. Patch Set 4: Code-Review+2 Thanks Ondra! -- To view, visit http://gerrit.ovirt.org/34852 To unsubscribe, visit ht

[Engine-patches] Change in ovirt-engine[master]: aaa: provide UI error for builtin krbldap

2014-11-06 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: aaa: provide UI error for builtin krbldap .. Patch Set 5: * Update tracker::#1106435::OK * Check TR::#1106435::ERROR, 3.5.1 should not match .* -- To vi

[Engine-patches] Change in ovirt-engine[master]: core: add keystone url field to external providers

2014-11-06 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: core: add keystone url field to external providers .. Patch Set 4: Build Failed http://jenkins.ovirt.org/job/ovirt-engine_master_create-rpms-quick_ge

[Engine-patches] Change in ovirt-engine[master]: core: add keystone url field to external providers

2014-11-06 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: core: add keystone url field to external providers .. Patch Set 3: Build Failed http://jenkins.ovirt.org/job/ovirt-engine_master_create-rpms-quick_ge

[Engine-patches] Change in ovirt-engine[master]: core: add keystone url field to external providers

2014-11-06 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: core: add keystone url field to external providers .. Patch Set 2: Build Failed http://jenkins.ovirt.org/job/ovirt-engine_master_create-rpms-quick_ge

[Engine-patches] Change in ovirt-engine[master]: core: add keystone url field to external providers

2014-11-06 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: core: add keystone url field to external providers .. Patch Set 4: * Update tracker::#1157999::OK * Check Bug-Url::OK * Check Public Bug::#1157999::OK, pu

[Engine-patches] Change in ovirt-engine[master]: core: add keystone url field to external providers

2014-11-06 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: core: add keystone url field to external providers .. Patch Set 3: * Update tracker::#1157999::OK * Check Bug-Url::OK * Check Public Bug::#1157999::OK, pu

[Engine-patches] Change in ovirt-engine[master]: core: add keystone url field to external providers

2014-11-06 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: core: add keystone url field to external providers .. Patch Set 2: * Update tracker::#1157999::OK * Check Bug-Url::OK * Check Public Bug::#1157999::OK, pu

[Engine-patches] Change in ovirt-engine[master]: core: add keystone url field to external providers

2014-11-06 Thread emesika
Eli Mesika has posted comments on this change. Change subject: core: add keystone url field to external providers .. Patch Set 1: (4 comments) http://gerrit.ovirt.org/#/c/34880/1/backend/manager/modules/common/src/main/java/or

[Engine-patches] Change in ovirt-engine[master]: userportal, webadmin: moved duplicate UICommand creation to s...

2014-11-06 Thread awels
Alexander Wels has posted comments on this change. Change subject: userportal,webadmin: moved duplicate UICommand creation to static factory methods .. Patch Set 10: Code-Review+2 Nice patch, did you verify? -- To view, visi

[Engine-patches] Change in ovirt-engine[master]: gwt-common: Remove unused AbstractSubTabTreeWidget

2014-11-06 Thread awels
Alexander Wels has posted comments on this change. Change subject: gwt-common: Remove unused AbstractSubTabTreeWidget .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/34430 To unsubscribe, visit http://g

[Engine-patches] Change in ovirt-engine[master]: frontend: Pass JSESSIONID in VV file

2014-11-06 Thread awels
Alexander Wels has posted comments on this change. Change subject: frontend: Pass JSESSIONID in VV file .. Patch Set 9: (1 comment) So I don't under stand this: Due to the fact that uicommon does not see the generated gwt-p

[Engine-patches] Change in ovirt-engine[master]: engine: don't read external files in unit test

2014-11-06 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: engine: don't read external files in unit test .. Patch Set 4: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_master_compile_checkstyle_g

[Engine-patches] Change in ovirt-engine[master]: core: configurable ssl protocol

2014-11-06 Thread emesika
Eli Mesika has posted comments on this change. Change subject: core: configurable ssl protocol .. Patch Set 11: Code-Review+1 (1 comment) http://gerrit.ovirt.org/#/c/34372/11/packaging/etc/engine-config/engine-config.propertie

[Engine-patches] Change in ovirt-engine[master]: core: configurable ssl protocol

2014-11-06 Thread Alon Bar-Lev
Alon Bar-Lev has posted comments on this change. Change subject: core: configurable ssl protocol .. Patch Set 11: (1 comment) http://gerrit.ovirt.org/#/c/34372/11/packaging/etc/engine-config/engine-config.properties File packa

[Engine-patches] Change in ovirt-engine[master]: userportal, webadmin: fixed tabindexes for login pages

2014-11-06 Thread awels
Alexander Wels has posted comments on this change. Change subject: userportal, webadmin: fixed tabindexes for login pages .. Patch Set 2: So I am a little confused about the manual set. Would it make sense to have a tabIndex v

[Engine-patches] Change in ovirt-engine[ovirt-engine-3.5]: core: Empty Change CD List when ISO is Inactive

2014-11-06 Thread emesika
Eli Mesika has posted comments on this change. Change subject: core: Empty Change CD List when ISO is Inactive .. Patch Set 3: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/34866 To unsubscribe, visit http://gerrit.o

[Engine-patches] Change in ovirt-engine[master]: core: Add foreign keys from async_tasks to command_entities

2014-11-06 Thread emesika
Eli Mesika has posted comments on this change. Change subject: core: Add foreign keys from async_tasks to command_entities .. Patch Set 1: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/34874 To unsubscribe, visit htt

[Engine-patches] Change in ovirt-engine[master]: engine: don't read external files in unit test

2014-11-06 Thread Alon Bar-Lev
Alon Bar-Lev has posted comments on this change. Change subject: engine: don't read external files in unit test .. Patch Set 4: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/34678 To unsubscribe, visit http://gerrit.

[Engine-patches] Change in ovirt-engine[master]: core: OVFs that aren't stored on any domain should be stored...

2014-11-06 Thread emesika
Eli Mesika has posted comments on this change. Change subject: core: OVFs that aren't stored on any domain should be stored on all .. Patch Set 4: (1 comment) http://gerrit.ovirt.org/#/c/34292/4/packaging/dbscripts/vms_sp.sql

[Engine-patches] Change in ovirt-engine[master]: core: configurable ssl protocol

2014-11-06 Thread emesika
Eli Mesika has posted comments on this change. Change subject: core: configurable ssl protocol .. Patch Set 11: Code-Review-1 (1 comment) http://gerrit.ovirt.org/#/c/34372/11/packaging/etc/engine-config/engine-config.propertie

[Engine-patches] Change in ovirt-engine[master]: engine: don't read external files in unit test

2014-11-06 Thread awels
Alexander Wels has posted comments on this change. Change subject: engine: don't read external files in unit test .. Patch Set 4: Verified+1 -- To view, visit http://gerrit.ovirt.org/34678 To unsubscribe, visit http://gerrit.o

[Engine-patches] Change in ovirt-engine[master]: engine: don't read external files in unit test

2014-11-06 Thread awels
Alexander Wels has posted comments on this change. Change subject: engine: don't read external files in unit test .. Patch Set 3: (1 comment) http://gerrit.ovirt.org/#/c/34678/3/backend/manager/modules/utils/src/test/java/org/

[Engine-patches] Change in ovirt-engine[master]: engine: don't read external files in unit test

2014-11-06 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: engine: don't read external files in unit test .. Patch Set 4: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make su

[Engine-patches] Change in ovirt-engine[master]: mla: deny access to specific ID for users in user level API

2014-11-06 Thread emesika
Eli Mesika has posted comments on this change. Change subject: mla: deny access to specific ID for users in user level API .. Patch Set 3: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/34803 To unsubscribe, visit htt

[Engine-patches] Change in ovirt-engine[master]: engine : Query to fetch list of volumes eligible for geo rep...

2014-11-06 Thread emesika
Eli Mesika has posted comments on this change. Change subject: engine : Query to fetch list of volumes eligible for geo replication .. Patch Set 13: Code-Review-1 (1 comment) http://gerrit.ovirt.org/#/c/33845/13/packaging/dbs

[Engine-patches] Change in ovirt-engine[ovirt-engine-3.5]: core: When ISO domain is attached to multiple DCs it appears...

2014-11-06 Thread emesika
Eli Mesika has posted comments on this change. Change subject: core: When ISO domain is attached to multiple DCs it appears multiple times .. Patch Set 1: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/34784 To unsub

[Engine-patches] Change in ovirt-engine[master]: webadmin: Simplify report redirect

2014-11-06 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: webadmin: Simplify report redirect .. Patch Set 10: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_master_compile_checkstyle_gerrit/36354

[Engine-patches] Change in ovirt-engine[master]: userportal, webadmin: list models managed by GIN

2014-11-06 Thread awels
Alexander Wels has posted comments on this change. Change subject: userportal,webadmin: list models managed by GIN .. Patch Set 16: Verified+1 Everything I have tried appears to be working correctly. -- To view, visit http://

[Engine-patches] Change in ovirt-engine[master]: webadmin: Simplify report redirect

2014-11-06 Thread awels
Alexander Wels has posted comments on this change. Change subject: webadmin: Simplify report redirect .. Patch Set 10: Verified+1 Fixed Vojtechs concerns -- To view, visit http://gerrit.ovirt.org/33550 To unsubscribe, visit h

[Engine-patches] Change in ovirt-engine[master]: webadmin: Simplify report redirect

2014-11-06 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: webadmin: Simplify report redirect .. Patch Set 10: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header m

[Engine-patches] Change in ovirt-engine[master]: webadmin: Simplify report redirect

2014-11-06 Thread awels
Alexander Wels has posted comments on this change. Change subject: webadmin: Simplify report redirect .. Patch Set 9: (2 comments) http://gerrit.ovirt.org/#/c/33550/9/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovi

[Engine-patches] Change in ovirt-engine[master]: jsonrpc: version bump

2014-11-06 Thread piotr . kliczewski
Piotr Kliczewski has posted comments on this change. Change subject: jsonrpc: version bump .. Patch Set 2: Verified+1 Downstream built and mvn artifacts populated. -- To view, visit http://gerrit.ovirt.org/34878 To unsubscrib

[Engine-patches] Change in ovirt-engine[master]: core: Introduce BusinessEntityMap

2014-11-06 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: core: Introduce BusinessEntityMap .. Patch Set 10: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_master_compile_checkstyle_gerrit/36351/

[Engine-patches] Change in ovirt-engine[master]: userportal, webadmin: list models managed by GIN

2014-11-06 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: userportal,webadmin: list models managed by GIN .. Patch Set 16: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_master_compile_checkstyle

[Engine-patches] Change in ovirt-engine[master]: engine: Extract method of network compliance check

2014-11-06 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: engine: Extract method of network compliance check .. Patch Set 3: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_master_compile_checksty

[Engine-patches] Change in ovirt-engine[master]: webadmin: readonly label editors

2014-11-06 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: webadmin: readonly label editors .. Patch Set 2: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_master_compile_checkstyle_gerrit/36352/

[Engine-patches] Change in ovirt-engine[master]: engine, userportal, webadmin: Various code fixes

2014-11-06 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: engine,userportal,webadmin: Various code fixes .. Patch Set 1: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_master_compile_checkstyle_g

[Engine-patches] Change in ovirt-engine[master]: engine: Refactor network compliance enforcement

2014-11-06 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: engine: Refactor network compliance enforcement .. Patch Set 3: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_master_compile_checkstyle_

[Engine-patches] Change in ovirt-engine[master]: engine: Lay foundation for method refactor

2014-11-06 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: engine: Lay foundation for method refactor .. Patch Set 3: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_master_compile_checkstyle_gerri

[Engine-patches] Change in ovirt-engine[master]: userportal, webadmin: list models managed by GIN

2014-11-06 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: userportal,webadmin: list models managed by GIN .. Patch Set 16: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make

[Engine-patches] Change in ovirt-engine[master]: build: Add explicit execution ID for maven-jar-plugin:test-jar

2014-11-06 Thread awels
Alexander Wels has posted comments on this change. Change subject: build: Add explicit execution ID for maven-jar-plugin:test-jar .. Patch Set 2: Code-Review+1 Looks good to me, but I am not a maven expert can one review this,

[Engine-patches] Change in ovirt-engine[master]: webadmin: readonly label editors

2014-11-06 Thread awels
Alexander Wels has posted comments on this change. Change subject: webadmin: readonly label editors .. Patch Set 2: Verified+1 -- To view, visit http://gerrit.ovirt.org/34615 To unsubscribe, visit http://gerrit.ovirt.org/setti

[Engine-patches] Change in ovirt-engine[master]: webadmin: readonly label editors

2014-11-06 Thread awels
Alexander Wels has submitted this change and it was merged. Change subject: webadmin: readonly label editors .. webadmin: readonly label editors - Modified readonly label editors to not use a parser as they are readonly. This

[Engine-patches] Change in ovirt-engine[master]: webadmin: readonly label editors

2014-11-06 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: webadmin: readonly label editors .. Patch Set 2: * Update tracker::IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url found. -- To view, visit

[Engine-patches] Change in ovirt-engine[master]: webadmin: readonly label editors

2014-11-06 Thread kmayilsa
Kanagaraj M has posted comments on this change. Change subject: webadmin: readonly label editors .. Patch Set 2: Code-Review+2 Sorry for the delay. These changes looks fine to me. -- To view, visit http://gerrit.ovirt.org/34

[Engine-patches] Change in ovirt-engine[master]: webadmin: readonly label editors

2014-11-06 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: webadmin: readonly label editors .. Patch Set 2: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matc

[Engine-patches] Change in ovirt-engine[master]: webadmin: readonly label editors

2014-11-06 Thread awels
Alexander Wels has posted comments on this change. Change subject: webadmin: readonly label editors .. Patch Set 1: Guys, no one can give me the information I requested? This is basically asking about some editors that appear

[Engine-patches] Change in ovirt-engine[master]: engine, userportal, webadmin: Various code fixes

2014-11-06 Thread awels
Alexander Wels has posted comments on this change. Change subject: engine,userportal,webadmin: Various code fixes .. Patch Set 1: Verified+1 Just a bunch of Coverity reported issues that I fixed. Fairly minor all of them. --

[Engine-patches] Change in ovirt-engine[master]: core: Introduce BusinessEntityMap

2014-11-06 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: core: Introduce BusinessEntityMap .. Patch Set 10: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header ma

[Engine-patches] Change in ovirt-engine[master]: engine: Lay foundation for method refactor

2014-11-06 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: engine: Lay foundation for method refactor .. Patch Set 3: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure h

[Engine-patches] Change in ovirt-engine[master]: engine: Extract method of network compliance check

2014-11-06 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: engine: Extract method of network compliance check .. Patch Set 3: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, mak

[Engine-patches] Change in ovirt-engine[master]: engine: Refactor network compliance enforcement

2014-11-06 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: engine: Refactor network compliance enforcement .. Patch Set 3: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make s

[Engine-patches] Change in ovirt-engine[master]: userportal, webadmin: list models managed by GIN

2014-11-06 Thread awels
Alexander Wels has posted comments on this change. Change subject: userportal,webadmin: list models managed by GIN .. Patch Set 15: (3 comments) http://gerrit.ovirt.org/#/c/34193/15/frontend/webadmin/modules/uicommonweb/src/ma

[Engine-patches] Change in ovirt-engine[master]: core: add keystone url field to external providers

2014-11-06 Thread masayag
Moti Asayag has posted comments on this change. Change subject: core: add keystone url field to external providers .. Patch Set 1: (5 comments) http://gerrit.ovirt.org/#/c/34880/1/backend/manager/modules/common/src/main/java/o

[Engine-patches] Change in ovirt-engine[master]: engine : Suspend VM fails with a NullPointerException

2014-11-06 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: engine : Suspend VM fails with a NullPointerException .. Patch Set 1: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_master_compile_check

[Engine-patches] Change in ovirt-engine[master]: engine, userportal, webadmin: Various code fixes

2014-11-06 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: engine,userportal,webadmin: Various code fixes .. Patch Set 1: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make su

[Engine-patches] Change in ovirt-engine[master]: engine, userportal, webadmin: Various code fixes

2014-11-06 Thread awels
Alexander Wels has uploaded a new change for review. Change subject: engine,userportal,webadmin: Various code fixes .. engine,userportal,webadmin: Various code fixes - Fixed various Coverity issues, including: - Several getByt

[Engine-patches] Change in ovirt-engine[master]: engine: Monitoring of geo-rep status and statistics

2014-11-06 Thread rnachimu
Ramesh N has posted comments on this change. Change subject: engine: Monitoring of geo-rep status and statistics .. Patch Set 4: (4 comments) http://gerrit.ovirt.org/#/c/34552/4/backend/manager/modules/bll/src/main/java/org/ov

[Engine-patches] Change in ovirt-engine[master]: userportal, webadmin: list models managed by GIN

2014-11-06 Thread vszocs
Vojtech Szocs has posted comments on this change. Change subject: userportal,webadmin: list models managed by GIN .. Patch Set 15: (4 comments) Will review the rest of the patch tomorrow, so far it looks great. http://gerrit.

[Engine-patches] Change in ovirt-engine[master]: engine : Suspend VM fails with a NullPointerException

2014-11-06 Thread rnori
Ravi Nori has posted comments on this change. Change subject: engine : Suspend VM fails with a NullPointerException .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.ovirt.org/34903 To unsubscribe, visit http://gerrit

[Engine-patches] Change in ovirt-engine-sdk[master]: sdk: Apply filter by name/alias after get

2014-11-06 Thread mishka8520
Michael Pasternak has posted comments on this change. Change subject: sdk: Apply filter by name/alias after get .. Patch Set 2: hint: you can find 'filter' in context -- To view, visit http://gerrit.ovirt.org/34892 To unsubsc

[Engine-patches] Change in ovirt-engine[master]: engine : Suspend VM fails with a NullPointerException

2014-11-06 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: engine : Suspend VM fails with a NullPointerException .. Patch Set 1: * Update tracker::#1160876::OK * Check Bug-Url::OK * Check Public Bug::#1160876::OK,

[Engine-patches] Change in ovirt-engine[master]: engine : Suspend VM fails with a NullPointerException

2014-11-06 Thread rnori
Ravi Nori has uploaded a new change for review. Change subject: engine : Suspend VM fails with a NullPointerException .. engine : Suspend VM fails with a NullPointerException Suspending a VM when Async Tasks with no entityInfo s

[Engine-patches] Change in ovirt-engine[master]: engine: Extract method of network compliance check

2014-11-06 Thread masayag
Moti Asayag has posted comments on this change. Change subject: engine: Extract method of network compliance check .. Patch Set 2: (1 comment) http://gerrit.ovirt.org/#/c/34563/2/backend/manager/modules/vdsbroker/src/main/java

[Engine-patches] Change in ovirt-engine[ovirt-engine-3.5]: core: Renamed StorageDomainDAODbFacadeImpl.getStorageDomainI...

2014-11-06 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: core: Renamed StorageDomainDAODbFacadeImpl.getStorageDomainIdForPoolByType .. Patch Set 2: Build Failed http://jenkins.ovirt.org/job/ovirt-engine_3.

[Engine-patches] Change in ovirt-engine[master]: engine: Support replacements in ValidationResult

2014-11-06 Thread masayag
Moti Asayag has posted comments on this change. Change subject: engine: Support replacements in ValidationResult .. Patch Set 1: (2 comments) http://gerrit.ovirt.org/#/c/34855/1/backend/manager/modules/bll/src/main/java/org/ov

[Engine-patches] Change in ovirt-engine-sdk[master]: sdk: Apply filter by name/alias after get

2014-11-06 Thread mishka8520
Michael Pasternak has posted comments on this change. Change subject: sdk: Apply filter by name/alias after get .. Patch Set 2: Code-Review-1 (1 comment) i guess this won't work after Bug #1155967 is fixed, cause ?search won't

[Engine-patches] Change in ovirt-engine-sdk[master]: codegen, sdk: Fix propagation of context

2014-11-06 Thread mishka8520
Michael Pasternak has posted comments on this change. Change subject: codegen, sdk: Fix propagation of context .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/34893 To unsubscribe, visit http://gerrit.o

[Engine-patches] Change in ovirt-engine[ovirt-engine-3.5]: core: Renamed StorageDomainDAO.getStorageDomainByTypeAndPool

2014-11-06 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: core: Renamed StorageDomainDAO.getStorageDomainByTypeAndPool .. Patch Set 2: Build Failed http://jenkins.ovirt.org/job/ovirt-engine_3.5_find-bugs_mer

[Engine-patches] Change in ovirt-engine-sdk-java[master]: [WIP] Remove logging dependencies

2014-11-06 Thread mishka8520
Michael Pasternak has posted comments on this change. Change subject: [WIP] Remove logging dependencies .. Patch Set 1: Code-Review-1 Juan, I think makes sense leaving logging capabilities, as it was designed to make sdk debu

[Engine-patches] Change in ovirt-engine[master]: core: Allow multiple alerts of the same type for host

2014-11-06 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: core: Allow multiple alerts of the same type for host .. Patch Set 3: Build Failed http://jenkins.ovirt.org/job/ovirt-engine_master_create-rpms-quick

  1   2   3   4   5   6   7   >