Eli Mesika has posted comments on this change. Change subject: engine : Query to fetch list of volumes eligible for geo replication ......................................................................
Patch Set 13: Code-Review-1 (1 comment) http://gerrit.ovirt.org/#/c/33845/13/packaging/dbscripts/gluster_georep_sp.sql File packaging/dbscripts/gluster_georep_sp.sql: Line 204: Create or replace FUNCTION GetAllGlusterGeoRepSessions() Line 205: RETURNS SETOF gluster_georep_session STABLE Line 206: AS $procedure$ Line 207: BEGIN Line 208: RETURN QUERY SELECT session_id, master_volume_id, session_key, slave_host_uuid, This simply returns all fields Please do a "select *" instead since if you will add fields in future you will have to explicitly add it. In general, when all fields are retrieve there is no point in listing the fields Line 209: slave_host_name, slave_volume_id, slave_volume_name, status, Line 210: _create_date, _update_date Line 211: FROM gluster_georep_session; Line 212: END; $procedure$ -- To view, visit http://gerrit.ovirt.org/33845 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0fc3ecb15535181f1ca2a8780461cb89788a3f41 Gerrit-PatchSet: 13 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: anmolbabu <anb...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayi...@redhat.com> Gerrit-Reviewer: Ramesh N <rnach...@redhat.com> Gerrit-Reviewer: Sahina Bose <sab...@redhat.com> Gerrit-Reviewer: Shubhendu Tripathi <shtri...@redhat.com> Gerrit-Reviewer: anmolbabu <anb...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
