Alexander Wels has posted comments on this change. Change subject: userportal,webadmin: list models managed by GIN ......................................................................
Patch Set 15: (3 comments) http://gerrit.ovirt.org/#/c/34193/15/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/Model.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/Model.java: Line 536: */ Line 537: @Inject Line 538: public final void setEventBus(EventBus eventBus) { Line 539: assert eventBus != null : "EventBus cannot be null"; //$NON-NLS-1$ Line 540: assert this.eventBus == null : "EventBus is already set"; //$NON-NLS-1$ > Since EventBus is now provided by GIN, I guess we could also remove above a Done Line 541: this.eventBus = eventBus; Line 542: registerHandlers(); Line 543: } Line 544: http://gerrit.ovirt.org/#/c/34193/15/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ImportVmFromExportDomainModel.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ImportVmFromExportDomainModel.java: Line 105: private void setCpuProfiles(ListModel<CpuProfile> value) { Line 106: cpuProfiles = value; Line 107: } Line 108: Line 109: // TODO: should the above be a CpuProfileListModel? > Maybe you can reach out to Virt UI maintaners via engine-devel list about t Yeah, this is the only odd thing I have left at this point. Line 110: // private final CpuProfileListModel cpuProfiles; Line 111: // Line 112: // public CpuProfileListModel getCpuProfiles() { Line 113: // return cpuProfiles; http://gerrit.ovirt.org/#/c/34193/15/frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/gin/UiCommonModule.java File frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/gin/UiCommonModule.java: Line 54: bind(UserPortalBasicListProvider.class).in(Singleton.class); Line 55: Line 56: // Extended tab: Virtual Machine Line 57: bind(UserPortalListProvider.class).in(Singleton.class); Line 58: bind(new TypeLiteral<UserPortalDetailModelProvider<UserPortalListModel, VmGeneralModel>>(){}) > An alternative to using TypeLiteral is to use @Provides methods that return I got rid of the @Provides methods in favor of this, a lot less code. Line 59: .in(Singleton.class); Line 60: bind(new TypeLiteral<UserPortalDetailModelProvider<UserPortalListModel, PoolGeneralModel>>(){}) Line 61: .in(Singleton.class); Line 62: bind(VmInterfaceListModelProvider.class).in(Singleton.class); -- To view, visit http://gerrit.ovirt.org/34193 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3a2f8915203f4a2b9868767419351ef7ac702891 Gerrit-PatchSet: 15 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alexander Wels <aw...@redhat.com> Gerrit-Reviewer: Alexander Wels <aw...@redhat.com> Gerrit-Reviewer: Lior Vernia <lver...@redhat.com> Gerrit-Reviewer: Martin Betak <mbe...@redhat.com> Gerrit-Reviewer: Martin Mucha <mmu...@redhat.com> Gerrit-Reviewer: Martin Peřina <mper...@redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjeli...@redhat.com> Gerrit-Reviewer: Vojtech Szocs <vsz...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
