Greg Padgett has posted comments on this change. Change subject: engine : CommandBase should not set end status for commands with callback ......................................................................
Patch Set 1: Verified+1 Code-Review+1 Thanks Ravi, looks good and helps solve the problem. Maybe one day we can remove the contortions required in RemoveSnapshotSingleDiskLiveCommand. -- To view, visit http://gerrit.ovirt.org/34845 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I84c05917003376d2f62d3da7acecd889f8cb79e0 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <rn...@redhat.com> Gerrit-Reviewer: Greg Padgett <gpadg...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Ravi Nori <rn...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
