Alon Bar-Lev has posted comments on this change. Change subject: core: configurable ssl protocol ......................................................................
Patch Set 11: (1 comment) http://gerrit.ovirt.org/#/c/34372/11/packaging/etc/engine-config/engine-config.properties File packaging/etc/engine-config/engine-config.properties: Line 37: EnableVdsLoadBalancing.validValues=true,false Line 38: EncryptHostCommunication.description="Determine whether to use secure communication with hosts" Line 39: EncryptHostCommunication.type=Boolean Line 40: VdsmSSLProtocol.description="Determines protocol used by vdsm" Line 41: VdsmSSLProtocol.type=String > Please add validation for values no, there are more fields and also other engines that can be added to java, there is no limit to what user can specify here as long as java can resolve it. Line 42: FreeSpaceCriticalLowInGB.description="Critical low disk space alert threshold (in GB)" Line 43: FreeSpaceCriticalLowInGB.type=Integer Line 44: FreeSpaceCriticalLowInGB.validValues=0..2147483647 Line 45: FreeSpaceLow.description="Limit of % free disk-space below which it is considered low" -- To view, visit http://gerrit.ovirt.org/34372 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I33a33c15e8a995eb8de7d5131b3dbadc6191f873 Gerrit-PatchSet: 11 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: Saggi Mizrahi <smizr...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
