Moti Asayag has posted comments on this change. Change subject: engine: Extract method of network compliance check ......................................................................
Patch Set 2: (1 comment) http://gerrit.ovirt.org/#/c/34563/2/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/HostNetworkTopologyPersisterImpl.java File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/HostNetworkTopologyPersisterImpl.java: Line 91: Line 92: return NonOperationalReason.NONE; Line 93: } Line 94: Line 95: public void auditNetworkCompliance(VDS host, > why is this public? is it used out of this class? If yes, should it be part just eclipse default modifier when extracting a method... will fix Line 96: List<VdsNetworkInterface> dbIfaces, Line 97: final List<Network> clusterNetworks) { Line 98: Map<String, Network> clusterNetworksByName = Entities.entitiesByName(clusterNetworks); Line 99: final Collection<Network> dbHostNetworks = findNetworksOnInterfaces(dbIfaces, clusterNetworksByName); -- To view, visit http://gerrit.ovirt.org/34563 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iadc66b853055b7237f9dbe78793f53bb20299b04 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: Alona Kaplan <alkap...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzasp...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
