Alexander Wels has posted comments on this change. Change subject: frontend: Pass JSESSIONID in VV file ......................................................................
Patch Set 9: (1 comment) So I don't under stand this: Due to the fact that uicommon does not see the generated gwt-p events and handlers we need to attach the listener for RestApiSessionAcquiredEvent in UiCommonDefaultTypeResolver. To prevent excessive number of event listeners attached we cache the created SpiceNativeImpl and VncNativeImpl. As long as you have access to the event bus (and you can inject that in AbstractConsole, you can listen to any events including ones generated from GWT-P. So maybe I am missing something, but you should be able to do this without the need for UiCommonDefaultTypeResolver. Note that UiCommonDefaultTypeResolver is on my hit list to kill soonish. http://gerrit.ovirt.org/#/c/33770/9/frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/server/gwt/GwtDynamicHostPageServlet.java File frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/server/gwt/GwtDynamicHostPageServlet.java: Line 294: } Line 295: } Line 296: Line 297: // Update based on engineSessionTimeout object Line 298: digest.update(request.getAttribute(ATTR_ENGINE_SESSION_TIMEOUT).toString().getBytes()); getBytes uses the default encoding, this will trigger a Coverity warning, please use getBytes("UTF-8"). I have just posted a patch that fixes the other uses of that in this class. Line 299: Line 300: return digest; Line 301: } Line 302: -- To view, visit http://gerrit.ovirt.org/33770 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id5c6d2c91b99240527760b57a6079b5f986aff5b Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Betak <mbe...@redhat.com> Gerrit-Reviewer: Alexander Wels <aw...@redhat.com> Gerrit-Reviewer: Frank Kobzik <fkob...@redhat.com> Gerrit-Reviewer: Martin Betak <mbe...@redhat.com> Gerrit-Reviewer: Michal Skrivanek <mskri...@redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjeli...@redhat.com> Gerrit-Reviewer: Vojtech Szocs <vsz...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
