Moti Asayag has posted comments on this change. Change subject: engine: Support replacements in ValidationResult ......................................................................
Patch Set 1: (2 comments) http://gerrit.ovirt.org/#/c/34855/1/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ValidationResult.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ValidationResult.java: Line 160: * @param expectedError Line 161: * The error we expect should the validation fail. Line 162: * @return A helper object that returns the correct validation result depending on the condition. Line 163: */ Line 164: public static ValidationResultBuilder failWith(VdcBllMessages expectedError) { > This is redundant after adding the overloaded method why ? without this method you'll face NPE in ValidationResult c'tor Line 165: return new ValidationResultBuilder(expectedError); Line 166: } Line 167: Line 168: /** Line 211: private ValidationResultBuilder(VdcBllMessages expectedError, String[] replacements) { Line 212: expectedValidation = new ValidationResult(expectedError, replacements); Line 213: } Line 214: Line 215: private ValidationResultBuilder(VdcBllMessages expectedError) { > This is redundant after adding the overloaded constructor and removing the same as above. Line 216: expectedValidation = new ValidationResult(expectedError); Line 217: } Line 218: Line 219: /** -- To view, visit http://gerrit.ovirt.org/34855 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5f2bd85af2d129e0647b100b90908a1314419da2 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: Alona Kaplan <alkap...@redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkole...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzasp...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
